summaryrefslogtreecommitdiff
path: root/lib/libcrypto
AgeCommit message (Collapse)Author
2015-06-20Fix warning on vax due to old gcc.Doug Hogan
Old gcc warns when parameters have the same names as functions. Noticed by deraadt@. ok deraadt@ jsing@
2015-06-20Crank major for libcrypto, ssl and tls due to MDC-2DES removal.Doug Hogan
ok miod@ jsing@
2015-06-20Remove obsolete MDC-2DES from libcrypto.Doug Hogan
ok deraadt@ jsing@ miod@
2015-06-19Return the failing engine ID in the error stack.Brent Cook
Noted by doug@ in an earlier revision of the dynamic engine removal patch, but I had forgotten to include it in the latest version.
2015-06-19Disable ENGINE_load_dynamic (dynamic engine support).Brent Cook
We do not build, test or ship any dynamic engines, so we can remove the dynamic engine loader as well. This leaves a stub initialization function in its place. ok beck@, reyk@, miod@
2015-06-13Fix bad indenting in LibreSSL.Doug Hogan
jsg@ noticed that some of the lines in libssl and libcrypto are not indented properly. At a quick glance, it looks like it has a different control flow than it really does. I checked the history in our tree and in OpenSSL to make sure these were simple mistakes. ok miod@ jsing@
2015-06-13Remove unneeded sys/sysctl.h on linux.Brent Cook
This only provides the sysctl wrapper in glibc, which we do not use and is not available in other libc implementations for Linux. Thanks to ncopa from github.
2015-06-11Avoid an infinite loop that can occur when verifying a message with anJoel Sing
unknown hash function OID. Diff based on OpenSSL. Fixes CVE-2015-1792 (however, this code is not enabled/built in LibreSSL). ok doug@ miod@
2015-06-11Avoid a potential out-of-bounds read in X509_cmp_time(), due to missingJoel Sing
length checks. Diff based on changes in OpenSSL. Fixes CVE-2015-1789. ok doug@
2015-06-11Avoid an infinite loop that can be triggered by parsing an ASN.1Joel Sing
ECParameters structure that has a specially malformed binary polynomial field. Issue reported by Joseph Barr-Pixton and fix based on OpenSSL. Fixes CVE-2015-1788. ok doug@ miod@
2015-05-26Add OPENSSL_NO_EGD to opensslfeatures.h.Brent Cook
Since RAND_egd has been removed from LibreSSL, simplify porting software that relies on it. See https://github.com/libressl-portable/openbsd/pull/34 from Bernard Spil, ok deraadt@
2015-05-23bump to version 2.2Brent Cook
ok deraadt@
2015-05-20No need to check the return value of memcpy() if you actually checked thisMiod Vallat
pointer for NULL the line above; ok doug@
2015-05-17Record inter-library dependencies between libcrypto, libssl and libtlsMark Kettenis
2015-05-15Fix return paths with missing EVP_CIPHER_CTX_cleanup() calls.Jonathan Gray
ok doug@
2015-04-30use strdup() to init stringTheo de Raadt
ok doug millert
2015-04-29Add missing BN_CTX_end() calls.Doug Hogan
After calling BN_CTX_start(), there must be a BN_CTX_end() before returning. There were missing BN_CTX_end() calls in error paths. One diff chunk was simply removing redundant code related to this. ok deraadt@
2015-04-27Not all Linux libc's include linux/sysctl.h in sys/sysctl.h.Brent Cook
Include it if we have the sysctl syscall.
2015-04-27Support AIX versions without WPAR support.Brent Cook
From Michael Felt.
2015-04-25Don't ignore the reference count in X509_STORE_free.Doug Hogan
Based on this upstream commit: bff9ce4db38b297c72a6d84617d71ae2934450f7 which didn't make it into a release until 1.0.2. Thanks to william at 25thandclement dot com for reporting this! ok deraadt@ jsing@ beck@
2015-04-23Do not need to buf[0] = 0 before strlcpy(buf, ...Theo de Raadt
2015-04-12Remove d2i_X509_PKEY and i2d_X509_PKEY from the SSLeay days.Doug Hogan
i2d_X509_PKEY is a "needs to implement" and d2i_X509_PKEY is broken. Removed upstream in commit b1f3442857c1fd76e91941141bf671d19e90a79d. ok deraadt@, jsing@
2015-04-11Send OPENSSL_issetugid() straight to hell, no final cigarette.Theo de Raadt
The issetugid() API is supposed to make a strong promise where "0 means it is safe to look at the environment". Way back in the past someone on the OpenSSL team responded to the environment access danger by creating a wrapper called OPENSSL_issetugid, and went to use it a number of places. However, by default on systems lacking true issetugid(), OPENSSL_issetugid returns 0. 0 indicating safely. False safety. Which means OPENSSL_issetugid() fails to make any sort of promise about safety, in fact it is just the opposite. Can you believe the OpenSSL team? This nastiness was noticed over the years, however noone could gain traction and get it fixed in OpenSSL. Also see a paragraph about this in http://www.tedunangst.com/flak/post/worst-common-denominator-programming ok jsing
2015-04-11Remove all getenv() calls, especially those wrapped by issetugid().Theo de Raadt
getenv()'s wrapped by issetugid() are safe, but issetugid() is correct difficult to impliment on many operating systems. By accident, a grand experiment was run over the last year, where issetugid() returned 1 (the safe value) on a few operating systems. Noone noticed & complained that certain environment variables were not working....... ok doug beck jsing, discussion with others
2015-03-30add initial AIX getentropy/arc4random files. Thanks to Michael Felt.Brent Cook
2015-03-22sys/sysctl.h includes linux/sysctl.h, remove the extra unchecked includeBrent Cook
2015-03-21Fix indentation that incorrectly implies a different control flow.Doug Hogan
The actual control flow is intentional while the indenting is incorrect. This is intended to be a cosmetic change. Verified that each of these was part of a KNF commit that wasn't intending to change behavior. Also, double checked against the history of changes in OpenSSL and BoringSSL. Addresses Coverity CIDs: 78842, 78859, 78863. ok tedu@
2015-03-20Fix a memory leak in an error path.Doug Hogan
From OpenSSL commit 5e5d53d341fd9a9b9cc0a58eb3690832ca7a511f. ok guenther@, logan@
2015-03-19Fix several crash causing defects from OpenSSL.Ted Unangst
These include: CVE-2015-0209 - Use After Free following d2i_ECPrivatekey error CVE-2015-0286 - Segmentation fault in ASN1_TYPE_cmp CVE-2015-0287 - ASN.1 structure reuse memory corruption CVE-2015-0289 - PKCS7 NULL pointer dereferences Several other issues did not apply or were already fixed. Refer to https://www.openssl.org/news/secadv_20150319.txt joint work with beck, doug, guenther, jsing, miod
2015-03-18In the neverending saga of enabling and disabling assembler code for shaMiod Vallat
routines on hppa, the cause for sha512-parisc subtly misbehaving has been found: despite having fallback pa1.1 code when running on a 32-bit cpu, the shift constants used in the sigma computations in sha512 are >= 32 and are silently truncated to 5 bits by the assembler, so there is no chance of getting this code to work on a non-pa2.0 processor. However, the pa1.1 fallback code for sha256 is safe, as it never attempts to shift by more than 31, so reenable it again.
2015-03-15Avoid a NULL pointer deref when X509_get_pubkey() returns NULL.Doug Hogan
A NULL pointer could be dereferenced when X509_REQ_set_pubkey() calls X509_PUBKEY_set() with pktmp. OpenSSL says it's the fix for CVE-2015-0288, but there aren't any public details yet to confirm. Either way, we should fix this. Based on OpenSSL commit 28a00bcd8e318da18031b2ac8778c64147cd54f9 and BoringSSL commit 9d102ddbc0f6ed835ed12272a3d8a627d6a8e728. "looks sane" beck@ ok miod@, bcook@
2015-03-05Do not use sha512-parisc for now, as it is subtly bugged - passes the shaMiod Vallat
regress tests but causes tls ciphersuite using sha386 to fail; found the hard way by henning@. I can't see anything wrong in the generated assembly code yet, but building a libcrypto with no assembler code but sha512_block_data_order() is enough to trigger Henning's issue, so the bug lies there. No ABI change; ok deraadt@
2015-02-25Fix CVE-2014-3570: properly calculate the square of a BIGNUM value.Brent Cook
See https://www.openssl.org/news/secadv_20150108.txt for a more detailed discussion. Original OpenSSL patch here: https://github.com/openssl/openssl/commit/a7a44ba55cb4f884c6bc9ceac90072dea38e66d0 The regression test is modified a little for KNF. ok miod@
2015-02-22Bump libcrypto and libssl majors, due to various recent churn.Joel Sing
Discussed with/requested by deraadt@ at the conclusion of s2k15.
2015-02-22Remove IMPLEMENT_STACK_OF noops.Joel Sing
2015-02-19If BN_rand() or BN_pseudo_rand() are called with a NULL rnd argument,Joel Sing
BN_bin2bn() will helpfully allocate a BN which is then leaked. Avoid this by explicitly checking for NULL at the start of the bnrand() function. Fixes Coverity ID 78831. ok miod@
2015-02-17Memory leak in error path. Coverity CID 78822.Miod Vallat
ok doug@
2015-02-15Avoid calling BN_CTX_end() on a context that wasn't started.Doug Hogan
In dsa_builtin_paramgen(), if BN_MONT_CTX_new() fails, the BN_CTX_new() call above it will have allocated a ctx without calling BN_CTX_start() on it. The error handling calls BN_CTX_end() when ctx is allocated. Move the BN_MONT_CTX_new() call up so it will fail first without splitting up the BN_CTX_new() and BN_CTX_start(). tweak + ok miod@, ok bcook@
2015-02-15RegenMiod Vallat
2015-02-15If we decide to discard the provided seed buffer because its size is notMiod Vallat
large enough, do it correctly so that the local seed buffer on the stack gets properly initialized in the first iteration of the loop. While there, remove an outdated and bogus comment. Coverity CID 21785 ok doug@ jsing@
2015-02-15Check ASN1_OCTET_STRING_new() for failure. Coverity CID 78904Miod Vallat
ok doug@
2015-02-15In ec_wNAF_mul(), move the declaration of tmp_wNAF higher in scope, so thatMiod Vallat
all the function's exit paths can make sure it gets freed. Coverity CID 78861 tweaks & ok doug@ jsing@
2015-02-14Remove asn1_ex_i2c() prototype, now that this function has been made static;Miod Vallat
reminded by bcook@
2015-02-14Words read better when they are separated by spaces.Miod Vallat
2015-02-141.18 would introduce a possible out-of-bounds access in the error path;Miod Vallat
Coverity CID 105346 ok doug@
2015-02-14Remove DEBUG_PKCS5V2 code.Miod Vallat
2015-02-14Unchecked allocations in x509_name_canon().Miod Vallat
ok doug@ jsing@
2015-02-14Memory leak upon error in X509_add1_{trust,reject}_object.Miod Vallat
ok doug@
2015-02-14Manually expand IMPLEMENT_EXTERN_ASN1 macro (the only occurence in crypto).Joel Sing
Only change to generated assembly is due to line numbers.
2015-02-14Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it inMiod Vallat
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded copies of OpenSSL. ok jsing@
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-03 22:25:42 +0000