Age | Commit message (Collapse) | Author | |
---|---|---|---|
2024-10-22 | remove duplicate rcs id | Jonathan Gray | |
2024-05-21 | remove prototypes with no matching function | Jonathan Gray | |
2024-02-07 | libkeynote: use DSA_generate_parameters_ex() | Theo Buehler | |
DSA_generate_parameters() was deprecated in 2002. Its removal was blocked because someone added "enhanced DSA support" to rust-openssl. Fortunately this was fixed recently by the pyca people. So we can remove it now. Of course, DSA_generate_parameters_ex() wasn't an improvement. While it no longer uses the old callback version, it also needs a DSA object passed in thus making it more annoying for callers. ok jsing | |||
2023-04-13 | Use ANSI-style functions for Base64 wrappers | Theo Buehler | |
Silences a few -Wdeprecated-non-prototype warnings emitted by clang 15. ok bluhm miod | |||
2022-12-27 | spelling fixes; from paul tagliamonte | Jason McIntyre | |
any changes not taken noted on tech, but chiefly here i did not take the cancelation - cancellation changes; | |||
2022-11-30 | Passing preallocated keys to d2i_RSAPublicKey() does not work anymore | Alexander Bluhm | |
with LibreSSL. This caused a crash in isakmpd with libkeynote. Better pass NULL and let libcrypto do the allocation. from markus@; OK tb@ | |||
2022-03-31 | man pages: add missing commas between subordinate and main clauses | Christian Weisgerber | |
jmc@ dislikes a comma before "then" in a conditional, so leave those untouched. ok jmc@ | |||
2022-02-18 | prefer https links in man pages | Jonathan Gray | |
ok gnezdo@ miod@ jmc@ | |||
2022-02-06 | remove please from manual pages | Jonathan Gray | |
ok jmc@ sthen@ millert@ | |||
2022-01-14 | libkeynote: fix build with opaque RSA and DSA | Theo Buehler | |
This is a completely mechanical conversion to use accessors instead of reaching inside the structs by hand. ok millert | |||
2022-01-11 | Garbage collect historical setting of dsa->write_params = 1. | Theo Buehler | |
This is always 1 with modern libs and write_params will soon go away. | |||
2021-11-24 | libkeynote: stop reaching into EVP_PKEY internals. | Theo Buehler | |
Use EVP_PKEY_get0_RSA() instead of pPublicKey->pkey.rsa. Fix a couple of leaks in the vicinity: we need a reference on the RSA, which is what keynote_free_key() frees, not on the EVP_PKEY. Also, don't leak the entire certificate on success. ok beck | |||
2021-10-24 | For open/openat, if the flags parameter does not contain O_CREAT, the | Theo de Raadt | |
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert | |||
2021-06-12 | space between rfc and number; | Jason McIntyre | |
2021-01-18 | Move sessid definition to keynote-verify.c to avoid issues with -fno-common | mortimer | |
ok deraadt@ | |||
2019-06-28 | When system calls indicate an error they return -1, not some arbitrary | Theo de Raadt | |
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future. | |||
2017-08-28 | Add %option noinput to suppress an unused function warning. | Todd C. Miller | |
Noticed by and OK ottot@ | |||
2017-07-05 | fix cross references to self; found with mandoc -Tlint | Ingo Schwarze | |
2017-07-02 | repair the tree, make sure y.tab.h is there before compiling yacc files. | Marc Espie | |
problem noticed by deraadt@ | |||
2017-06-10 | remove lots of bogus escaping, some of which even broke the output; | Ingo Schwarze | |
found with mandoc -Tlint | |||
2017-06-10 | fix imprecise .Fa markup; found with mandoc -Tlint | Ingo Schwarze | |
2017-05-09 | Prevent memory leak on sbuf by freeing it unconditionally and ensure | Ricardo Mestre | |
finalbuf is also free'd if kn_encode_base64 somehow fails hint from tb@, OK millert@ and tb@ | |||
2017-04-27 | Remove useless check for ks_env_table being NULL. Since ks_env_table | Todd C. Miller | |
is an array embedded in struct keynote_session it can never be NULL. Quiets a clang warning. | |||
2016-03-30 | for some time now mandoc has not required MLINKS to function | Jason McIntyre | |
correctly - logically complete that now by removing MLINKS from base; authors need only to ensure there is an entry in NAME for any function/ util being added. MLINKS will still work, and remain for perl to ease upgrades; ok nicm (curses) bcook (ssl) ok schwarze, who provided a lot of feedback and assistance ok tb natano jung | |||
2015-12-23 | remove two NULL casts | mmcc | |
2015-12-23 | Remove the rest of the scaffolding for nonexistent ElGamal support, | mmcc | |
which has been disabled for sixteen years. ok millert@, tb@, sthen@ | |||
2015-12-23 | Remove NULL casts and tweak style in a few places. A more invasive | mmcc | |
version of this diff was reviewed by tb@ | |||
2015-12-23 | remove a few NULL-checks before free() | mmcc | |
2015-12-20 | Clean up a condition. No functional change. ok tb@ | mmcc | |
2015-12-19 | Style cleanup and removal of needless casts. ok tb@ | mmcc | |
2015-12-19 | More style improvement and removal of NULL/allocation casts. | mmcc | |
ok tb@ | |||
2015-12-18 | Remove code for unimplemented ElGamel support that's been disabled for | mmcc | |
sixteen years. ok millert@, tb@, sthen@ | |||
2015-12-18 | A few more NULL casts and style tweaks. No functional change. | mmcc | |
2015-12-18 | Cleanup and modernization. No functional change. Discussed with halex@. | mmcc | |
2015-12-14 | Remove more needless casts of NULL and allocations. | mmcc | |
2015-12-14 | Remove casts of allocations and NULL. There are a *ton* of these to | mmcc | |
remove in libkeynote, but I'm doing it in small chunks so I don't slip up. Previously discussed and approved on the lists, although I backed off after making a dumb mistake in a mega-diff. | |||
2015-12-14 | Remove NULL-checks before free(). | mmcc | |
2015-12-14 | s/begining/beginning/g | mmcc | |
2015-11-20 | No longer direct bug reports to keynote@research.att.com - it bounces mail. | mmcc | |
"fair enough" jmc@ | |||
2015-11-19 | lexer fixes to work with new flex. from Serguey Parkhomovsky | Ted Unangst | |
2015-11-19 | Fix typo in previous commit | Philip Guenther | |
2015-11-19 | Remove a sixteen-year-old testing macro. | mmcc | |
"yes." deraadt@ | |||
2015-11-19 | Remove a ton of ugly, needless casts for NULL, calloc(), and strdup(). | mmcc | |
No binary change. | |||
2015-11-18 | Remove memory.h includes. | mmcc | |
ok deraadt@ | |||
2015-11-10 | update NAME section to include all documented functions, | Jason McIntyre | |
or otherwise change Dt to reflect the name of an existing function; feedback/ok schwarze | |||
2015-09-23 | fix function argument. | Igor Sobrado | |
ok jmc@, schwarze@ | |||
2015-09-14 | Avoid .Ns right after .Pf, it's pointless. | Ingo Schwarze | |
In some cases, do additional cleanup in the immediate vicinity. | |||
2015-09-10 | use .In rather than .Fd #include | Ingo Schwarze | |
2015-02-04 | Replace realloc() with reallocarray() in libkeynote. Do not free | Alexander Bluhm | |
keynote_lex_list after it has been reallocated. Found by Benjamin Baier with llvm/scan-build; OK florian@ | |||
2014-12-05 | macro cleanup: remove bogus .Nm and split joint .Fn arguments | Ingo Schwarze | |