summaryrefslogtreecommitdiff
path: root/lib/libutil
AgeCommit message (Collapse)Author
2021-08-29fix an obvious mixup regarding the order of lines in the SYNOPSIS,Ingo Schwarze
and an omission below HISTORY
2021-08-29Add ober_dup. Needed for upcoming SNMPv3 support for trap receiver inMartijn van Duren
snmpd(8). OK jmatthew@ OK deraadt@ for bumping libutil now.
2021-06-20scan_scaled: fix rescaling for negative numbersTheo Buehler
As found by djm by fuzzing ssh, scan_scaled can overflow for negative numbers when rescaling is needed. This is because the rescaled fractional part is added without taking the sign into account. ok ian jca
2021-03-31tweak column widths of a .Bl -column tableIngo Schwarze
and avoid an over-long source line while here; OK martijn@ jmc@
2021-03-31change the barrier so that fd's are always passed and received withEric Faurot
the first byte of the imsg they belong to. idea, tweaks and ok claudio@
2021-03-12fix previousJonathan Gray
2021-03-12spellingJonathan Gray
2021-03-05Stop abusing display blocks under the authors section in order toanton
respect literal line breaks. This has the unwanted side effect of rendering the authors section using a monospace font over at man.openbsd.org. Instead use br macros to force line breaks. With help from and ok jmc@
2021-03-03s/byte/characterMartijn van Duren
Discussed with claudio@ Feedback jmc@
2021-02-22Make the ober_get_* set of function to accept a NULL-pointer.Martijn van Duren
This allows us to do ber-type checking inside ober_scanf_elements, which will allow for stricter ASN.1 parsing in the future. Manpage feedback and OK claudio@, jmc@ OK claudio@
2021-01-28Add '$' to ober_scanf_elements().Martijn van Duren
This allows us to enforce end of sequence/set without having to manually check be_next for NULL. No lib bump needed according to millert@ OK millert@ rob@
2021-01-22Gracefully handle any erroneous closing bracket/brace trailers inrob
ober_scanf_elements(). OK martijn@
2021-01-22Valid integer and enumerated types always have non-zero length. Performrob
check to ensure we avoid a possible (undefined) negative shift. Found with clang static analyzer. Tweaked and OK martijn@
2021-01-13Make imsg.h a bit more self-contained by prototyping struct iovec.Claudio Jeker
OK martijn@ mvs@ deraadt@
2020-12-15typo fix from aisha tammy; ok nicmJason McIntyre
2020-10-16double word fixes; from varik valeforJason McIntyre
2020-10-12make fixed-sized fixed-value mib[] arrays be constTheo de Raadt
ok guenther tb millert
2020-09-04Create ERRORS section for ober_read_elements.Martijn van Duren
Tweaks and OK tb@ OK jmc@
2020-09-03Missed one case of errno not being set in previous.Martijn van Duren
double check and OK tb@
2020-09-03Make sure ober_read_elements sets errno on every case where NULL isMartijn van Duren
returned. OK deraadt@ tb@
2020-08-02Squelch warning by using idiom from libc bcrypt(3)Theo Buehler
Clang 10 warns about the expression sizeof(cdata) / sizeof(uint64_t) as cdata is an array of uint32_t and it expects that the intent of this is to compute the number of array elements. Use BCRYPT_WORDS / 2 instead. Same diff as millert's commit sys/lib/libsa/bcrypt_pbkdf.c -r1.2, which was ok kettenis. deraadt confirms that this satisfies clang 10.
2019-12-31Increase BER_MAX_OID_LEN from 32 to 64. Not every snmp OID found in theMartijn van Duren
wild fits inside 32 elements, like UsmUserEntry objects. OK rob@, claudio@
2019-11-21zero tmpout too. reminded by related diff from timTed Unangst
2019-11-21overwrite the key in failure modes in case the caller doesn't check.Ted Unangst
ok deraadt
2019-10-25Adjust whitespace, so Ta macros are aligned vertically as already done inTheo Buehler
ober_add_string.3 and as it was before the ber -> ober rename.
2019-10-24The ber_* namespace is used by liblber since time immemorial,Theo Buehler
so move our BER API to the unused ober_* prefix to avoid some breakage in ports. Problem diagnosed by jmatthew with ber_free() in samba, but there are many others as pointed out by sthen. tests & ok rob ok sthen (who had an almost identical diff for libutil) "go head hit it" deraadt
2019-08-30uucplock(3) is incorrectly named in some places, it is actually uu_lock(3)Theo de Raadt
(more unclear is if anything in ports uses this, as our base no longer does)
2019-08-15Revert previous. There were some users of the quirky behaviour that wereMartijn van Duren
missed during code scan.
2019-08-14Fix argument list for ber_set_writecallbackMartijn van Duren
OK claudio@
2019-08-14wonky comma;Jason McIntyre
2019-08-14Document that ber_scanf_elements' 'p' and 't' attribute don't eat theMartijn van Duren
current ber element. OK claudio@ Seems sensible to deraadt@
2019-08-14Make ber_scanf_elements's 'e' attribute eat the element.Martijn van Duren
Right now all consumers use 'e' at the end of the list, so no regressions should be introduced. OK claudio@ Seems sensible to deraadt@
2019-08-14Make sure that ber in ber_scanf_elements is not NULL before parsing formatMartijn van Duren
where ber is utilized. This also allows us to remove the ber->be_next check, which can cause weird behaviour, because a NULL be_next would result in parsing the last element twice. OK claudio@ on previous version OK rob@
2019-08-05Don't use a 0 element to determine the end of an OID when comparing twoMartijn van Duren
OIDS. This can result in false equality matches. OK claudio@
2019-08-05There's no reason why the first digit of an OID can't be 0.Martijn van Duren
OK claudio@ "Good find" deraadt@
2019-07-03snprintf/vsnprintf return < 0 on error, rather than -1.Theo de Raadt
2019-06-28Actually, the C standard only guarantees that atexit(3) returns non-zeroIngo Schwarze
on error, so tweak previous to test "atexit(...) != 0" for portability. "OK ok ok sorry backwards" deraadt@
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-06-28atexit() returns -1 on failureTheo de Raadt
2019-06-01Limit maximum number of length octets to platform independent sizeof(int32_t).rob
Problem noticed by bluhm@. Discussed on hackers. ok claudio@
2019-05-21whitespacerob
2019-05-21Cleanup some residual markup from the ber.3 days.rob
ok jmc@, schwarze@
2019-05-17add various missing informationIngo Schwarze
and remove the lie that these functions would set errno; tweaks and OK jmc@; OK rob@ on the previous version
2019-05-16Add XXX to a comment.rob
2019-05-16Correct errno markup. Noticed by schwarze.rob
Discussed with schwarze and jmc. ok schwarze
2019-05-15sort SEE ALSO;Jason McIntyre
2019-05-15add substantial amounts of missing information;Ingo Schwarze
OK rob@
2019-05-15Consistently make errno a .Vtrob
2019-05-15delete some duplicate wordsIngo Schwarze
2019-05-15Split ber.3 into logical parts. Further tweaking will be done in tree.rob
Discussed with and ok jmc@, schwarze@, claudio@