summaryrefslogtreecommitdiff
path: root/lib/libutil
AgeCommit message (Collapse)Author
2020-09-04Create ERRORS section for ober_read_elements.Martijn van Duren
Tweaks and OK tb@ OK jmc@
2020-09-03Missed one case of errno not being set in previous.Martijn van Duren
double check and OK tb@
2020-09-03Make sure ober_read_elements sets errno on every case where NULL isMartijn van Duren
returned. OK deraadt@ tb@
2020-08-02Squelch warning by using idiom from libc bcrypt(3)Theo Buehler
Clang 10 warns about the expression sizeof(cdata) / sizeof(uint64_t) as cdata is an array of uint32_t and it expects that the intent of this is to compute the number of array elements. Use BCRYPT_WORDS / 2 instead. Same diff as millert's commit sys/lib/libsa/bcrypt_pbkdf.c -r1.2, which was ok kettenis. deraadt confirms that this satisfies clang 10.
2019-12-31Increase BER_MAX_OID_LEN from 32 to 64. Not every snmp OID found in theMartijn van Duren
wild fits inside 32 elements, like UsmUserEntry objects. OK rob@, claudio@
2019-11-21zero tmpout too. reminded by related diff from timTed Unangst
2019-11-21overwrite the key in failure modes in case the caller doesn't check.Ted Unangst
ok deraadt
2019-10-25Adjust whitespace, so Ta macros are aligned vertically as already done inTheo Buehler
ober_add_string.3 and as it was before the ber -> ober rename.
2019-10-24The ber_* namespace is used by liblber since time immemorial,Theo Buehler
so move our BER API to the unused ober_* prefix to avoid some breakage in ports. Problem diagnosed by jmatthew with ber_free() in samba, but there are many others as pointed out by sthen. tests & ok rob ok sthen (who had an almost identical diff for libutil) "go head hit it" deraadt
2019-08-30uucplock(3) is incorrectly named in some places, it is actually uu_lock(3)Theo de Raadt
(more unclear is if anything in ports uses this, as our base no longer does)
2019-08-15Revert previous. There were some users of the quirky behaviour that wereMartijn van Duren
missed during code scan.
2019-08-14Fix argument list for ber_set_writecallbackMartijn van Duren
OK claudio@
2019-08-14wonky comma;Jason McIntyre
2019-08-14Document that ber_scanf_elements' 'p' and 't' attribute don't eat theMartijn van Duren
current ber element. OK claudio@ Seems sensible to deraadt@
2019-08-14Make ber_scanf_elements's 'e' attribute eat the element.Martijn van Duren
Right now all consumers use 'e' at the end of the list, so no regressions should be introduced. OK claudio@ Seems sensible to deraadt@
2019-08-14Make sure that ber in ber_scanf_elements is not NULL before parsing formatMartijn van Duren
where ber is utilized. This also allows us to remove the ber->be_next check, which can cause weird behaviour, because a NULL be_next would result in parsing the last element twice. OK claudio@ on previous version OK rob@
2019-08-05Don't use a 0 element to determine the end of an OID when comparing twoMartijn van Duren
OIDS. This can result in false equality matches. OK claudio@
2019-08-05There's no reason why the first digit of an OID can't be 0.Martijn van Duren
OK claudio@ "Good find" deraadt@
2019-07-03snprintf/vsnprintf return < 0 on error, rather than -1.Theo de Raadt
2019-06-28Actually, the C standard only guarantees that atexit(3) returns non-zeroIngo Schwarze
on error, so tweak previous to test "atexit(...) != 0" for portability. "OK ok ok sorry backwards" deraadt@
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-06-28atexit() returns -1 on failureTheo de Raadt
2019-06-01Limit maximum number of length octets to platform independent sizeof(int32_t).rob
Problem noticed by bluhm@. Discussed on hackers. ok claudio@
2019-05-21whitespacerob
2019-05-21Cleanup some residual markup from the ber.3 days.rob
ok jmc@, schwarze@
2019-05-17add various missing informationIngo Schwarze
and remove the lie that these functions would set errno; tweaks and OK jmc@; OK rob@ on the previous version
2019-05-16Add XXX to a comment.rob
2019-05-16Correct errno markup. Noticed by schwarze.rob
Discussed with schwarze and jmc. ok schwarze
2019-05-15sort SEE ALSO;Jason McIntyre
2019-05-15add substantial amounts of missing information;Ingo Schwarze
OK rob@
2019-05-15Consistently make errno a .Vtrob
2019-05-15delete some duplicate wordsIngo Schwarze
2019-05-15Split ber.3 into logical parts. Further tweaking will be done in tree.rob
Discussed with and ok jmc@, schwarze@, claudio@
2019-05-12Enable support for the writting of BITSTRING by treating it as an OCTETSTRING.rob
ok claudio@
2019-05-12Enforce smallest number of contents octets for int (and enum).rob
ok claudio@
2019-05-12Mention #include of <sys/types.h> in synopsis.rob
Discussed with claudio@ and tedu@.
2019-05-12Fail early if a (universal) primitive type identifies as constructed, or if arob
boolean has a contents length other than 1. ok claudio@
2019-05-12Enforce minimal number of octets for tag > 30.rob
"sure" claudio@
2019-05-12In long form encoding, explicitly prohibit an initial length octet of 0xffrob
which is reserved for future use. ok claudio@
2019-05-11The BER API is currently used by ldap, ldapd, ldapctl, ypldap, snmpd, androb
snmpctl. Separate copies of ber.[ch] have existed and been maintained in sync in ldap, ldapd, ypldap and snmpd. This commit moves the BER API into /usr/lib/libutil. All current consumers already link libutil. ldapd and snmpd regress passes, and release builds. With help from tb@ and guenther@. ok deraadt@, tb@
2019-04-23missing dots after ".%P pp"; the case of btree(3) wasIngo Schwarze
reported by Fabio Scotoni <fabio at esse dot ch>; also garbage collect one .Tn while here
2019-01-25I am retiring my old email address; replace it with my OpenBSD one.Todd C. Miller
2019-01-20Change imsg header definitions to use standard types.Brent Cook
ok deraadt@ claudio@
2019-01-14Calling llabs(LLONG_MIN) is undefined behavior, llvm 7.0.1 does notAlexander Bluhm
work with our old code. In fmt_scaled() move the check before calling llabs(). found by regress/lib/libutil/fmt_scaled; OK deraadt@ millert@ tedu@
2018-09-26explicitly mention local processes; from geoff hillJason McIntyre
ok nicm
2018-08-10delete volatile intended to silence whiny old compilers around vfork.Theo de Raadt
This variable is only used in the parent context so there is no issue. ok kettenis
2018-05-14constrain fractional part to [0-9] (less confusing to static analysis); ok ian@Damien Miller
2018-02-16Fix function argument names, from Abel Abraham Camarillo Ojeda via jmc@.Nicholas Marriott
2018-01-12Adjust references for sysctl(3) to sysctl(2)Theo de Raadt
2017-12-14Make a few internal symbols static and add a Symbols.map version scriptMark Kettenis
to control which symbols are exported from the shared library. ok guenther@, deraadt@, jca@