summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2020-06-24Document eight additional pre-OpenSSL-1.1 accessor functions that areIngo Schwarze
still widely used according to code searches on the web, so people reading existing code will occasionally want to look them up. While here, correct the return type of X509_CRL_get0_lastUpdate(3) and X509_CRL_get0_nextUpdate(3), which return const pointers. Also, add some precision regarding RETURN VALUES.
2020-06-24Enforce restrictions for ClientHello extensionsTheo Buehler
RFC 8446 section 9.2 imposes some requirements on the extensions sent in the ClientHello: key_share and supported_groups must either both be present or both be absent. If no pre_shared_key was sent, the CH must contain both signature_algorithms and supported_groups. If either of these conditions is violated, servers must abort the handshake with a missing_extensions alert. Add a function that enforces this. If we are going to enforce that clients send an SNI, we can also do this in this function. Fixes failing test case in tlsfuzzer's test-tls13-keyshare-omitted.py ok beck inoguchi jsing
2020-06-22spelling fix;Jason McIntyre
2020-06-22Extend kqueue interface with EVFILT_EXCEPT filter.Martin Pieuchot
This filter, already implemented in macOS and Dragonfly BSD, returns exceptional conditions like the reception of out-of-band data. The functionnality is similar to poll(2)'s POLLPRI & POLLRDBAND and it can be used by the kqfilter-based poll & select implementation. ok millert@ on a previous version, ok visa@
2020-06-20basic macro cleanup: .Fo for long .Fn lines, .Fa for struct fields,Ingo Schwarze
avoid \*(Gt and \*(Lt, .Dv NULL, .Cm for pledge promises
2020-06-20add missing ENVIRONMENT. HISTORY, and AUTHORS sections,Ingo Schwarze
and a few other wording and markup improvements while here; OK jmc@ ratchov@
2020-06-19We inherited the constant time CBC padding removal from BoringSSL, butTheo Buehler
missed a subsequent fix for an off-by-one in that code. If the first byte of a CBC padding of length 255 is mangled, we don't detect that. Adam Langley's BoringSSL commit 80842bdb44855dd7f1dde64a3fa9f4e782310fc7 Fixes the failing tlsfuzzer lucky 13 test case. ok beck inoguchi
2020-06-19mark the functions documented in des_read_pw(3) as deprecatedIngo Schwarze
and point to UI_UTIL_read_pw(3) instead; tb@ agrees with the general direction
2020-06-19document X509_get0_pubkey_bitstr(3),Ingo Schwarze
correct the description of X509_get_X509_PUBKEY(3), document error handling of the read accessors, and mention the relevant STANDARDS
2020-06-19document error handling of X509_PUBKEY_get0(3) and X509_PUBKEY_get(3)Ingo Schwarze
2020-06-19Merge documentation of X509_get0_serialNumber(3) from OpenSSL-1.1.1Ingo Schwarze
which is still under a free license. Wording tweaked by me.
2020-06-18uint8_t is a discrete, not a continuous type,Ingo Schwarze
and some other wording improvements with respect to types; OK ratchov@
2020-06-18Many of these functions have several arguments, and some argumentsIngo Schwarze
are very long (function pointers), such that a number of input lines in the SYNOPSIS do not fit into 80 columns. Consequently, consistently use .Fo/.Fa/.Fc rather than .Fn for better readability of the source code. Mechanical diff, no output change.
2020-06-18basic macro cleanup, and reword two phrases about closed intervalsIngo Schwarze
of integers for clarity and to read better; one of the issues (abuse of .Sm) was originally reported by jmc@; ok jmc@ ratchov@
2020-06-18Document sioctl_desc structure maxval attributeAlexandre Ratchov
2020-06-15Document EVP_read_pw_string_min(3)Theo Buehler
Add detailed information on the return values of all the functions in this page and remove the previous incorrect information. tweaks & ok schwarze
2020-06-15Document PEM_def_callback(3).Ingo Schwarze
Move pem_password_cb(3) to the file PEM_read(3) and rewrite its description from scratch for precision and conciseness. Plus some minor improvements in the vicinity. Tweaks and OK tb@.
2020-06-12add my Copyright and license, which i forgot when adding a significantIngo Schwarze
amount of text, the ERRORS section, in the previous commit
2020-06-12add a comment saying that name_cmp() is intentionally undocumented;Ingo Schwarze
tb@ agrees that it should not be part of the public API
2020-06-12document PEM_ASN1_read(3) and PEM_ASN1_read_bio(3);Ingo Schwarze
tweaks and OK tb@
2020-06-11wording tweaks from ross l richardson and tb;Jason McIntyre
ok tb
2020-06-10document PKCS7_get_signer_info(3)Ingo Schwarze
2020-06-10describe six more PKCS7 attribute functionsIngo Schwarze
2020-06-09The check_includes step is incorrect dependency management model forTheo de Raadt
how our tree gets built. If this was done in all the libraries (imagine sys/dev), it would disrupt the development process hugely. So it should not be done here either. use 'make includes' by hand instead.
2020-06-07In the libc resolver function asr_run(), clear the result buffer everytime,Theo de Raadt
because there are callers who were inspecting unrelated fields. discussion with eric, otto, solution from semarie this is errata 6.6/031_asr and 6.7/009_asr
2020-06-06Implement a rolling hash of the ClientHello message, Enforce RFC 8446Bob Beck
section 4.1.2 to ensure subsequent ClientHello messages after a HelloRetryRequest messages must be unchanged from the initial ClientHello. ok tb@ jsing@
2020-06-05Remove redundant codedenis
Reported by Prof. Dr. Steffen Wendzel <wendzel @ hs-worms . de>, thanks! OK martijn@ sthen@
2020-06-05Add a custom copy handler for AES key wrapTheo Buehler
This is necessary because ctx->cipher_data is an EVP_AES_WRAP_CTX containing a pointer to ctx->iv. EVP_CIPHER_CTX_copy() uses memcpy to copy cipher_data to the target struct. The result is that the copy contains a pointer to the wrong struct, which then leads to a use-after-free. The custom copy handler fixes things up to avoid that. Issue reported by Guido Vranken ok beck inoguchi jsing
2020-06-05Use IANA allocated GOST ClientCertificateTypes.Joel Sing
IANA has allocated numbers for GOST ClientCertificateType. Use them in addition to private values (left in place for compatibility). Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux ok inoguchi@ tb@
2020-06-05Stop sending GOST R 34.10-94 as a CertificateType.Joel Sing
GOST R 34.10-94 is an obsolete certificate type, unsupported by LibreSSL and by the rest of current software, so there is no point in sending in the CertificateTypes. Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux ok inoguchi@ tb@
2020-06-05Handle GOST in ssl_cert_dup().Joel Sing
Add missing case entry for SSL_PKEY_GOST01. Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux ok inoguchi@ tb@
2020-06-05Enable GOST_SIG_FORMAT_RS_LE when verifying certificate signatures.Joel Sing
GOST cipher suites requires that CertVerify signatures be generated in a special way (see ssl3_send_client_kex_gost(), ssl3_get_cert_verify()). However, the GOST_SIG_FORMAT_RS_LE flag was not passed in case of TLS 1.2 connections (because they use different code path). Set this flag on GOST PKEYs. Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux ok inoguchi@ tb@
2020-06-05Allow GOST R 34.11-2012 in PBE/PBKDF2/PKCS#5.Joel Sing
Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux ok inoguchi@ tb@
2020-06-05Add OIDs for HMAC using Streebog (GOST R 34.11-2012) hash function.Joel Sing
Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux ok inoguchi@ tb@
2020-06-05Add a few more errors to help debugging.Joel Sing
Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux. ok inoguchi@ tb@
2020-06-05Add support for additional GOST curves.Joel Sing
These GOST curves are defined in RFC 7836 and draft-deremin-rfc4491-bis. Add aliases for 256-bit GOST curves (see draft-smyshlyaev-tls12-gost-suites) and rename the 512-bit curve ids to follow names defined in tc26 OID registry. Diff from Dmitry Baryshkov <dbaryshkov@gmail.com> Sponsored by ROSA Linux. ok inoguchi@
2020-06-05Remove remaining error *_str_functs[]Joel Sing
A number of years ago we dropped the concept of having function names in errors, since it is not that useful and very quickly gets out of sync when refactoring. It would seem that some new ones got imported and some missed the last clean up. ok tb@ beck@ "kill it with fire"
2020-06-05Apply some style(9).Joel Sing
2020-06-05One error file per directory is plenty.Joel Sing
2020-06-05HID parser could overflow if a malicious device (potentially USB) providedJonathan Gray
too many PUSH. report from Andy Nguyen @ google. fix by jcs from kernel hid.c rev 1.3
2020-06-04When X509_ATTRIBUTE_create() receives an invalid NID (e.g., -1), returnIngo Schwarze
failure rather than silently constructing a broken X509_ATTRIBUTE object that might cause NULL pointer accesses later on. This matters because X509_ATTRIBUTE_create() is used by documented API functions like PKCS7_add_attribute(3) and the NID comes straight from the user. This fixes a bug found while working on documentation. OK tb@ and "thanks" bluhm@
2020-06-04minor polishing:Ingo Schwarze
* below SEE ALSO, point to the most similar function that is not deprecated * add a comment saying why ERR_load_ERR_strings() is intentionally undocumented * update the comment specifying the merge status
2020-06-04Align tls13_server_select_certificate() withTheo Buehler
tls13_client_select_certificate(). ok inoguchi
2020-06-04Improve client certificate selection for TLSv1.3Theo Buehler
This allows clients to use EC certificates. ok inoguchi, jsing
2020-06-04mention that TLS_method(3) also supports TLSv1.3;Ingo Schwarze
tb@ OKed this part of a larger diff from inoguchi@
2020-06-04Collapse the x509v3 directory into x509.Joel Sing
This avoids the need to grep across directories to find functions and prepares for further rototilling and chainsawing. Discussed with tb@ (who also tested the release build)
2020-06-04new manual page PKCS7_add_attribute(3);Ingo Schwarze
tweaks and OK tb@
2020-06-03Properly document PKCS7_final(3), which was already mentionedIngo Schwarze
in passing in some other manual pages.
2020-06-02Remove const modifier in return type of tls13_handshake_active_state()Theo Buehler
which make no sense as pointed out by gcc on sparc64. ok jsing
2020-06-02distracting whitespaceTheo Buehler