summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2014-04-20theo found a file we don't seem to need, but just in case, i will pasteTed Unangst
the contents below: #!/usr/local/bin/perl # x86 assember
2014-04-20Restore beck's rev 1.9: snprintf() was reviewedPhilip Guenther
2014-04-20KNF.Joel Sing
2014-04-20Restore beck's rev 1.3: snprintf() was reviewedPhilip Guenther
2014-04-20More KNF.Joel Sing
2014-04-20KNF.Joel Sing
2014-04-20KNF.Joel Sing
2014-04-20KNF.Joel Sing
2014-04-20More KNF.Joel Sing
2014-04-20More KNF.Joel Sing
2014-04-20gettimeofday() is portable enough and does not need a wrapperTheo de Raadt
2014-04-20calloc() rather than malloc+memsetTheo de Raadt
2014-04-20Fix indentation, adding braces and combining a nested if to reduce depthPhilip Guenther
2014-04-20KNF.Joel Sing
2014-04-20KNF.Joel Sing
2014-04-20Chop off more SSLv2 tentacles and start fixing and noting y2038 issues.Philip Guenther
APIs that pass times as longs will have to change at some point... Bump major on both libcrypto and libssl. ok tedu@
2014-04-20return after error instead of plowing ahead. noticed by mancha1 at zohoTed Unangst
2014-04-20Use calloc(a,b) instead of malloc(a*b) + memset(a*b). I don't know ifTheo de Raadt
this instance is integer-overflowable, but we cannot keep hand-auditing every instance (or apathetically ignoring these issues) when the simple calloc idiom is better in the presence of a good calloc(). It is simply unfeasible to always enter correct range checks before the aggregate size calculation, just go find some 4000 lines of code, REPAIR THEM ALL, then come back and tell me I am wrong. This only works on systems where calloc() does the integer overflow check, but if your system doesn't do this, you need to ask your vendor WHY THEY ARE 10 YEARS BEHIND IN BEST PRACTICE? This is the kind of problem that needs to be solved at the right layer. malloc integer-overflow was implicated in the 2002 OpenSSH hole. OpenSSH and much other code is now written to use calloc(), for instance OpenSSH has 103 calls to it. We feel safer with our use of calloc(). It is a natural approach for us to use calloc(). How safe do you feel on systems which lack that range check in their calloc()? Good writeup from 2006: http://undeadly.org/cgi?action=article&sid=20060330071917
2014-04-20KNF.Joel Sing
2014-04-20reset imprint to NULL to avoid double free. from mancha1 at zohoTed Unangst
2014-04-19release buffers fix was lost in merge. put it back.Ted Unangst
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19another attempt at fixing stale x509 data. since we don't know where theTed Unangst
initial storage came from, we can't free it. just memset in the sequence case. probably ok beck
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19KNF.Joel Sing
2014-04-19KNF.Joel Sing
2014-04-19can't actually do this. cause unknown.Ted Unangst
2014-04-19KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19Lacking a proof that--for this implementation--exposure of MontgomeryPhilip Guenther
multiplication or RSA blinding parameters doesn't permit retroactive timing analysis of the secrets, we'll do the stupidly cheap thing and cleanse them before freeing them. ok deraadt@
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19We'll interpret a (void) cast on snprintf() to mean it's been verified thatPhilip Guenther
truncation is either desirable, not an issue, or is detected and handled later ok deraadt@
2014-04-19egd is goneTheo de Raadt
2014-04-19The internal ssl2_* functions and variables are gonePhilip Guenther
2014-04-19More KNF.Joel Sing
2014-04-19More KNF and style consistency tweaksPhilip Guenther
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing
2014-04-19use intrinsic strlcpy and strlcat everywhere so we only have one set ofBob Beck
funcitons to check for incorrect use. keep BUF_strlcpy and BUF_strlcat for API comptibility only. ok tedu@
2014-04-18OPENSSL_gmtime() is really just gmtime_r(); ok guentherTheo de Raadt
2014-04-18spacingTed Unangst
2014-04-18tone down some XXXXX to not appear in grepTed Unangst
2014-04-18XXXXXXXXXXXXXXXX -> XXXTed Unangst
XXXXXXXXXXXXXXXXXXXXXXX -> XXXX
2014-04-18unifdef NO_SOCKTed Unangst