| Age | Commit message (Collapse) | Author |
|---|
|
|
|
<bret dot lambert at gmail.com>; ok millert@ deraadt@
|
|
this can potentially block indefinitely. Instead just
protect against fd state transitions and perform
the _thread_sys_shutdown(). Fixes deadlock reported by
Tero Koskinen <tero.koskinen at iki.fi>. okay kettenis@
|
|
based on -r1.22 from freebsd (i386 version anyway),
submitted by andreas fuchs,
improved by ru@freebsd,
then again by myself and mickey
ok mickey
|
|
|
|
|
|
|
|
a string, being careful to deal with 0-length strings. Help and input
from jmc, ok deraadt
|
|
|
|
OK and input from deraadt, jmc, millert.
|
|
Document what "msgsz" argument really denotes;
from brian candler (freebsd pr #101145)
Don't say that "msgsz" can be less than 0, it cannot
as it's unsigned (POSIX has the same bug);
from ru@freebsd
ok millert deraadt
|
|
from simon barner (freebsd pr #57153);
ok millert deraadt
|
|
|
|
|
|
|
|
own brains out, and then takes lint down with it. To be investigated...
|
|
ok miod@ drahn@
|
|
not to any process that is a descendant of the current process.
from ryan younce (freebsd pr #58710);
confirmed by otto and ok
|
|
kick started by netbsd pr 19603 from kevin p. neal.
rillig@netbsd seems to have adapted that, and i have in turn
adapted it again;
ok otto
|
|
|
|
|
|
NetBSD.
|
|
|
|
the code easier to read.
OK deraadt
|
|
|
|
vague like that) REQUIRE a major crank. Yet it was not done for
getcwd. Now a lot of people are going to get screwed
|
|
|
|
kill some trailing whitespace;
|
|
and S_ISSOCK() macros.
OK deraadt@, OK and help from jmc@.
|
|
Log Message:
Switch from 4-clause to 2-clause BSD license.
Ok dillo@, board@.
|
|
http://www.openssl.org/news/secadv_20060928.txt for more
|
|
ok jmc@
|
|
When a fd enters the closing state prevent any threads from
polling the fd and reschedule the thread with the closing_fd
flag set. This fixes a class of deadlocks where a thread is
blocked waiting for data (that may never arrive) and a later
thread calls close() or dup2() on the fd. okay brad@
|
|
_thread_fd_table_init()'s return value and blow it away. fixes
firefox plugin problem noticed by jolan@
|
|
fstypesnames[], but that entry is NULL. The last valid file system
name is at fstypesnames[FSMAXTYPES-1].
Encountered and diagnosed by pedro@.
ok pedro@ deraadt@
|
|
detctecion of underflow where it would otherwise not happen for FPUs
that have a larger register size than sizeof double (i386, m68k). ok
deraadt@ weingart@ kettenis@
|
|
stacks; report by Antoine Jacoutot; ok kurt@
|
|
from Matthew R. Dempsky <mrd at alkemio dot org>
ok deraadt
|
|
floppies and cd's were removable, displaying that fact in disklabel
output was unlikely to help. And the display in disklabel was the only
use of D_REMOVABLE in the tree.
ok marco@
|
|
|
|
applications that install their own thread stack red-zones with mprotect
PROT_NONE from entering the malloc pool when the pages are freed.
- round up requested thread stack size to closest page boundary to
simplify the red-zone calculations.
okay brad@
|
|
Adjust design of file descriptor table to eliminate races
with both opening and closing of file descriptor entries
and eliminates one class of deadlocks. One nice side effect
of this change in design should be better performance for
applications that open and close many file descriptors due
to reduced fd_table_lock contention and fd entry reuse.
- Add entry states to manage use of entry and eliminate
some closing races. fd entries are not deallocated upon
close() now.
- Call _thread_fd_table_init with one of five discreet
modes to properly initialize an entry and manage the
state transition to open.
- When closing an entry hold the entry spinlock locked
across the state transition and the _thread_sys_close
call to close another race.
- Introduce a new lock type FD_RDWR_CLOSE that transitions
either a closed entry or an open entry into closing state
and then waits for a RDWR lock so that the lock queue can
unwind normally. All subsequent fd lock attempts for that
entry are rejected with EBADF until the fd is fully closed,
or reopened by dup2(). Once a thread holds the FD_RDWR_LOCK
it is safe to close() it or dup2() on it.
- When a thread creates a new fd there is a window of time
when another thread could attempt to use the fd before the
creating thread has initialized the entry for it. This can
result in improper status_flags for the entry, so record
the entries init mode, detect when this has happened and
correct the status_flags when needed.
reviewed by marc@ & brad@, tested by several, okay brad@
|
|
cool and recognizes __dead, and because shorter examples are clearer.
OK otto@.
|
|
|
|
s_lrint.c and s_lrintf.c, and add i387-specific assembler versions.
ok deraadt@, otto@
|
|
have multiple bits set, which lead to surprising results. Spotted by
Paul Stoeber. ok djm@
|
|
not being used in the tree for anything obviously useful. Get it done
early so we can find if there are non-obvious uses out there.
ok deraadt@ beck@
|
|
|
|
OK otto@ and jaredy@.
|
|
File status flags should be shared for dup'ed file descriptors.
However fd_table_entry's should not be shared for dup'ed file
descriptors so they can be independently be closed without
interfering with dup'ed fd's.
- split out file status flags into its own structure
fs_flags to manage sharing of status flags between
dup'ed file descriptors.
- when duplicating a fd, initialize a new fd_table_entry
for the new fd, but share the status flags via status_flags.
- consolidate the code that sets the underlying system fd
to be non-blocking to a new function _thread_fs_flags_init()
- consolidate the code that sets the underlying system
fd back to blocking into a new function _thread_fs_flags_replace()
This change is needed as a prerequisite to the coming race
and deadlock corrections. okay marc@
|
