summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2014-06-27Fix mmap() flag usage: explicitly specify MAP_PRIVATE and drop uselessMatthew Dempsky
MAP_FILE and MAP_HASSEMAPHORE flags. Discussed with deraadt, tedu, and kettenis
2014-06-27zap unneccessary punctuation;Jason McIntyre
2014-06-27When building a BN on the stack in BN_div(), make sure to initialize all itsMiod Vallat
fields (i.e. the flags field) before using it. This is currently harmless, but might not be if we end up invoking other BN functions checking for constant-time processing requirement in the future.
2014-06-27re-init and init code paths are now more shared, so the getpid()-basedTheo de Raadt
portable code path must handle that; with brent cook
2014-06-27Cleanup ioctl.2 slightly:Matthew Dempsky
- Markup ioctl argument types with Fa - Be clearer that ioctl arguments are pointers to ints. Similar changes to follow for manual pages that describe device-specific ioctl commands. Discussed with jmc and schwarze.
2014-06-27OpenBSD supports mmap() on block special files too.Matthew Dempsky
2014-06-27Split out mmap's compatibility flags into a separate section, so usersMatthew Dempsky
aren't misled into thinking they're useful on OpenBSD.
2014-06-27Revise wording to reflect that callers should always specify (exactly)Matthew Dempsky
one of MAP_PRIVATE or MAP_SHARED, as required by POSIX. However, also caveat that currently OpenBSD doesn't strictly enforce this behavior.
2014-06-27extra evil spaces snuck in over the last whileTheo de Raadt
2014-06-27Move to a smaller rbytes buffer and skip a random part. Not toOtto Moerbeek
improve the random stream itself (it doesn't), but to introduce noise in the arc4random calling pattern. Thanks to matthew@ who pointed out bias in a previous diff, ok deraadt@ matthew@
2014-06-27save_errno botch; spotted by miodTheo de Raadt
2014-06-27hand-KNF macro the do { } while loopsTheo de Raadt
2014-06-27hand-KNF the remaining bitsTheo de Raadt
2014-06-27Remove M_ASN1_New* macros which are only used in X509_PKEY_new() are obfuscateMiod Vallat
it to hide memory leaks in the error paths, and fix aforementioned memory leaks. ok jsing@ logan@ deraadt@
2014-06-26Add back an #ifndef MAP_INHERIT_ZERO chunk to support the old getpid()Theo de Raadt
mechanism, to aid in portability to other systems as requested. ok matthew
2014-06-26Document that mmap() confirms to POSIX 2008, except that we generateMatthew Dempsky
SIGSEGV instead of SIGBUS for page references beyond the end of a mapped object.
2014-06-26save errno in ERR_put_error(), so that SYSerr doesn't have any accidentalTheo de Raadt
cases where errno can be trashed. ok jsing
2014-06-26fix HD() misuse; from brent cookTheo de Raadt
2014-06-26Convert several calloc calls to reallocarray. These calloc calls wereLawrence Teo
originally malloc(n * m) calls (without memset/bzero) in the past. ok deraadt@ tedu@
2014-06-25AT_BASE returns us the *address* of the start of ld.so, soBob Beck
use the address, not what it points to (which is always the same) ok deraadt@
2014-06-25get the page of data at AT_SYSINFO_EHDRBob Beck
ok deraadt@
2014-06-25comment fixes from theoBob Beck
2014-06-25Possibly obtain a little bit of entropy from addresses returnedBob Beck
by getauxval if we have it. ok deraadt@
2014-06-25O_NOFOLLOW would be very nice to have here if the version of linuxBob Beck
we are running supports it. from enh@google.com
2014-06-25document why we explicit_bzeroTheo de Raadt
2014-06-24Unifdef -UNO_SYS_TYPES_HMiod Vallat
2014-06-24Remove previously commented out wrong code, as well as the comment saying thisMiod Vallat
is incorrect code.
2014-06-24Remove ancient workaround for previous century's compilers in the declarationMiod Vallat
of CRYPTO_EX_DATA; riding upon the libcrypto major bump.
2014-06-24Remove BIO_f_reliable(), guilty of playing with EVP_MD_CTX internals itMiod Vallat
should not know anything about. Verified not to be used in ports; riding upon the recent libcrypto major bump.
2014-06-24Crank libcrypto major since my previous commit changed the size of theJoel Sing
ChaCha context. Other changes will also ride this crank.
2014-06-24If a chacha operation does not consume all of the generated key stream,Joel Sing
ensure that we save it and consume it on subsequent writes. Otherwise we end up discarding part of the key stream and instead generate a new block at the start of the next write. This was only an issue for callers that did multiple writes that are not multiples of 64 bytes - in particular, the ChaCha20Poly1305 usage does not hit this problem since it performs encryption in a single-shot. For the same reason, this is also a non-issue when openssl(1) is used to encrypt with ChaCha. Issue identified by insane coder; reported to bugs@ by Joseph M. Schwartz. ok beck@
2014-06-24Some KNF.Joel Sing
2014-06-24Replace 48 lines of code with a single inet_pton() call. The previousJoel Sing
handrolled version could not even make use of sscanf(), since that would not work with a certain antiquated compiler. It is worth noting that there is a tiny change in behaviour - previously calling BIO_get_host_ip() with something that looked like it might be a valid IP address (for example, "1." or even ".") would result in it returning failure rather than trying a BIO_gethostbyname() - now we'll always try a BIO_gethostbyname() if it was not a valid IPv4 address. ok beck@ miod@ deraadt@
2014-06-24Actually make BIO_set_tcp_ndelay() work - TCP_NODELAY will not magicallyJoel Sing
appear by itself. ok beck@ miod@
2014-06-24Fix memory leak.Loganaden Velvindron
Thanks to Brenk Cook. OK from miod@
2014-06-23Since this is a library, place issetugid() before every getenv()Theo de Raadt
ok miod
2014-06-23unbreak build of getentropy_sysctl - we need linux/sysctl.h, andBob Beck
RANDOM_UUID is an enum member.
2014-06-23unbreak - main needs to be extern in here somewhere.Bob Beck
2014-06-21repair indentation for an inner loop; shorten some macros and variableTheo de Raadt
names to shorten line lengths ok beck
2014-06-21loosen the spec for timingsafe functions slightly, so as to notTed Unangst
artificially constrain alternative implementations. ok deraadt
2014-06-21hash in correct pointerTheo de Raadt
2014-06-20KNFBob Beck
2014-06-20indentTheo de Raadt
2014-06-20rearrange so that the main function with the important comments is at the topOtto Moerbeek
ok deraadt@ beck@
2014-06-15occured -> occurred;Jason McIntyre
2014-06-14Change return value of getentropy() to int 0 for success. MaximumTheo de Raadt
buffersize is enforced strictly, this supplies sufficient entropy payload to act as seed material. Discourage general use of this API, but lock down this function name as the go-to for userland PRNG seeding. Improve documentation. ok miod matthew
2014-06-13typo; Piotr SikoraTheo de Raadt
2014-06-23Remove unintended statement from my copyright blockPhilip Guenther
2014-06-22KNF, particularly wrapped lines of calls to PEM_read_bio_FOO() andPhilip Guenther
multiline comments ok jsing@
2014-06-22BIO_sock_init() no longer does anything, so stop calling it.Joel Sing