summaryrefslogtreecommitdiff
path: root/libexec/ftpd
AgeCommit message (Collapse)Author
2015-03-17Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@Todd C. Miller
2015-03-15tzfile.h is an internal header that should never have been installed.Todd C. Miller
What's worse, the tzfile.h that gets installed is over 20 years old and doesn't match the real tzfile.h in libc/time. This makes the tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE define has been moved to time.h temporarily until its usage is replaced by 1900 in the tree. Actual removal of tzfile.h is pending a ports build. Based on a diff from deraadt@
2015-02-06SIZE_MAX is standard, we should be using it in preference to theTodd C. Miller
obsolete SIZE_T_MAX. OK miod@ beck@
2015-01-19CMASK went out of scope with the recent <sys/param.h> removal. But ohTheo de Raadt
golly gee, ftpd can handle that itself due to the glorious old practice of #ifndef #define. Remove that junk. ok guenther
2015-01-16Replace <sys/param.h> with <limits.h> and other less dirty headers whereTheo de Raadt
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
2015-01-15remove .Tn; from Jan Stary <hans at stare dot cz>Ingo Schwarze
2014-10-25Remove unnecessary netinet/in_systm.h include.Lawrence Teo
ok millert@
2014-08-25Delete secret or secret-derived data with explicit_bzero.Doug Hogan
concept ok deraadt@ diff looks ok tedu@
2014-03-24remove tcpwrappers support. ok deraadtTed Unangst
2014-03-17args! fix argstr. from LEVAI Daniel.Stuart Henderson
2014-03-17tweak previous;Jason McIntyre
2014-03-17typo, spotted by okan@Stuart Henderson
2014-03-17Add an option to disallow ftp access to accounts with uid below a certainStuart Henderson
number (idea borrowed from pure-ftpd). Enabled by default with minimum uid 1000 to prevent access to admin accounts. tweak/OK millert@, OK deraadt@, gsoares@ and aja@ like it too.
2014-02-08Fix REST (restart transfer) for offsets large than 2GB. OK okan@Todd C. Miller
2014-01-08If the file size is zero, there's nothing to transmit so avoid spammingJeremie Courreges-Anglas
syslog with mmap failures. Noticed by and ok henning@, "looks right" deraadt@
2013-11-27unsigned char for ctypeTheo de Raadt
ok okan kettenis
2013-11-12repair the last prototype by bringing in monitor.hTheo de Raadt
2013-08-22Correct format string mismatches turned up by -Wformat=2Philip Guenther
suggestions and ok millert@
2013-07-26Make sure tmpline[] is always NUL terminated, to avoid possiblePhilip Guenther
read-beyond-end in get_line(). Analysis and patch by Maxime Villard (rustyBSD (at) gmx.fr) ok millert@ deraadt@
2012-12-04remove some unnecessary sys/param.h inclusionsTheo de Raadt
2012-09-27last stage of rfc changes, using consistent Rs/Re blocks, and moving theJason McIntyre
references into a STANDARDS section;
2012-08-04MDTM and SIZE have been in RFC 3659 for over five years. Also, mention bothPascal Stumpf
RFCs in "SEE ALSO". ok jmc@
2012-04-04Return an error much earlier if recvmsg failsTheo de Raadt
2012-03-04In preparation for getline and getdelim additions to libc, rename getline()Federico G. Schwindt
occurrences to get_line(). Based on a diff from Jan Klemkow <j-dot-klemkow-at-wemelug-dot-de> to tech.
2011-12-15s,/var/run/wtmp,/var/log/wtmp and add it to FILES.Antoine Jacoutot
from Steffen Daode Nurpmeso with a tweak from jmc@ ok jmc@
2011-12-14Add a new '-W' option to prevent saving login records to /var/run/wtmp.Antoine Jacoutot
This can become pretty handy on busy anonymous servers to avoid filling up /var with unused wtmp records. Note that 'U' and 'W' are mutually exclusive. ok sthen@ millert@
2011-02-09Set SO_KEEPALIVE on sockets. OK miod@. Also tested by landry@Todd C. Miller
"Makes sense" markus@ and "i don't see a reason not to" henning@
2010-08-30Add missing network service name from /var/log/ftpd entries.lum
ok and suggestion from jmc@ ok tobias@
2010-08-27In revision 1.14 of ftpd.c the ident variable was removed from its only ↵lum
meaningful usage when a snprintf call was removed, rendering ident useless. Time to remove remaining code. ok tobias@
2010-08-01Properly reset states when a login phase is interrupted by another one.Tobias Stoeckmann
Prevents ftpd from letting regular users logging in during anonymous-only mode (-A). ok millert, ray
2010-07-30Don't set "success" flags before error checks.Ray Lai
Add check for login_getclass() failure, pointed out by tobias. OK tobias
2010-06-18Prevent a segmentation fault on ftpd_popen error (memory, file descriptor,Tobias Stoeckmann
pipe ...) during status command. ok millert
2010-06-13Adjust FTP reply codes (in error conditions) to conform to RFC 959.Tobias Stoeckmann
ok millert, schwarze
2010-03-08Check that gl_pathc is bigger than zero before derefencing gl_pathv. WhileMark Kettenis
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero even if we specify GLOB_NOMAGIC. ok deraadt@
2009-10-28rcsid[] and sccsid[] and copyright[] are essentially unmaintained (andTheo de Raadt
unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms
2009-06-04...and now try again with a commit from the right tree. doh!Stuart Henderson
ftp uses its own ugly "sockunion" to hold addresses, but with CMD_BIND the monitor treats it as if it were a sockaddr. this is fine for v4 but fails for v6, so active connections break. problem reported and diff tested by Maurice Janssen. looks sensible to deraadt@.
2009-06-04ftp uses its own ugly "sockunion" to hold addresses, but with CMD_BINDStuart Henderson
the monitor treats it as if it were a sockaddr. this is fine for v4 but fails for v6, so active connections break. problem reported and diff tested by Maurice Janssen. looks sensible to deraadt@.
2009-04-20When receiving a new connection, log the remote IP numberIngo Schwarze
in addition to the remote hostname. Feature requested by Mark Bucciarelli mkbucc at gmail dot com on misc@. "seems OK" millert@
2008-09-30Always say "User %s access denied", in all cases, to avoid some stupidTheo de Raadt
spinny things which parse those messages. Do not close the connection as requested by Josh Grosse, since a 530 is not supposed to do that. ok millert
2008-09-13Fix minor bug in the previous commit, which could hang theMoritz Jodeit
current session, when the last character of an overly long line was a newline character. Additionally reply with 500 "Command too long" for commands, which are too large. Issue found and proposed fix by Luke Mewburn <lukem@NetBSD.org>. ok millert@
2008-09-12Don't split large commands into multiple commands on a 512-byteMoritz Jodeit
boundary but just fail on them. This prevents CSRF-like attacks, when a web browser is used to access an ftp server. Reported by Maksymilian Arciemowicz <cxib@securityreason.com>. ok millert@ martynas@
2008-06-30Include file order must be "monitor.h" before "extern.h" otherwise enumAnders Magnusson
auth_ret is referenced before it is declared, which is not allowed by C99. Ok krw@, millert@, gilles@
2008-04-13Use arc4random_buf() when requesting more than a single word of outputDamien Miller
Use arc4random_uniform() when the desired random number upper bound is not a power of two ok deraadt@ millert@
2008-03-24msg_controllen has to be CMSG_SPACE so that the kernel can account forTheo de Raadt
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This works now that kernel fd passing has been fixed to accept a bit of sloppiness because of this ABI repair. lots of discussion with kettenis
2008-03-15Repair the simple cases for msg_controllen where it should just beTheo de Raadt
CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because of alignment; ok kettenis hshoexer
2008-03-13Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due toTheo de Raadt
an extensive discussion with otto, kettenis, millert, and hshoexer
2007-09-02use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsgTheo de Raadt
2007-07-31From Gilles Chehade:Ray Lai
- Use strtonum instead of atoi. - Improve strtol error checking. - Change strchr calls to strcspn and eliminating some unused variables as a result. OK moritz
2007-07-27Fix potential memory leak, when snprintf(3) returns an empty buffer.Moritz Jodeit
OK ray@
2007-06-21Adjust spacing, combine malloc + strlcpy + strlcat into a singleRay Lai
asprintf call. OK moritz
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-03 10:21:12 +0000