Age | Commit message (Collapse) | Author | |
---|---|---|---|
2007-11-12 | dont spew debug output when the SIOCGIFMEDIA ioctl errors with ENOTTY. | David Gwynne | |
ok krw@ henning@ | |||
2007-10-16 | sync the synopsis and usage of commands | Igor Sobrado | |
ok jmc@ | |||
2007-10-16 | "script" does not belong in the lease declaration section; | Jason McIntyre | |
from Vincent GROSS ok henning | |||
2007-09-02 | use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg | Theo de Raadt | |
2007-08-14 | make default_lease_time a #define; ok krw@ henning@ | Kevin Steves | |
2007-08-11 | Kill a couple of 'echo' statements that can never produce visible | Kenneth R Westerback | |
output. i.e. not visible on the screen, nor in any log. If nothing else, makes dhclient-script smaller for install media. 'yesh kill' (sic) henning@ | |||
2007-07-18 | eliminate duplicate code to open lease file and just open at | Kevin Steves | |
startup; ok krw@ henning@ | |||
2007-06-02 | safer snprintf construct with more paranoid length calculation | Peter Valchev | |
ok millert | |||
2007-05-31 | fix a funny memory miscalculation bug in options parsing | Peter Valchev | |
ok henning otto theo | |||
2007-05-31 | convert to new .Dd format; | Jason McIntyre | |
2007-03-02 | caret missing, From: "Matthew R. Dempsky" <mrd@alkemio.org> | Henning Brauer | |
2007-03-02 | and the second use of the spaces array might overflow too, in another | Henning Brauer | |
way... | |||
2007-03-02 | If a syntax error is found past 80 columns, parse_warn accessed memory | Henning Brauer | |
outside of the `spaces' array when trying to print the caret marker found by "Matthew R. Dempsky" <mrd@alkemio.org>, fix inspired by a.velichinsky@gmail.com. discussed with krw | |||
2007-02-25 | No point in using zero'd fields in the parsed options. Use the options | Kenneth R Westerback | |
in the lease, whence the parsed info was moved. Fixes "Bogus servername" messages when processing an offer and stops bogus filename info from being stored in the lease. Found while testing a Tucson hotel's dhcp service. ok @stevesk "looks good" henning@. | |||
2007-02-25 | remove unused/dangling prototypes and comment reference; | Kevin Steves | |
from Mark Lumsden | |||
2007-02-25 | no need to quote/escape here; ok krw@ | Kevin Steves | |
2007-02-15 | make read connection closed message a debug(); ok henning@ | Kevin Steves | |
2007-02-14 | spacing and a typo that fell out of the read | Theo de Raadt | |
2007-02-14 | use errwarn functions vs. syslog(); ok henning@ krw@ | Kevin Steves | |
2007-02-13 | move includes only needed in dhclient.c; ok henning@ | Kevin Steves | |
2007-02-13 | error check socket() return; ok henning@ | Kevin Steves | |
2007-02-01 | Don't count ethernet as overhead for UDP packet constuction. Gives | Kenneth R Westerback | |
14 more bytes of option space! A change ISC made a long time ago. ok stevesk@ (DHCP) canacar@ (bpf) | |||
2007-01-29 | Don't malloc memory to store option data in leases, just appropriate | Kenneth R Westerback | |
the malloc'd memory from the parsed option buffer since it would be thrown away after the copy anyway. 'looks sane' millert@ | |||
2007-01-27 | We only poll on the bpf fd and the routing socket fd. No need for | Kenneth R Westerback | |
complex list code to keep track. So nuke it. Also eliminate unnecessary variable ('dead') that means 'rfdesc is closed'. Just set rfdesc to -1 when it is closed and use that. As suggested by millert@ and claudio@, don't bother setting revents members to zero since poll() does that. Np functional change, just less code. 'looks good' claudio@ 'I like where this is going' henning@ | |||
2007-01-25 | Cleanup some more code. Eliminate dhcp(), bootp(), parse_options() by | Kenneth R Westerback | |
moving the minimal code into do_packet(). Eliminate repeated code for checking the client hardware address and the reject list by putting those checks into do_packet as well. No functional change, just much easier to read. ok stevesk@ | |||
2007-01-16 | More cleanup. Eliminate 'struct packet' by cleverly passing as | Kenneth R Westerback | |
parameters just those things actually needed and using existing structs and information. No functional change. ok stevesk@ | |||
2007-01-14 | Don't treat any packet with an invalid option buffer or an invalid | Kenneth R Westerback | |
message type option of 0 as a BOOTP offer. Don't process any option buffer after one is found to be corrupt. Don't process overflow buffers in a BOOTP packet. At least try to accept DHCP offers even if a bad options buffer is encountered. Brings code more into line with current ISC dhclient. ok stevesk@ | |||
2007-01-11 | Since bootp_packet_handler is always set to do_packet before we | Kenneth R Westerback | |
process any packets, eliminate that abstraction and just call do_packet directly. No functional change. ok stevesk | |||
2007-01-11 | remove unused #define DHCP_MIN_LEN | Kevin Steves | |
2007-01-11 | Reject all packets with an option claiming to extend past the end of | Kenneth R Westerback | |
an option buffer. No longer accept the 6th such packet. From ISC. ok ckuethe@ stevesk@ | |||
2007-01-08 | Don't leak strings. | Kenneth R Westerback | |
ok miod@ | |||
2007-01-08 | Initialize incoming packet buffer with DHO_END (0xff) rather than | Kenneth R Westerback | |
DHO_PAD (0x00) so that option scanning will terminate on hitting initialized data rather than scanning and ignoring trailing DHO_PAD characters. Suggested by & ok stevesk | |||
2007-01-06 | Fix options parsing. Last commit lost the proper length of the | Kenneth R Westerback | |
incoming packet. But since we bzero() the packet buffer before copying the incoming data into it, and the options are at the end, and we use a fixed sized buffer, and 0's are ignored as pad options, and proper option lists end with 0xff, it's simplier to always try to scan the whole buffer. Problem found by, and patch tested by kettenis@. | |||
2007-01-04 | Eliminate the 'len' parameter from send_packet() since it always | Kenneth R Westerback | |
contains the global value client->packet_length. Use client->packet_length. No functional change. Suggested by stevesk@. | |||
2007-01-04 | Another round of cleanup. There is only one instance of struct | Kenneth R Westerback | |
dhcp_packet and it is contained in the global *client. So don't pass around pointers to a struct that contains a pointer to the dhcp_packet instance. Just use the global client->packet. Eliminate unused struct packet members and parameter lists accordingly. No functional change. Suggestions by stevesk@. ok stevesk@ | |||
2007-01-04 | <sys/un.h> not needed | Kevin Steves | |
2006-12-28 | please lint | Theo de Raadt | |
2006-12-28 | parenthesis not needed here; consistent with usage in other areas. | Kevin Steves | |
no binary change. | |||
2006-12-28 | small knf (extra space, newline) | Kevin Steves | |
2006-12-28 | no extra "\n" in note(); ok krw@ henning@ | Kevin Steves | |
2006-12-27 | Since we only have the single global struct interface_info, we | Kenneth R Westerback | |
obviously have single global struct client_state and struct client_config nested inside interface_info and client_state respectively. Pull them out to their own global variables and eliminate a bunch (i.e. hundreds) of multi-level dereferences. Make it much nicer to read. No functional change. "makes sense" henning@ Testing stevesk@, ok stevesk@ | |||
2006-12-26 | Our dhclient only handles one interface. Simplify code by using the | Kenneth R Westerback | |
single, global, instance of 'struct interface_info' (ifi) rather than passing around pointers to it. "I agree" henning@ Testing moritz@ stevesk@, ok stevesk@ | |||
2006-12-26 | There must be no alias address set, so check ifi->client->alias | Moritz Jodeit | |
for NULL before dereferencing it. OK henning@ krw@ deraadt@ | |||
2006-12-22 | delete prototypes for functions that don't exist | Kevin Steves | |
2006-12-18 | remove statement for send parameter: "except that the client can | Kevin Steves | |
specify a dhcp-lease-time option other than the default requested lease time, which is two hours". we don't by default send a dhcp-lease-time option in request/discover. ok jmc@, henning@ 'if you are sure' | |||
2006-12-18 | this is clearer and consistent with other areas; ok henning@ | Kevin Steves | |
2006-12-17 | remove ASSERT_STATE() macro which is a NOOP, no binary change; ok henning@ | Kevin Steves | |
2006-12-17 | fix comment | Kevin Steves | |
2006-12-16 | make /sbin/dhclient-script consistent with other paths; ok henning@ | Kevin Steves | |
2006-12-15 | KNF | Kevin Steves | |