Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-11-08 | Add a type cast to force signed comparison. This fixes a loop | Visa Hankala | |
termination issue that can arise when parsing IP options. The bug was found by Hrvoje Popovski with ping -R. Fix tested by Hrvoje, OK millert@ | |||
2017-07-08 | Consistently use if ((option & F_FOO) && (option & F_BAR)) instead of | Florian Obser | |
if (option & F_FOO && option & F_BAR). Prompted by a reverse diff from Klemens Nanni. Both forms are equivalent due to operator precedence, I consider the later to be easier on the eyes. | |||
2017-07-08 | Consistently use if (option & F_FOO); from Klemens Nanni, thanks! | Florian Obser | |
2017-07-05 | remove useless (void)printf casts, diff from Klemens Nanni, massaged | Florian Obser | |
by me. | |||
2017-07-04 | calculate multiples of 4 smarter; from Klemens Nanni | Florian Obser | |
2017-07-04 | replace perror(3) with err(3); from Klemens Nanni | Florian Obser | |
2017-02-22 | Unbreak "ping6 -L" | Renato Westphal | |
$ ping6 -L ff02::1%em1 ping6: setsockopt IP6_MULTICAST_LOOP: Invalid argument Unfortunately we have this inconsistency in the sockets API where we need to pass an unsigned char for IP_MULTICAST_LOOP but we need an unsigned int for IPV6_MULTICAST_LOOP. While here, fix a typo in the error message. OK millert@ florian@ | |||
2016-10-26 | in florian;s last commit i urged him to change "twenty-four" to | Jason McIntyre | |
"twenty four", arguing, i think, that the internet is wrong; well seemingly i'm wrong, and you should hyphenate numbers when spelled out - who'd have thought it. apologies to florian and the diff submitter (and the internet); still, what i should have advised, and what i've done here, is use "24", which is much simpler, fits the surrounding text, and agrees with oed style advice; | |||
2016-10-26 | Due to 64 bit seconds + 64 bit nano seconds resolution and the | Florian Obser | |
addition of a MAC we need at least 24 bytes packet size these days to show timing information. Pointed out by Tamas Horvath, thanks! OK jmc | |||
2016-10-20 | Only drop to _ping user if invoked as root. If invoked as an | Florian Obser | |
unprivileged user just shed the setuid privs as previously. sthen@ pointed out that you cannot kill(2) your own ping. With this we rely on pledge(2) for unprivileged users. OK sthen@, deraadt@ is happy with the middle ground | |||
2016-09-28 | Always do the setgroups, setresgid and setresuid even if if the | Florian Obser | |
unprivileged user is not present instead of erroring out. This lets ping and traceroute work in restricted enviornments like the bgplg chroot. Problem reported by sthen@ input & prodding deraadt@ | |||
2016-09-26 | Drop privileges to newly added _ping user/group. | Florian Obser | |
It does not buy us much when called as a unpriv user. But if run as root we can now lose privileges. OK natano@, deraadt@ is happy | |||
2016-09-20 | whitespace | Theo de Raadt | |
2016-09-20 | various cleanup; ok florian | Jason McIntyre | |
2016-09-19 | Only allow standard dot notation for IPv4 addresses. | Florian Obser | |
We can get rid of inet_aton(3) and use the AF independent getaddrinfo(3). OK natano@, krw@, millert@, claudio@ | |||
2016-09-18 | unbreak IPv6 source selection | Florian Obser | |
2016-09-18 | simplify startup, since we know earlier which type of socket we need | Theo de Raadt | |
ok florian | |||
2016-09-18 | whitespace | Theo de Raadt | |
2016-09-18 | If running in verbose mode and no source address has been specified | Florian Obser | |
with -I find the kernel selected address and print it even for v4 addresses. OK phessler@, natano@, mpi@, claudio@, benno@, sthen@, millert@ | |||
2016-09-18 | Do not print 'ping6' in reporting output, just 'ping'. | Florian Obser | |
OK tom@, natano@, claudio@, sthen@, millert@ | |||
2016-09-18 | minor tweaks; | Jason McIntyre | |
2016-09-17 | backwards if(v6flag); pointed out by naddy | Florian Obser | |
2016-09-17 | Merge ping6(8) manual into ping(8). | Florian Obser | |
Tweak & OK jmc@ | |||
2016-09-17 | ping6(8) is now a hardlink to ping(8). | Florian Obser | |
The instbin stuff looks good to deraadt@ | |||
2016-09-17 | The final merge ping6 into ping. | Florian Obser | |
"why slow down?" deraadt@ | |||
2016-09-17 | Use ECHOTMLEN define; no functional change. | Florian Obser | |
2016-09-17 | iov_base is already set in this case; reduce diff to ping6(8). | Florian Obser | |
2016-09-17 | MAXPAYLOAD is different between ping and ping6. | Florian Obser | |
2016-09-17 | Just use AF_INET like everywhere else. | Florian Obser | |
2016-09-17 | malloc sets errno; use err not errx | Florian Obser | |
2016-09-17 | whitespace | Florian Obser | |
2016-09-17 | Make getting source address more AF independent. | Florian Obser | |
2016-09-17 | If -I was not given hoist getting source address up. | Florian Obser | |
2016-09-17 | Make source address selection more AF independent. | Florian Obser | |
2016-09-17 | Introduce AF independent from. | Florian Obser | |
2016-09-17 | Use AF independent dst where possible. | Florian Obser | |
2016-09-17 | Blindly s/dst/dst4/ or s/dst/dst6/, AF independent dst will be | Florian Obser | |
introduced next. | |||
2016-09-17 | We will need the variable name "from" soon, so free it up by renaming | Florian Obser | |
to peer. While here move declaration down to where it's needed. No functional change. | |||
2016-09-17 | Reduce diff in pinger(). | Florian Obser | |
2016-09-17 | style | Florian Obser | |
2016-09-17 | Move more AF independent initialization around to reduce diff. | Florian Obser | |
2016-09-17 | Normalize receive packet allocation. | Florian Obser | |
2016-09-17 | Use ECHOTMLEN define. | Florian Obser | |
2016-09-17 | ping(8): The IPv6 header has a payload length field while IPv4 has a | Florian Obser | |
length field for the whole packet. Make some room for IPv6 payload. ping6(8): Sync to ping(8). | |||
2016-09-17 | Bring over includes, we will need them in a merge anyway. | Florian Obser | |
2016-09-17 | If no source address is specified and we are running in verbose mode | Florian Obser | |
try to find it with getsockname(2) like ping6(8). Disable printing for now though because scripts might depend on ping(8)'s output. | |||
2016-09-13 | Rearange option handling to reduce diff between ping(8) and ping6(8). | Florian Obser | |
While here be explicit that timing and timinginfo are initialized to 0. | |||
2016-09-13 | Make the raw socket non-global and pass it to retransmit()/pinger(). | Florian Obser | |
2016-09-13 | No need to have the destination global. | Florian Obser | |
2016-09-13 | No need to have this global. | Florian Obser | |