Age | Commit message (Collapse) | Author | |
---|---|---|---|
2016-01-27 | Clear out some repetitive and pointless verbiage. Shuffle other | Kenneth R Westerback | |
verbiage around to make things clearer. | |||
2016-01-27 | fyx typo. s,dynanic,dynamic, | Gleydson Soares | |
OK reyk | |||
2016-01-27 | Tweak some verbiage. | Kenneth R Westerback | |
2016-01-27 | make sure to check malloc(3) return pointer against NULL. | Gleydson Soares | |
OK krw@ | |||
2016-01-27 | tweak previous; ok krw | Jason McIntyre | |
2016-01-27 | On-disk partition name/types/processorid may or may not be NUL | Kenneth R Westerback | |
terminated after all. So add an extra byte for a NUL in the in-memory struct's. | |||
2016-01-27 | Remove some lies and pointless verbiage. Tweak HISTORY. | Kenneth R Westerback | |
2016-01-27 | We do not support logical_block != physical_block. Remove logical_block | Kenneth R Westerback | |
field and left over code that checks for logical != physical. Removes confusion with dmpe fields lblock_start and lblocks, which have nothing to do with block sizes! lblock_start is the block offset within the partition where the data actually starts. and lblocks is the number of blocks of data within the partition. Both are in units of *physical blocks*, a.k.a. disk sectors. | |||
2016-01-27 | Two more for the attic. | Kenneth R Westerback | |
2016-01-27 | Check block 0 signature, physical block size and physical block count when | Kenneth R Westerback | |
reading partition map. Check for unmapped physical blocks and overlapping partitions when reading partition map. No need for duplicate checks in validate_map(), so remove validate.c from build and 'v' command from code and docs. | |||
2016-01-27 | Nope. Missed a couple of '{}' that could go. | Kenneth R Westerback | |
2016-01-27 | Nuke another (and I hope final) batch of superfluous '{}' around single | Kenneth R Westerback | |
statements. | |||
2016-01-26 | Rework and simplify string argument parsing. All string arguments are at | Kenneth R Westerback | |
most DPISTRLEN (32) characters so there is no need for fancy dynamic growing strings. Use a DPISTRLEN long buffer and bail if it fills up. Rename get_string() to get_dpistr() and get_string_argument() to get_dpstr_argument() to emphasize they will return strings that fit in DPISTRLEN. Rework & simplify a pair of their consumers - do_rename_partition() and do_change_type() - to be more obviously identitical to each other bar the displayed verbiage. | |||
2016-01-26 | dpme_name and dpme_type are NUL-terminated in Apple code, so use | Kenneth R Westerback | |
strlcpy() to fill them. They are also supposed to be NUL-padded so zap previous contents before copying in possibly shorter new values. | |||
2016-01-26 | Remove needless zeroing. Anonymously mapped memory is always zeroed. | mmcc | |
ok tb@ | |||
2016-01-26 | Use an unsigned int rather than an int when iterating through all 32 | mmcc | |
bits in the form: for (i = 1; i; i <<= 1) This avoids undefined operations when shifting into and out of the highest-order bit. ok millert@ | |||
2016-01-26 | Whitespace, line wrapping fixes. Nuke many superfluous '{}' around single | Kenneth R Westerback | |
statements. 0 -> NULL for pointer checks. | |||
2016-01-26 | Whitespace, line wrapping fixes. | Kenneth R Westerback | |
2016-01-26 | Simplify logic of read_partition_map(), junking retries with various sizes | Kenneth R Westerback | |
of logical block. Rely on read_dpme() to do the correct thing. | |||
2016-01-25 | Two more for the attic. | Kenneth R Westerback | |
2016-01-25 | Use new read/write_block0 and read/write_dpme which handle any | Kenneth R Westerback | |
endian or alignment issues forcefully. Removes need for convert_* functions so unhook convert.c from build. read/write_block become static functions inside file_media.c. Tweak struct block0 to stop trying to handle alignment issues by clever declaration. Rely on the new functions to accurately translate between on-disk and in-memory layouts. Enables pdisk to work on amd64 and likely other architectures if it's ever desirable. Does bring back DEV_BSIZE to pdisk.c since the in-memory structure will *not* be 512 bytes on other archs. | |||
2016-01-25 | Add read/write_block0 and read/write_dpme functions, not yet used. | Kenneth R Westerback | |
2016-01-25 | Tweak fields in struct dpme to be more consistent with Apple's info. | Kenneth R Westerback | |
Better comments, make all reserved fields uint8_t arrays, don't claim uint32_t fields are actually pointers. | |||
2016-01-25 | remove some uneeded includes | Jonathan Gray | |
ok krw@ | |||
2016-01-24 | Whitespace. | Kenneth R Westerback | |
2016-01-24 | Nuke get_align_long() and put_align_long() #define's. They don't do | Kenneth R Westerback | |
anything according to gcc & cmp. cmp suggested by & ok stefan@. | |||
2016-01-24 | Nuke more pointless checks for map NULLness. | Kenneth R Westerback | |
2016-01-24 | fix 1.18 by removing extra argument from explicit_bzero calls | mmcc | |
from kili@ | |||
2016-01-24 | Whitespace fixes. | Kenneth R Westerback | |
2016-01-24 | Immediately zero the stack-allocated buffers for the passphrase and salt rather | mmcc | |
than doing so conditionally later on. These were false positives during an explicit_bzero audit. ok gsoares@ | |||
2016-01-24 | Assuming the map is always provided simplifies a bunch of logic, nukes | Kenneth R Westerback | |
get_block_n() and removes a whack of pointless static variables. | |||
2016-01-24 | Delete duplicated line that was setting sbBlkCount to 0; Score one | Kenneth R Westerback | |
for the 'v' command! | |||
2016-01-24 | use explicit_bzero(3) for clearing sensitive data | Gleydson Soares | |
OK millert@ mmcc@ | |||
2016-01-23 | Nuke unused kPatchType. Nuke kStringNot and use " not' where needed. | Kenneth R Westerback | |
Nuke kStringEmpty and use "" where needed. Nuke unused static 'g'. Eliminate #include's in *.h files. Some whitespace fixes. | |||
2016-01-23 | No need for 'default_value' parameter for get_number_argument() since we | Kenneth R Westerback | |
always pass kDefault. a.k.a. -1. Nuke kDefault since it is now unused. Nuke unused #define MAXIOSIZE in passing. | |||
2016-01-23 | No need for get_string_argument() parameter 'reprompt' since we | Kenneth R Westerback | |
always pass it '1'. | |||
2016-01-23 | Pass the disk sector size to open_partition_map(), eliminating it's | Kenneth R Westerback | |
internal need for DEV_BSIZE. Ditto create_partition_map(). malloc((sizeof(struct [block0|dpme])) instead of malloc(DEV_BSIZE). Remove another #include <param.h>. | |||
2016-01-23 | Add comments to ensure future spelunkers realize that struct block0 | Kenneth R Westerback | |
and struct dpme must be 512-bytes long at the moment. Use this fact to avoid using DEV_BSIZE and thus replace #include <param.h> with #include <types.h> in pdisk.c. Constrain media size to UINT32_MAX, the actual limit, instead of LONG_MAX, which could be way more on some theoretical future arch running pdisk. And do the constraint inside open_partition_map(). | |||
2016-01-23 | Avoid double prompt after creating default map on startup. | Kenneth R Westerback | |
2016-01-23 | Flip read_block() and write_block() back to taking sector addresses | Kenneth R Westerback | |
instead of off_t values. Do the DEV_BSIZE multiplication in these two functions. Easier to read code and kills two #include <sys/param.h>. Kill unused label. | |||
2016-01-23 | map->block0 is always allocated or the map is discarded. | Kenneth R Westerback | |
So stop checking for NULL. Nuke get_block_zero() and just use map->block0. | |||
2016-01-23 | Nuke sync_device_size() and do it's one-field-update in coerce_block0(), | Kenneth R Westerback | |
right after we read/allocate media->block0. Doing sync *before* media->block0 is allocated is bad. The map->physical_block is initialized correctly and never to the magic number '1'. So just use map-physical_block to initialize sbBlkSize. | |||
2016-01-23 | Always initialize media_size to provided mediasz in open_partition_map(). | Kenneth R Westerback | |
2016-01-23 | Break annoying long line. | Kenneth R Westerback | |
2016-01-22 | Change partition map field 'data' to 'dmpe'. Change 'create_data' | Kenneth R Westerback | |
to 'create_dmpe'. Sweep up some 'struct dpme *data' to struct dpme *dpme'. | |||
2016-01-22 | Of course if you change the parameter name you need to change the uses of | Kenneth R Westerback | |
said parameter to the new name. | |||
2016-01-22 | Change parameter name 'data' to 'block0'. | Kenneth R Westerback | |
2016-01-22 | Whitespace fixes. | Kenneth R Westerback | |
2016-01-22 | Rename map field 'misc' to 'block0' since that's what it is. | Kenneth R Westerback | |
2016-01-22 | Whitespace fixes. | Kenneth R Westerback | |