| Age | Commit message (Collapse) | Author |
|---|
|
|
|
section is describing a way to protect encapsulated packets by IPsec,
"link2" was misleading since it is unrelated to that purpose.
ok markus
|
|
provoked by jmc (and reminded that i failed to commit by ingo)
|
|
feedback/ok schwarze
|
|
discussed with jsg
|
|
straight replace: thanks both to schwarze and maja for feedback
on how to rewrite parts;
i've snuck in an rcs id->openbsd id change in dev_mkdb too;
|
|
Several fonts use this private area for glyphs
Suggested by nicm@
|
|
|
|
|
|
|
|
multipath route entries mpsafe.
ok dlg@
|
|
found by schwarze;
ok schwarze guenther
|
|
there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.
IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.
instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.
this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.
ok kettenis@ mpi@ jmatthew@ deraadt@
|
|
Pointed out by Jan Stary, but I used the faq15 URL because the suggested one
is linked a couple of lines below already.
|
|
ok schwarze
|
|
|
|
|
|
|
|
|
|
|
|
wart is incompatible with pledge, because suddenly a "dns" operation
needs "getpw" access to ypbind/ypserv, etc. file + dns access is
enough for everyone, sorry if you were using that old SunOS 4.x style
mechanism, but it is now gone.
ok semarie millert florian
|
|
feedback/ok schwarze
|
|
|
|
readable and to emphasis that they are not the prefered API for your
drivers.
ok dlg@
|
|
|
|
|
|
|
|
|
|
ok schwarze
|
|
As Kenjiro Cho pointed out it is very hard to cancel a dequeue operation
for some queueing disciplines when such it keeps some internal states.
As you can see, APIs can also Live Fast & Die Young.
ok dlg@
|
|
/usr/share/misc/terminfo.db for the moment). ok millert
|
|
|
|
are aliases rather than actual things;
ok schwarze
|
|
MBUF_LIST_FOREACH is then rewritten on top of those.
this makes it easier to get at the head of a list too, which may make
the hfsc ifq backend nicer.
based on a discussion with kenjiro cho
ok mpi@
|
|
|
|
do so.
"good" deraadt@
|
|
to meet their code again... in the bit bucket!
|
|
|
|
fixing it now before i regret it more.
|
|
|
|
the code is refactored so the IFQ macros call newly implemented ifq
functions. the ifq code is split so each discipline (priq and hfsc
in our case) is an opaque set of operations that the common ifq
code can call. the common code does the locking, accounting (ifq_len
manipulation), and freeing of the mbuf if the disciplines enqueue
function rejects it. theyre kind of like bufqs in the block layer
with their fifo and nscan disciplines.
the new api also supports atomic switching of disciplines at runtime.
the hfsc setup in pf_ioctl.c has been tweaked to build a complete
hfsc_if structure which it attaches to the send queue in a single
operation, rather than attaching to the interface up front and
building up a list of queues.
the send queue is now mutexed, which raises the expectation that
packets can be enqueued or purged on one cpu while another cpu is
dequeueing them in a driver for transmission. a lot of drivers use
IFQ_POLL to peek at an mbuf and attempt to fit it on the ring before
committing to it with a later IFQ_DEQUEUE operation. if the mbuf
gets freed in between the POLL and DEQUEUE operations, fireworks
will ensue.
to avoid this, the ifq api introduces ifq_deq_begin, ifq_deq_rollback,
and ifq_deq_commit. ifq_deq_begin allows a driver to take the ifq
mutex and get a reference to the mbuf they wish to try and tx. if
there's space, they can ifq_deq_commit it to remove the mbuf and
release the mutex. if there's no space, ifq_deq_rollback simply
releases the mutex. this api was developed to make updating the
drivers using IFQ_POLL easy, instead of having to do significant
semantic changes to avoid POLL that we cannot test on all the
hardware.
the common code has been tested pretty hard, and all the driver
modifications are straightforward except for de(4). if that breaks
it can be dealt with later.
ok mpi@ jmatthew@
|
|
of another one. Adapted from FreeBSD. OK jmc@ dlg@ nicm@
|
|
|
|
ok deraadt@, mpi@, jmc@
|
|
|
|
neither of which appear to exist;
|
|
|
|
conceptual ok guenther millert nicm
|
|
suggested by schwarze; ok sthen
|
|
|
