| Age | Commit message (Collapse) | Author |
|---|
|
was right. There is another path that ends up avoiding the disk_unbusy
call I inserted.... tested by robert too
|
|
it should not; ok dlg
problem spotted using zaurus soft-drive-led diff which is pending
i think i convinced jsg now that this fix is better than putting it
in wdrestart
|
|
|
|
|
|
are seeing a panic at halt time.
|
|
adjusted the packet and identify commands.
|
|
that shouldn't care about don't care bits does care.
|
|
|
|
This includes a nasty hack to reduce openings and throw away command slots
if the device supports a lower queue depth than the host controller does.
Yes, we're thinking about a better solution.
|
|
don't use xa->flags afterwards.
|
|
Because you cannot have NCQ commands active at the same time as standard
(non-queued) commands, we must introduce a queueing scheme into the driver.
This scheme ensures that a standard command is only issued to the drive when
all currently active NCQ commands have finished, and that NCQ command issue
is delayed when we have a pending standard command.
Additionally, the queueing scheme adds a constraint to ensure that there are
never more than two standard commands issued on a port at once. This should
ensure that commands become active in the order they were submitted (regardless
of their command slot number) both initially and when the port is reactivated
after error recovery.
These points mean that issuing a standard command effectively serialises the
port, which may help us implement meaningful I/O barriers in the future.
|
|
|
|
it a bit easier to read. there are variations on this, but they can be
defined later.
|
|
could pick up a previous ATA_F_POLL from a previous non-data command.
|
|
|
|
Note that the ATA spec says we're should retry after error until we see no
more errors. This is not (yet) implemented.
|
|
isn't sent to the device.
|
|
|
|
something really big. The SCSI layer isn't yet ready for it.
|
|
in the inquiry error paths, as the HBA will have already completed the
ata_xfer with an error.
Reminder and ok dlg@
|
|
etc, just work.
|
|
|
|
|
|
|
|
of the wdcreg.h include in atascsi.
"feel free to remove" pascoe@
|
|
etc), and request that the D2H FIS at the completion of all (DMA) commands
generate an interrupt.
This makes each data transfer generate one interrupt instead of two and
should guarantee that the interrupt that is generated actually arrives
after the command has completed.
|
|
works.
From dlg@
|
|
|
|
simply include a pointer to the command FIS that we will issue to the device.
Include another space where we can copy back an error register set from a
failed command.
This means that we can now build and issue arbitrary commands from atascsi,
and retrieve errors back.
|
|
atascsi will be driving, and add it to the AHCI CCB.
This effectively gives us all the resources we need for a transfer in one
hit, meaning that we don't need to worry about whether we will have a pool
shortage or not enough CCBs. The SCSI mid layer should take care to never
exceed the number of CCBs we have available, based on our sc_link.openings.
|
|
|
|
|
|
read capacity completion to compensate.
|
|
disk.
|
|
|
|
queued commands to be done.
|
|
- add a ccb_done member to the ahci_ccb, which points to a function that
is used to complete the current xfer
- ccbs no longer rely on an ata_xfer being provided for submission to work
- ahci is stupid and has no way to telling you the difference between an
empty command slot, and a completed command. we keep track of active
commands with ap_active in ahci_port, so we dont try and complete commands
we havent actually submitted
- ahci_start simple submits a command to the hardware now
- provide the start of an interrupt handler for each port (which is not yet
called by the controllers interrupt handler)
- provide an ahci_poll which is built on top of ahci_start and
ahci_port_intr
- remove the fake ata_xfers from the softreset path
- on completion of an ahci command, sync the relevant dma memory
- provide a completion path for ata_xfers which syncs the xfers buffer
and calls the xfers completion handler
in atascsi.c:
- start defining the contents of the response to an ATA IDENTIFY command
specific to SATA
- implement the faking of scsi inquiries, so now you'll actually see a disk
attach to ahci.
- start implementing a fake scsi read capacity. it presents a fake geometry
though, so dont get too excited when ahci magically makes your disk have a
terabyte in size.
lots of discussion, help, tweaks, and an ok from pascoe@
|
|
destined for. add ata_exec, which will push the xfer on the right path.
|
|
routine will take a pointer to ata_xfer, not a void *. add some states and
flags for the xfers, and some values for the hba to return when processing
them.
|
|
not an array of ints.
|
|
ok dlg@
|
|
in the ata_port struct so a hba can find its own info for that port.
|
|
is created or destroyed.
|
|
accessing that pool.
|
|
committing it.
|
|
|
|
|
|
|
|
tree. ive lost two large changes today thanks to my own stupidity which
could have been avoided if they were in the tree.
discussed with deraadt@
ok jsg@ grange@ an older version was ok marco@
|
|
need the debug info uncomment the printf's you need. Crude but
effective way to suppress 'no disklabel' errors that pop up at the
most innconvenient times to frighten users. More elegant method,
DPRINTF-like constructs or something, later.
"Yay!" marco@ ok deraadt@
|
