Age | Commit message (Collapse) | Author |
|
ok jsg@ phessler@
|
|
ok patrick@ jan@
|
|
on a Lenovo ThinkPad P1 Gen 4, the audio device is subclass audio not
hd audio, so azalia does not match
reported by John Browning
ok kettenis@ thfr@
|
|
The property bits of audio(9) are obsolete and ought to be removed
completely.
sys/dev/audio.c:audio_open() currently uses get_props() to bail out if
read *and* write was requested on a non-duplex driver.
Drivers that currently support playing but not recording need adjustment
before the API can be cleaned up.
Drivers that advertise themselves as full duplex, i.e. those that always
return AUDIO_PROP_FULLDUPLEX unconditionally in their get_props() currently
always succeed this check.
As this is the only property, losen audio_open()'s DIAGNOSTIC check and only
do the duplex check if the driver provides get_props().
This allows for simple removal of get_props() from full-duplex drivers
without adding any other code or without changing functionality.
This includes all audio drivers under sys/dev/pci/ (maestro(4) being the
only unfinished exception here).
Other drivers as well as the API change can then follow in smaller diffs.
This builds on amd64, arm64, i386, macppc and sparc64.
amd64 with azalia(4) still plays, records as well as plays and records
at the same time on my X230 as tested with
$ aucat -i play.wav [-o rec.wav]
alpha and hppa tests by miod
OK ratchov miod
|
|
|
|
This audio(9) struct will lose a member, but drivers init their struct quite
inconsistently, most pre-C99 style.
Use C99 style everywhere, to get rid of all annoying differences and allow
for easy member removals/additions:
- don't change current order of members
- no explicit NULL members
- no comments or blank lines
- trailing comma in last member line
GENERIC.MP builds fine with this on arm64, amd64, i386 and sparc64.
macppc and alpha build-tested by miod
OK ratchov miod
|
|
AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with
commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53
Author: ratchov <ratchov@openbsd.org>
Date: Thu Jun 25 06:43:45 2015 +0000
Reimplement the audio driver in a simpler way, removing unused/unusable
functionality. Same API and ABI except for the removed bits and no
behaviour change for programs using libsndio. With help from armani@
and mpi@, thanks.
but remained defined and set in drivers.
and the following merely moved them when they were dead code already:
commit 9215aa3dfad387bca877a805534df6dcfe8722eb
Author: ratchov <ratchov@openbsd.org>
Date: Wed Aug 31 07:22:43 2016 +0000
Delete unused ioctls and associated macros. Move macros that are still
used internally by low-level drivers from sys/audioio.h to
dev/audio_if.h instead of deleting them.
None of this is used in base or ports; codesearch.debian.net only shows
AUDIO_PROP_{CAPTURE,PLAYBACK} in firefox-esr, mozjs and cubeb.
ratchov points out that audio_if.h and audioio.h are private interfaces
and the codesearch shows SunOS and NetBSD bits (#ifdef'd out on OpenBSD).
OK ratchov
|
|
HP Spectre x360 16-f0013dx has subclass audio not hd audio
so azalia does not match
from Neel Chauhan
|
|
on a Dell Latitude 3410 the audio device is subclass audio not hd audio
so azalia does not match
reported by Kirill Filatov
|
|
|
|
on a Star Labs StarLite Mk IV laptop the audio device is subclass audio
not hd audio, so azalia does not match
reported and tested by Chris Narkiewicz
ok deraadt@
|
|
on a Dell G3 3590 the audio device is subclass audio not hd audio
so azalia does not match
should fix azalia not attaching reported by Adriano Barbosa
|
|
ok mpi@ ratchov@ "More const is good" deraadt@
|
|
|
|
unused but intended to be used to correlate audio and wskbd devices.
ok ratchov@
|
|
cavs/hda is pci class multimedia subclass audio so not automatically
matched by azalia but confirmed to work after matched
tested by Sven Wolf on Acer Swift 1 SF114-34 with Pentium Silver N6000
|
|
feedback and ok tb@ jmc@ ok ratchov@
|
|
|
|
shows gains up to 50%) by skipping attach of irrelevant devices, which are
tagged CD_SKIPHIBERNATE in the per-driver cfdriver. In particular, usb devices
are not attached, so they don't need to detach during the suspend-unpack-resume.
New bootblocks are required (which tell the kernel it's job is unhibernate
before configure runs)
tested by various
|
|
don't do anything on shutdown.
This fixes a panic that was reported by me on X1 Extreme Gen 1.
ok ratchov@
|
|
from Ashton Fagg
|
|
The ASUS ZenBook S UX393EA HDA device has a multimedia subclass of audio
instead of the expected subclass of HD audio, so add 500 Series LP HDA
to the list of devices.
Fix suggested by and ok brynet@
Reported and tested by Peter N. M. Hansteen
|
|
|
|
From Ivo Sbalzarini <ivo.sbalzarini at gmail.com>
|
|
|
|
|
|
Lenovo C930 has audio pci subclass instead of hda
from bobby@plexuscomp.com
|
|
The HP EliteBook 850 G6 has an Intel 300 Series HD Audio device with pci
subclass of MULTIMEDIA_AUDIO instead of the expected MULTIMEDIA_HDAUDIO.
Match on the pci id to handle this.
Reported and tested by Bruno Flueckiger.
ok kettenis@ deraadt@
|
|
from Hemno Sapients <calomalus at airmail.cc>, thanks
|
|
ok mortimer@ mpi@ deraadt@
|
|
clear they are not widget quirks, and renumber AZ_QRK_WID_SPKR2_DAC
to fall outside of AZ_QRK_WID_MASK since it's not handled by
azalia_codec_widget_quirks
|
|
block size is requested. This avoids exceeding half the buffer size.
|
|
This simplifies the code and allows any block size supported by the
hardware to be used.
ok mpi@
|
|
The X1C7 has 4 speakers and the speaker2 set needs to be routed to a
different DAC.
Also add the Intel 300 Series HDA to the list of devices on which to
enable snooping.
|
|
ok tedu
|
|
ok jsg@
|
|
Keeps stereo sound intact across suspend/resume cycles on the matebook x.
ok phessler@ deraadt@
|
|
audio stopping after varying amounts of time. ok brynet@, deraadt@
|
|
speaker on its Dolby Atmos system.
Through some extensive tracing of the Realtek Windows driver, I
found the many hundreds of CORB commands that the Windows driver
sends to initialize Dolby Atmos and activate both speakers.
The list of CORB commands was optimized by Tomas Espeleta to reduce
file size and then implemented in azalia by Stefan Sperling.
ok stsp, deraadt
|
|
Michael W. Bombardieri. Thanks.
|
|
Michael W. Bombardieri. Thanks.
|
|
use it during suspend/resume. Remove driver-specific mixer
save/restore bits that don't need to be duplicated in every
low-lever driver.
ok mpi
|
|
|
|
Michael W. Bombardieri, thanks.
|
|
|
|
check that the CORB is running. Fixes a regression introduced in -r1.236
that resulted in printing 'azalia0: CORB is not running' on each suspend
resume cycle. Issue reported on icb by mlarkin; tested by Manuel Giraud,
ratchov and myself.
ok ratchov
|
|
|
|
or headphones on reboot.
From Manuel Giraud <manuel () ledu-giraud ! fr>
Tweaks & ok ratchov
|
|
constants.
The consensus is that if both operands are constant, we don't need
mallocarray. Reminded by tedu@
ok deraadt@
|
|
ok deraadt@
|