summaryrefslogtreecommitdiff
path: root/sys/dev/pci/if_de.c
AgeCommit message (Collapse)Author
2017-03-08Do not clear IFF_UP, even in the error path, clearing IFF_RUNNINGMartin Pieuchot
is enough. This flag should only be set by the stack, drivers shouldn't mess with it. Discussed with dlg@ and mikeb@, ok mikeb@, stsp@
2017-01-22move counting if_opackets next to counting if_obytes in if_enqueue.David Gwynne
this means packets are consistently counted in one place, unlike the many and various ways that drivers thought they should do it. ok mpi@ deraadt@
2016-04-13G/C IFQ_SET_READY().Martin Pieuchot
2015-12-08No trailers has been the default and only option for 20 years, yet someTed Unangst
drivers still set IFF_NOTRAILERS while others do not. Remove all usage of the flag from the drivers which in ancient times used it (and the modern drivers which blindly copied it from those drivers of yore). suggested by guenther. ok mpi
2015-12-08dont need to repeatedly set if_start to the same function.David Gwynne
2015-11-25Network drivers should not include <net/route.h> or <net/netisr.h>Martin Pieuchot
2015-11-25replace IFF_OACTIVE manipulation with mpsafe operations.David Gwynne
there are two things shared between the network stack and drivers in the send path: the send queue and the IFF_OACTIVE flag. the send queue is now protected by a mutex. this diff makes the oactive functionality mpsafe too. IFF_OACTIVE is part of if_flags. there are two problems with that. firstly, if_flags is a short and we dont have any MI atomic operations to manipulate a short. secondly, while we could make the IFF_OACTIVE operates mpsafe, all changes to other flags would have to be made safe at the same time, otherwise a read-modify-write cycle on their updates could clobber the oactive change. instead, this moves the oactive mark into struct ifqueue and provides an API for changing it. there's ifq_set_oactive, ifq_clr_oactive, and ifq_is_oactive. these are modelled on ifsq_set_oactive, ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd. this diff includes changes to all the drivers manipulating IFF_OACTIVE to now use the ifsq_{set,clr_is}_oactive API too. ok kettenis@ mpi@ jmatthew@ deraadt@
2015-11-24You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.Martin Pieuchot
2015-11-24The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.Martin Pieuchot
2015-11-23you cant touch m_pkthdr in between ifq_deq_begin and ifq_deq_commit.David Gwynne
TULIP_SETCTX() does though. this moves that call after ifq_deq_commit. problem reported (with great detail) and fix tested by ricardo mestre ok mpi@
2015-11-20shuffle struct ifqueue so in flight mbufs are protected by a mutex.David Gwynne
the code is refactored so the IFQ macros call newly implemented ifq functions. the ifq code is split so each discipline (priq and hfsc in our case) is an opaque set of operations that the common ifq code can call. the common code does the locking, accounting (ifq_len manipulation), and freeing of the mbuf if the disciplines enqueue function rejects it. theyre kind of like bufqs in the block layer with their fifo and nscan disciplines. the new api also supports atomic switching of disciplines at runtime. the hfsc setup in pf_ioctl.c has been tweaked to build a complete hfsc_if structure which it attaches to the send queue in a single operation, rather than attaching to the interface up front and building up a list of queues. the send queue is now mutexed, which raises the expectation that packets can be enqueued or purged on one cpu while another cpu is dequeueing them in a driver for transmission. a lot of drivers use IFQ_POLL to peek at an mbuf and attempt to fit it on the ring before committing to it with a later IFQ_DEQUEUE operation. if the mbuf gets freed in between the POLL and DEQUEUE operations, fireworks will ensue. to avoid this, the ifq api introduces ifq_deq_begin, ifq_deq_rollback, and ifq_deq_commit. ifq_deq_begin allows a driver to take the ifq mutex and get a reference to the mbuf they wish to try and tx. if there's space, they can ifq_deq_commit it to remove the mbuf and release the mutex. if there's no space, ifq_deq_rollback simply releases the mutex. this api was developed to make updating the drivers using IFQ_POLL easy, instead of having to do significant semantic changes to avoid POLL that we cannot test on all the hardware. the common code has been tested pretty hard, and all the driver modifications are straightforward except for de(4). if that breaks it can be dealt with later. ok mpi@ jmatthew@
2015-11-04use IFQ_IS_EMPTY to see if if_snd is empty, not IF_IS_EMPTYDavid Gwynne
2015-11-04replace the ifqueues used for tulip_txq and _rxq with mbuf_lists.David Gwynne
2015-10-25arp_ifinit() is no longer needed.Martin Pieuchot
2015-06-26There is no excuse for using dma_alloc(9) when a bus_dma_tag_t is available.Mark Kettenis
deraadt@ thinks this isn't worth it, but reyk@ and mlarkin@ tested it anyway
2015-06-25Ensure the setup block is DMA reachable.Theo de Raadt
tested by reyk, mlarkin, others
2015-06-24Increment if_ipackets in if_input().Martin Pieuchot
Note that pseudo-drivers not using if_input() are not affected by this conversion. ok mikeb@, kettenis@, claudio@, dlg@
2015-05-15Convert to if_input().Martin Pieuchot
ok dlg@
2015-04-01Remove annoying comment mentionning ether_output().Martin Pieuchot
2015-03-14Remove some includes include-what-you-use claims don'tJonathan Gray
have any direct symbols used. Tested for indirect use by compiling amd64/i386/sparc64 kernels. ok tedu@ deraadt@
2014-12-22unifdef INETTed Unangst
2014-09-08remove uneeded route.h includesJonathan Gray
ok miod@ mpi@
2014-07-22Fewer <netinet/in_systm.h>Martin Pieuchot
2014-04-22Remove some altq tentacles.Martin Pieuchot
ok pelikan@, henning@
2014-04-19another questionable "optimization": de used tulip_ifstart_one insteadHenning Brauer
of tulip_ifstart if the sendqueue was empty, but only if altq wasn't compiled in (i. e., that's a _compile time_ decision and not based on wether altq was actually used). just use tulip_ifstart all the time, as before in our regular kernels. kill tulip_ifstart_one completely. makes sense to sthen
2013-11-26Instead of comparing the lower and higher addresses of all the multicastMartin Pieuchot
entries to decide if the IFF_ALLMULTI flag should be set, check if there is at least one real range between them. This should not change the behavior of any driver but if you encounter any problem, feel free to revert the offending chunk and ping me about it. ok naddy@, dlg@
2013-08-07Most network drivers include netinet/in_var.h, but apparently theyAlexander Bluhm
don't have to. Just remove these include lines. Compiled on amd64 i386 sparc64; OK henning@ mikeb@
2013-06-04Prevent panic'ing on alpha after ifconfig'ing up an unplugged de interface,Miod Vallat
by making tulip_txput() aware of whether or not the mbuf it is processing is in if_snq or not, rather than abusing the TULIP_TXPROBE_ACTIVE flag. Found the hard way by kurt@, tested on AlphaServer 1000A, I've been sleeping on this diff for about 3 years.
2011-07-07use IF_LEN/IFQ_LEN to access and ifqueue's length field. ryan okHenning Brauer
with this nothing in the tree fiddles if ifqueue internals any more, of course except if.c and if.h (and some altq)
2011-07-06cosnistently use IFQ_SET_MAXLEN, surfaced in a discussion with + ok bluhmHenning Brauer
2011-04-03use nitems(); no binary change for drivers that are compiled on amd64.Jasper Lievisse Adriaanse
ok claudio@
2010-09-20Stop doing shutdown hooks in network drivers where possible. We alreadyTheo de Raadt
take all interfaces down, via their xxstop routines. Claudio and I have verified that none of the shutdown hooks do much extra beyond what xxstop was already doing; it is largely a pile of junk. ok claudio, some early comments by sthen; also read by matthew, jsg
2010-04-08these files don't need to include proc.h anymore. ok oga for agpTed Unangst
2009-10-02remove trash left in debug changes; lindroos@nls.fiTheo de Raadt
2009-08-13- consistify cfdriver for the ethernet drivers (0 -> NULL)Jasper Lievisse Adriaanse
ok dlg@
2009-06-19Tidy up allocation of transmit DMA maps and generalize it to alsoChristian Weisgerber
tidy up allocation of receive DMA maps. Previously the driver was using DMA maps off the free list without fully allocating them, in order to save two or three lines releasing them on error paths. This was causing it to reuse a map already in use when under load. From NetBSD. Revert a workaround against a NULL pointer dereference on alpha when invoking bus_dmaamp_sync. All submitted by Brad.
2008-11-28Eliminate the redundant bits of code for MTU and multicast handlingBrad Smith
from the individual drivers now that ether_ioctl() handles this. Shrinks the i386 kernels by.. RAMDISK - 2176 bytes RAMDISKB - 1504 bytes RAMDISKC - 736 bytes Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users. Build tested on almost all archs by todd@/brad@ ok naddy@
2008-10-02First step towards cleaning up the Ethernet driver ioctl handling.Brad Smith
Move calling ether_ioctl() from the top of the ioctl function, which at the moment does absolutely nothing, to the default switch case. Thus allowing drivers to define their own ioctl handlers and then falling back on ether_ioctl(). The only functional change this results in at the moment is having all Ethernet drivers returning the proper errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown ioctl's. Shrinks the i386 kernels by.. RAMDISK - 1024 bytes RAMDISKB - 1120 bytes RAMDISKC - 832 bytes Tested by martin@/jsing@/todd@/brad@ Build tested on almost all archs by todd@/brad@ ok jsing@
2008-03-04Add a workaround against a NULL pointer dereference on alpha whenMiod Vallat
invoking bus_dmaamp_sync, until the cause of the problem is found. ok deraadt@
2007-09-19Remove unused tulip_21041_media_noprobe() function and tulip_21041np_boardswBrad Smith
struct. ok dlg@
2007-02-14Consistently spell FALLTHROUGH to appease lint.Jonathan Gray
ok kettenis@ cloder@ tom@ henning@
2006-07-08print the chipset revision too.Brad Smith
2006-07-08shorten dmesg entry from two lines to one.Brad Smith
2006-07-08tulip_pci_(probe/attach) -> tulip_(probe/attach)Brad Smith
2006-07-08remove splnet from attach routine.Brad Smith
2006-06-01de-static and formatting.Brad Smith
2006-05-28unknown ioctl is ENOTTY not EINVALJason Wright
2006-05-09fix non-ALTQ case.Brad Smith
2006-05-06restore ALTQ support which was lost with rev 1.87Brad Smith
2006-03-25allow bpf(4) to ignore packets based on their direction (inbound orDamien Miller
outbound), using a new BIOCSDIRFILT ioctl; guidance, feedback and ok canacar@
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-01 21:19:40 +0000