| Age | Commit message (Collapse) | Author |
|---|
|
- Avoid using copyinstr() without checking the return value.
- sys_mount() has already copied the path in, so pass this to the
filesystem mount code so that it does not have to copy it in again.
- Avoid copyinstr()/bzero() dance when we can simply bzero() and strlcpy().
ok krw@
|
|
using "%.11s" to print them out. Make all dos file names 11 byte
arrays and nuke the attempt to put '\0' at the 12th position of
such an array.
Fixes 'panic: smashed stack in msdosfs_rename.c' reported by
MERHIGI Marcus via tech@.
Tested by MERHIGI Marcus. Suggestions and ok tedu@.
|
|
rlimit, then a write that would take it over the limit should be
clamped, making it a partial write.
ok beck@
|
|
to diff against FreeBSD's.
From Brad; no object file change on amd64.
|
|
caching the last cluster in the file before extending it considerably
speeds up further lookups. As a consequence this keeps write speed from
gradually decreasing and provides a measurable (up to 2x) performance
increase. Prompted by the diff from Alexander Polakov, ok miod, krw.
|
|
monitoring fs mounts happy
tested by ajacoutot@ and ok by thib@, krw@
|
|
|
|
|
|
and return EOPNOTSUPP directly from the VOP_* functions.
Filesystems should, at some point fill in every function
in the vop_default struct so we can get rid of the 'if'
statements in VOP_*.
|
|
unrelated, and his alpha is much happier now.
OK deraadt@
|
|
|
|
|
|
/* something */
if (error) {
VOP_UNLOCK();
return;
}
VOP_UNLOCK();
to the clearer and shorter:
VOP_UNLOCK();
if (error)
return;
ok thib@, jsing@ as part of a larger diff.
|
|
have been resolved.
|
|
OK oga@, beck@, matthew@
|
|
vector setup that has questionable features (that have, as far as I can
tell never been used in practice, atleast not in OpenBSD), remove all
the gunk and favor a simple struct full of function pointers that get
set directly by each of the filesystems.
Removes gobs of ugly code and makes things simpler by a magnitude.
The only downside of this is that we loose the vnoperate feature so
the spec/fifo operations of the filesystems need to be kept in sync
with specfs and fifofs, this is no big deal as the API it self is pretty
static.
Many thanks to armani@ who pulled an earlier version of this diff to
current after c2k10 and Gabriel Kihlman on tech@ for testing.
Liked by many. "come on, find your balls" deraadt@.
|
|
so that libkvm doesn't need to define that, thereby avoiding some warnings.
ok miod@
|
|
direntry deName[8]/deExtension[3] buffers separately rather than in one
11 byte copy. Makes gcc4 -Wbounded happy.
ok krw
|
|
Feedback from miod@ and kettenis@.
ok beck@
|
|
at least until problem (starting somewhere between 4.1 and 4.2)
in buffer cache is found and a general fix is in place. Simply
B_INVAL small buf so it doesn't come back.
Addresses PR#6290, confirmed by submitter RD Thrush.
ok tedu@ "should be marked XXX" thib@
|
|
Found by LLVM/Clang Static Analyzer.
ok tedu@ krw@
|
|
locking fixes. Tweak cd9660 code to be the same as everywhere else,
no functional change.
ok beck@
|
|
miod@ deraadt@ ok.
|
|
ok krw@
|
|
ok thibski@
|
|
"fine" thib@
|
|
prodded by and ok thib@
agreed by art@ and blambert@
|
|
"do it" thib@
|
|
making directory moves work... discussed w. & makes sense - millert@
|
|
which is exactly what the macro does.
Macro's that are nothing more then:
#define FUNCTION(arg) function(arg)
are almost always pointless and should go away.
OK blambert@
Agreed by many.
|
|
it. So leave it untouched. Similiar to but more ruthless than the
fixes FreeBSD did, since they do use the value. Basically avoid
various off-by-one and off-by-many errors.
Fixes problems encountered by jsg@ and deraadt@ where filesystems
found on SDHC cards caused UVM faults.
Original fixes found by jsg@. ok jsg@.
|
|
the superuser. access(2) will now only indicate success for X_OK on
non-directories if there is at least one execute bit set on the file.
OK deraadt@ thib@ otto@
|
|
with eopnotsupp() instead;
ok blambert@
|
|
least has been seen from ian@'s new iPod, causing inappropriate
mounting.
ok miod@
|
|
sys/dev/pci/pciide.c from naddy@
|
|
64 instead of 63. deraadt@, weingart@, millert@, thib@, miod@ ok with
eliminating test entirely but tom@'s voice of caution wins out for the
quick commit. Tested by jsg@ to confirm it fixes his device.
|
|
from Alexey Vatchenko; ok tom
|
|
ok krw@
|
|
|
|
In ip_esp.c all allocated memory is now zero'd in the
"malloc(sizeof(*tc) + alen ..." case. The +alen memory was not
initialized by the bzero() call. Noticed by chl@.
"Looks good" art@ "seems ok" chl@
|
|
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().
|
|
things based on their use. ok with fixes from tom, tested by grange too
|
|
"ap = v" comments in under 8 seconds, so it must be ok. and it compiles
too.
|
|
ok pedro@, sturm@
|
|
exists, keep the containing directory's long name capabilities.
From NetBSD via Enache Adrian, okay millert@.
|
|
save the correct offset in case the directory has support for long file
names, and return it to the caller so she can proceed from a valid point.
From Alexey Vatchenko, okay tedu@.
|
|
Zap all calls to simple_lock/unlock() on it (those calls are
#defined away though). Remove the LK_INTERLOCK from the calls
to vn_lock() and cleanup the filesystems wich implement VOP_LOCK().
(by remvoing the v_interlock from there calls to lockmgr()).
ok pedro@, art@, tedu@
|
|
|
|
effectively been a no-op for quite some time now,
without promise for future usage.
ok pedro@
Testing by krw@ (earlier diff)
and Johan Mson Lindman (tybollt@solace.miun.se)
|
|
Enables devices (e.g. newer iPods, various other mp3 players) that use
2048 byte sectors.
Inspired by original diffs from weingart@ and Alexey Vatchenk.
ok tom@ pedro@ deraadt@ weingart@ marco@
|
