summaryrefslogtreecommitdiff
path: root/sys/net80211
AgeCommit message (Collapse)Author
2012-01-25There is no need to explicitly skip ic_bss when iterating over cached nodes.Stefan Sperling
The ic_bss is never put into the RB tree.
2012-01-25Clean inactive authenticated nodes during cache timeout as well.Stefan Sperling
There is no need to keep nodes cached with never associated and were inactive within the last 5 minutes or more. Keeps the node cache pretty clean in my environment with typical city-center wlan noise.
2012-01-21Implement missing bits of node inactivity accounting in hostap mode.Stefan Sperling
Small parts of code for this feature were already present but unused. A node becomes inactive after not sending or receiving a frame within 5 minutes. Inactive cached nodes (not authenticated or associated) are automatically cleared from the cache once every hour, making room for new nodes. If the node cache is full and room must be made for a new node, clean either a cached node (active or inactive), or an inactive authenticated or associated node. Also, do not send de-auth frames to nodes which never authenticated, and only send a de-auth frame once for a given node. This part was contributed by Steven Chamberlain, thanks! Tested by myself, krw@, edd@, Steven Chamberlain, and Markus Schatzl. ok deraadt@
2012-01-21Hold interrupts blocked while comparing a cached node's refcount to zeroStefan Sperling
and freeing the node. Just in case an interrupt happens to ref the node after the refcount was checked but before the node is freed. Tested by several as part of a larger diff.
2012-01-18Don't unconditionally allocate new nodes in the hostap auth frame input path.Stefan Sperling
Check if the node was already cached first. Duplicate nodes aren't reachable from the node cache's RB tree, so they leak and mess up node cache accounting. As more and more nodes leak the global nodes counter keeps increasing, eventually reaching the limit and hovering there. The system then constantly tries to clean the node cache, sending de-auth frames to stations in the process, even if the actual number of associated stations is small. ok jsg@
2012-01-18Make it possible to free cached nodes which never associated (e.g. nodesStefan Sperling
only scanning for networks). These were never put into COLLECT state and were thus never evicted from the node cache in hostap mode. ok jsg@
2011-05-04Collapse m_pullup and m_pullup2 into a single function, as they'reBret Lambert
essentially identical; the only difference being that m_pullup2 is capable of handling mbuf clusters, but called m_pullup for shorter lengths (!). testing dlg@ ok claudio@
2011-04-05Passing M_WAITOK to mbuf functions is supposed to be a contract betweenBret Lambert
the caller and the function that the function will not fail to allocate memory and return a NULL pointer. However, m_dup_pkthdr() violates this contract, making it possible for functions that pass M_WAITOK to be surprised in ways that hurt. Fix this by passing the wait flag all the way down the functions that actually do the allocation for m_dup_pkthdr() so that we won't be surprised. man page update forthcoming ok claudio@
2011-03-28Clean nodes until the number of cached nodes is smaller than the maximum numberMark Kettenis
of nodes, otherwise we'll never actually clean any nodes. Fixes issues with clients failing too attach because the node cache is completely filled. ok damien@
2011-03-04kill is_rx_elem_unknown.Federico G. Schwindt
damien@ ok. ports checked by sthen@.
2011-03-02Allow the kernel to compile with IEEE80211_DEBUG.Federico G. Schwindt
deraadt@ ok.
2011-02-21Fix stats about node allocation failures.Stefan Sperling
ok damien; committing with miod's permission (src is soft-locked)
2011-02-21When bridging multicast frames in hostap mode, make a deep copy of the mbufStefan Sperling
instead of a shallow copy to avoid problems if the mbuf is modified later (e.g. if the frame is encrypted). From FreeBSD. http://marc.info/?l=freebsd-current&m=114168135819304&w=2 http://svn.freebsd.org/viewvc/base?view=revision&revision=156367 ok damien; committing with miod's permission (src is soft-locked)
2011-01-11for key material that is being being discarded, convert bzero() toTheo de Raadt
explicit_bzero() where required ok markus mikeb
2010-09-29In the implementation of the SIOCS80211DELNODE ioctl, callMark Kettenis
ieee80211_node_leave() instead of ieee80211_release_node() which screws up reference counting and leads to use after free problems elsewhere in the code. Since ieee80211_node_leave() is only available if hostap support is compiled in, don't privide the SIOCS80211DELNODE ioctl if we're compiling without hostap support (e.g. on ramdisks). ok deraadt@, damien@
2010-08-07No "\n" needed at the end of panic() strings.Kenneth R Westerback
Bogus chunks pointed out by matthew@ and miod@. No cookies for marco@ and jasper@. ok deraadt@ miod@ matthew@ jasper@ macro@
2010-07-28Suspending drivers need to do as little as possible in here, so when theTheo de Raadt
transition is to INIT, try to not generate management frames if we can avoid it. ok damien
2010-07-20Switch some obvious network stack MAC comparisons from bcmp() toMatthew Dempsky
timingsafe_bcmp(). ok deraadt@; committed over WPA.
2010-07-19in hostap mode, notify drivers via a new callback when a STA leavesDamien Bergamini
the BSS. this is needed by drivers that need to maintain a hardware table of associated STAs (like ral(4) RT2860). idea from Nathanael Rensen
2010-07-17use the correct block ack structure when building an ADDBA response.Damien Bergamini
2010-07-17Drop 3rd and 4th clauses from David Young's license.Damien Bergamini
from NetBSD
2010-06-19In ieee80211_node_leave(), clear the associd after callingDamien Bergamini
ieee80211_node_leave_rsn() since ieee80211_node_leave_rsn() calls ic_delete_key() and drivers like ral(4) RT2860 need a valid associd in their delete_key callbacks. This affects HostAP mode only. from Nathanael Rensen. remove a useless (nested) #ifndef IEEE80211_STA_ONLY while i'm here
2010-06-14fix my previous commit, i forgot BIP, so instead of enumeratingDamien Bergamini
what is not supported as a group cipher, enumerate what is supported.
2010-06-14do not try to associate with an AP using an unsupported group cipher,Damien Bergamini
otherwise we will panic in ieee80211_add_rsn_body(). this may be the cause of a panic seen by reyk@ though i'm not 100% sure.
2010-06-07no need to include <sys/endian.h> twice!Damien Bergamini
2010-06-07tweak ieee80211_decap():Damien Bergamini
instead of copying the 802.11 header on the stack and building the ethernet header directly in the mbuf, build the ethernet header on the stack directly from the 802.11 header in the mbuf and copy the ethernet header to the mbuf after stripping the 802.11 header. makes the code easier to read/understand, especially, it is now explicit what is being put in the ether_type field. diff from Matthew Dempsky (matthew at dempsky dot org) moved ieee80211_align_mbuf() under #ifdef __STRICT_ALIGNMENT while i'm here.
2010-06-05when rekeying the GTK/IGTK, send the new key to clients, not theDamien Bergamini
old one. found after reading a post by Nathanael Rensen to tech@
2010-06-05there is no need to copy the full 802.11 header in ieee80211_decap()Damien Bergamini
as we do not use any field after i_addr4. slightly modified version of a diff from Matthew Dempsky (matthew at dempsky dot org), used MIN instead of min.
2010-04-20remove proc.h include from uvm_map.h. This has far reaching effects, asTed Unangst
sysctl.h was reliant on this particular include, and many drivers included sysctl.h unnecessarily. remove sysctl.h or add proc.h as needed. ok deraadt
2010-03-28Four uses of uninitialized variables found by clang via jsg@. ar5416, ar9287Kenneth R Westerback
and athn are only theoretically interesting. i33380211_node fixes a real bug in occupied channel detection. ok damien@
2010-02-25fix two comments that i forgot when the SA query transaction identifierDamien Bergamini
changed from 16 bytes to 2 bytes. no binary change
2010-02-17Do not always create a new node when a beacon or a probe responseDamien Bergamini
is received. The creation of a new node is already handled in ieee80211_recv_probe_resp() when necessary. This avoids creating empty nodes with wrong channels when beacons are received on the wrong channel (overlapping channels). Those empty nodes may also prevent the real node from being discovered because of ieee80211_find_node_for_beacon() filtering. This should prevent entries of the form: nwid "" chan 3 bssid 00:01:02:03:04:05 0dB 54M in "ifconfig if0 scan" output, like reported by Rivo Nurges.
2010-02-06when receiving the first message of an rsn group key handshakejoshua stein
packet, copy the key out of it properly. fixes the problem where only broadcast packets like ipv6 router advertisements were failing decryption and processing, only after a rekey. ok damien@
2009-11-23how did i manage to forget that file in my last commit?Damien Bergamini
2009-11-21when wpa is enabled, defer setting the link up until the 802.1XDamien Bergamini
port is valid (keys have been successfully exchanged.) this avoids dhclient timeouts when wpa is enabled.
2009-11-02s/hz/Hz/ on multiples of the SI unit hertz other than MHz.Igor Sobrado
reminded by STeve Andre.
2009-10-30missing \n in log() message.Damien Bergamini
from Jurjen Oskam.
2009-09-24do not call m_free(n0) followed by m_freem(n0) when m_dup_pkthdr()Damien Bergamini
call fails. this double-free was introduced with the M_DUP_PKTHRD to m_dup_pkthdr change that got committed before I had a chance to review it.
2009-09-13M_DUP_PKTHDR() define -> m_dup_pkthdr() function to properly dealKenneth R Westerback
with m_tag_copy_chain() failures. Use m_defrag() to eliminate hand rolled defragging of mbufs and some uses of M_DUP_PKTHDR(). Original diff from thib@, claudio@'s feedback integrated by me. Tests kevlo@ claudio@, "reads ok" blambert@ ok thib@ claudio@, "m_defrag() bits ok" kettenis@
2009-09-12Correctly report copyout() failure in SIOCG80211STATS ioctl; ok damien@ jsg@Miod Vallat
2009-06-06In SIOCS80211SCAN, fail if the interface is not up *and* running.Damien Bergamini
There are cases where the interface can be up but not running, for instance if the driver's if_init routine fails halfway for whatever reason (firmware file not found, hardware switch turned off etc...) This is because in sys/net/if.c, the returned code of the driver is ignored for SIOCSIFFLAGS and the IFF_UP flags is left set. netintro(4) does not say anything about values returned by SIOCSIFFLAGS, so I don't know whether it is the expected behavior or not. pointed out by halex@ and jacekm@ who noticed it was possible to trigger a scan on wpi(4) even when the hardware switch was turned off.
2009-06-03make wireless interfaces priority 4 by default. other interfaces remainBob Beck
priority 0. while we are in here make sure we add wi interfaces to group "wlan" in the same way the net80211 stuff already is. this makes dhcp multiple default routes useful on laptops. ok claudio@
2009-05-24fix prev commit (s/ic_flags/ic_caps/).Damien Bergamini
from dhill@
2009-05-19prevent injection of raw 802.11 control frames through bpf on driversDamien Bergamini
that do not explicitly state this capability (using flag IEEE80211_C_RAWCTL). also, perform all the sanity checks on injected raw 802.11 frames earlier (in ieee80211_output instead of ieee80211_encap). prevent kernel panics with many drivers when running aircrack-ng. when/if all drivers are capable, we can remove this C_RAWCTL flag.
2009-04-16make TKIP TSC start at 1 (instead of 0) to match the standard.Damien Bergamini
many implementations (including ours) will drop frames with a TSC equal to 0 (they are considered replayed frames.)
2009-04-14do not cache the computed TTAK unless MIC has been verified.Damien Bergamini
this prevents an attacker from changing the TTAK (DoS attack) by sending a frame with a large TSC but with a bad ICV and/or MIC. now an attacker can only invalidate the cached TTAK.
2009-03-26move #define IEEE80211_NO_HT under #ifdef SMALL_KERNEL insteadDamien Bergamini
of defining it unconditionnaly. although the HT code is not ready yet, making it compile on GENERIC kernels will help catch regressions/bugs if any.
2009-03-26sync with 802.11w draft 8.0.Damien Bergamini
the SA Query Transaction Identifier field is now a 16-bit non-negative counter value instead of a 128-bit random value.
2009-03-06Fix setting of the Short Slot Time subfield of the Capability InformationDamien Bergamini
field in (Re)Association Requests. This fixes association with APs refusing non-short-slot-time capable STAs. This should also prevent the AP we're associating with to disable the use of short slot time in the BSS as we join. Fix debug message in recv_assoc_resp() while I'm here (s/reason/status/). Scary. Thanks to Adam Emanuel for spotting this.
2009-02-15make "ifconfig if0 chan" list the channels supported by the device.Damien Bergamini
add "ifconfig if0 scan" to scan for access points or to list known stations in Host AP mode. remove the [-]wmm command while i'm here. QoS is mandatory with 802.11n so there's not much point into making it an option. fix parsing of the "powersave" command too. discussed with deraadt@ man page hints from jmc@ display hints from sobrado@ "i like it" cnst@, grange@
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-24 20:05:42 +0000