summaryrefslogtreecommitdiff
path: root/sys/nfs
AgeCommit message (Collapse)Author
2009-06-06Consolidate error handling code. Much less atrocious than before.Bret Lambert
"get it in" thib@
2009-06-06turdshine previousThordur I. Bjornsson
2009-06-05bring back rev1.70Thordur I. Bjornsson
2009-06-05revert to 1.67 to unbreak NFS writes; ok beck@ thib@Christian Weisgerber
2009-06-05- make this a lot more readable; no binary changeJasper Lievisse Adriaanse
ok thib@
2009-06-05EPERM from VOP_ACCESS() is always an error, so don't hide it.Thordur I. Bjornsson
Diff from FreeBSD. OK blambert@
2009-06-04typo; init -> in itBret Lambert
ok thib@
2009-06-04the following:Bret Lambert
error = foo(); if (!error) bar(); is an alien construct; replace with one from this planet ok thib@
2009-06-04Move code that logically belongs together to be together.Bret Lambert
ok thib@
2009-06-04Plug mbuf leaks in the DRC, when we reuse entries we didn'tThordur I. Bjornsson
free the mbufs the entry has (socket name, reply). Found with dlg@'s amazing mbuf debug diff, fix is based on the same thing in NetBSD (by yamt@netbsd.org). OK blambert@
2009-06-04Add some descriptive comments, because not having to read NFS codeBret Lambert
is good for the brain. ok thib@
2009-06-04simplify argument list for nfssvc_nfsd()Bret Lambert
ok thib@
2009-06-04Demacro nfsm_lookup for great justice.Bret Lambert
Thanks to ckuethe for saving much typing with a drive-by perl script. ok thib@
2009-06-03Place code to search for/sleep waiting for an nfs socket into its ownBret Lambert
code; makes the cleaned-up function much more legible. ok thib@
2009-06-03kill some unused defines, don't do an ifndef dance forThordur I. Bjornsson
things that should be defined here and remove a silly comment.
2009-06-03remove cruft that snuck in with previousThordur I. Bjornsson
2009-06-03Lift the NFS over UDP retransmit logic from FreeBSD.Thordur I. Bjornsson
OK blambert@ FreeBSD commit message: Refactor the NFS over UDP retransmit timeout estimation logic to allow the estimator to be more easily tuned and maintained. There should be no functional change except there is now a lower limit on the retransmit timeout to prevent the client from retransmitting faster than the server's disks can fill requests, and an upper limit to prevent the estimator from taking to long to retransmit during a server outage.
2009-06-02give the retransmission count booking keeping a facelift,Thordur I. Bjornsson
just store the maximun amount of rexmits in one place and cleanup. Also make sure this only effects soft mounts. OK blambert@
2009-05-30Remove unused procnums (NQNFS leftovers) and cleanup.Thordur I. Bjornsson
OK blambert@ sometime ago
2009-05-22retire the nfs rtt log code, this isnt really all thatThordur I. Bjornsson
usefull, and has been disabled for a long long time. Cleans house a bit. OK blambert@
2009-05-21IO_METASYNC has been a noop since around 4.4BSD-Lite, theThordur I. Bjornsson
idea never really caught on anywhere so retire it. "gank this shizzle", blambert@
2009-05-15nicer (unique) wmesg for the tsleep(9) in nfs_reconnect();Thordur I. Bjornsson
2009-04-13Convert macros to functions to reduce kernel memory usage.Bret Lambert
In snaps for a while (way too long, according to deraadt@)
2009-03-30Convert a sizeable macro to a much-leaner function. Saves (IIRC) 5k on i386.Bret Lambert
In snaps for a while.
2009-03-19We don't count buffercache stats in the B_PHYS case, so fix nfs to notOwain Ainsworth
increment the num{read,write} and pending{read,write} statistics in that case, since biodone won't change them on completion. On another note, I'm not sure that we use physical buffers for swapping over nfs anymore, so this chunk may be superfluous. beck@ came up with the same diff "So anyway rather than me commiting it from my copy, I'm giving you the OK and the commit. since it officially makes you a buffer cache and NFS hacker };-)"
2009-03-15Introduce splsoftassert(), similar to splassert() but for soft interruptMiod Vallat
levels. This will allow for platforms where soft interrupt levels do not map to real hardware interrupt levels to have soft ipl values overlapping hard ipl values without breaking spl asserts.
2009-02-22fix PR 6082: do not create more fd's than will fit in the message onOtto Moerbeek
the receiving side when passing fd's. ok deraadt@ kettenis@
2009-01-28Remove cur_usec variable that is no longer used.Alexander Bluhm
ok blambert@
2009-01-27Correct my timeradd() thinko in nfsrv_writegather()Bret Lambert
pointed out by bluhm@, "obvious" thib@
2009-01-24oops. forgot to remove a debug printf from the diff.Thordur I. Bjornsson
(that I applied to a clean tree to commit)
2009-01-24Use a timespec for the server write deadline and procrastinationThordur I. Bjornsson
timeouts. Rrids us of the ugly cur_sec variable, and some shadows. Also helps with granularity. Diff from blambert@ who asked me to commit this since he's away for some days and we wanted to put this in with the timespec changes in the nfsnode.
2009-01-24Use a timespec instead of a time_t for the clients nfsnodeThordur I. Bjornsson
mtime, gives us better granularity, helps with cache consistency. Idea lifted from NetBSD. OK blambert@
2009-01-24propagate the O_EXCL flag down to the file systems, by settingThordur I. Bjornsson
VA_EXCLUSIVE. Handle this in NFS, also in NFS use arc4random() for the create verifier instead of an uninitialized long and the address of the first interface (which is likely to be lo0). Lifted from NetBSD with small tweaks; "looks good", miod@ OK blambert@
2009-01-24magic 8 -> nitems(nfs_backoff)Thordur I. Bjornsson
prompted by David <dunnoseriously _att_ gmail.com>
2009-01-24make sure the from mbuf gets freed on error to.Thordur I. Bjornsson
from David <dunnoseriously _att_ gmail.com> ok blambert@
2009-01-22After the NFS server had sent a reply of size readsize or readdirsize,Alexander Bluhm
the udp receive space got completely filled up. Even if the next packet from the server was a small reply, it got dropped by udp_input(). After a second the client resent the NFS request. Doubling rcvreserve reduces the chance of retransmits by having enough recv space for multiple NFS replies even if there comes a big one. found with pedro@, ok blambert@, thib@, pedro@
2009-01-22The variable nfs_reqq was protected by splsoftnet() only in 3 outAlexander Bluhm
of 5 cases. In the functions nfs_reconnect() and nfs_reply() put the TAILQ_FOREACH over nfs_reqq also inside splsoftnet() protection. found with pedro@, ok blambert@, pedro@, thib@
2009-01-20Start reworking NFS client mbuf handling by creating an interface whichBret Lambert
requires well-formed mbuf chains to work. Existing function name is now a wrapper to this interface. Much, much more work to follow which will build on this. Truly change we can believe in. ok thib@, who would have preferred this in two commits, but I'm impatient :) testing on multiple arches (i386, arm, amd64, and sparc64 at least) by many, thanks to all who did so
2009-01-19Introduce a macro to invalidate the attributeThordur I. Bjornsson
cache instead of setting n_attrstamp to 0 directly. Lift the macro name from NetBSD. prompted by and OK blambert@
2009-01-18Remove unused members from struct nfsd.Bret Lambert
ok thib@
2009-01-18remove function which only called nfssvc_iod(), and pass nfssvc_iod()Bret Lambert
to kthread_create() ok thib@
2009-01-18Replace #ifndef DIAGNOSTIC with #ifdef to make the additional checksAlexander Bluhm
in diagnostic kernels. The typo comes from 4.4BSD-Lite2 via NetBSD. Found with pedro@, ok pedro@, blambert@, thib@
2009-01-18add $OpenBSD$ tagThordur I. Bjornsson
2009-01-18Perform the same access enforcements for set attributesThordur I. Bjornsson
as for open/read/write etc, that is assume that the file as already been opened proper, this fixes an ancient ftruncate bug, that is if ftruncate was called on a file with no write modes, we'd return EACCES, this breaks posixy behavior. however, for e.g. truncate() we'll return EACCESS as we should. Diff from PR5880 by mickey. I had forgotten about this PR, and the fix but niklas@ ran into similar issues which prompted another review of this. OK kettenis@
2009-01-18Add nfs ddb hooks, for now only to show all the outstanding nfsreq'sThordur I. Bjornsson
and to print out struct nfsreq. "get it in so people can pound on it" blambert@ OK and information_s_ on the manpage from miod@
2009-01-16turn nfs_msg into void functions, also make it take an nfsreqThordur I. Bjornsson
argument since all of the info we need is there, makes it and the use it a tad bit nicer. ok blambert@
2009-01-15remove prototypes for nonexistent functionsThordur I. Bjornsson
2009-01-13Trivial lvalue abuse fixes, no binary changes.Alexander Yurchenko
ok millert@ tedu@
2008-12-27expand the ifdef _KERNEL around kernel only function prototypesThordur I. Bjornsson
since they have no business being export to userland. OK blambert@
2008-12-24Low hanging macro fruit. Inline the nfsm_srvstrsiz macro sinceThordur I. Bjornsson
its used only once and nuke its definition. Stolen from blambert's bag'o'diffs. OK blambert@.