summaryrefslogtreecommitdiff
path: root/sys/ufs/ffs
AgeCommit message (Collapse)Author
2013-09-14Correct the handling of I/O of >=2^32 bytes and the ktracing there ofPhilip Guenther
by using size_t/ssize_t instead of int/u_int to handle I/O lengths in uiomove(), vn_fsizechk(), and ktrgenio(). Eliminate the always-zero 'error' argument to ktrgenio() at the same time.
2013-08-09Uncomment another kprintf attribute.Sylvestre Gallon
ok miod@.
2013-06-18sqiud -> squidMiod Vallat
2013-06-11final removal of daddr64_t. daddr_t has been 64 bit for a long enoughTheo de Raadt
test period; i think 3 years ago the last bugs fell out. ok otto beck others
2013-06-08KNFBob Beck
2013-05-30UFS does't do inode numbers >2^32, so use a smaller type internally,Philip Guenther
only using ino_t in the VFS layer APIs: vget, readdir, getattr. otto wrote the original diff for libsa to keep bootblock from overflowing ok deraadt@ kettenis@
2013-04-23change ffs layout policy. try to pack meta data in close to the start ofTed Unangst
each cylinder group, which should speed up disk access a little and fsck substantially. adapted from freebsd. for more info: www.mckusick.com/publications/faster_fsck.pdf ok deraadt
2013-04-22ffs2 blockcount is unsigned, so we must check for underflow beforehand.Ted Unangst
from freebsd. ok deraadt guenther otto
2013-04-15Add an f_mntfromspec member to struct statfs, which specifies the name ofJoel Sing
the special provided when the mount was requested. This may be the same as the special that was actually used for the mount (e.g. in the case of a device node) or it may be different (e.g. in the case of a DUID). Whilst here, change f_ctime to a 64 bit type and remove the pointless f_spare members. Compatibility goo courtesy of guenther@ ok krw@ millert@
2013-04-04Fix bug where clear_remove() and clear_inodedeps() would not iterateBob Beck
over the entire pagedep and inodedep hash tables due to an off-by-one mistake in loops. Spotted by and diff from Pedro Martelletto. Sent upstream to Kirk and also fixed in FreeBSD. ok otto@ millert@
2013-02-17Comment out recently added __attribute__((__format__(__kprintf__))) annotationsMiod Vallat
in MI code; gcc 2.95 does not accept such annotation for function pointer declarations, only function prototypes. To be uncommented once gcc 2.95 bites the dust.
2013-02-09Add explicit __attribute__ ((__format__(__kprintf__)))) to the functions andMiod Vallat
function pointer arguments which are {used as,} wrappers around the kernel printf function. No functional change.
2013-01-16re-backout the infamous softdep diff - originally committed to get aroundBob Beck
the problem of the cleaner not being able to get softdep out of trouble due to the removal of a reserve back in vienna. Been run by me for a long time and beat up, along with a bunch of others. Hopefully this nasty piece of workaround can stay out for good now. ok guenther@
2012-12-10Fix potential for use-after-free of bufs in softdep.Bob Beck
Softdep uses it's own "getdirtybuf" which has (always) potentially slept - this wasn't noticable when buffers were static and never freed, however now that the bufs it was trying to busy is might have been written out and freed by someone else we can see use-after free if we fast-recycle buffers. We fix this by either re-trying operations or ensuring we don't use the buf pointer after waiting. ok guenther@ (in coimbra)
2012-09-17fix uninitialized pointer in ffs_write(); ok guenther, beck, deraadtMarkus Friedl
2012-09-10Cleanup VFS mount string handling:Joel Sing
- Avoid using copyinstr() without checking the return value. - sys_mount() has already copied the path in, so pass this to the filesystem mount code so that it does not have to copy it in again. - Avoid copyinstr()/bzero() dance when we can simply bzero() and strlcpy(). ok krw@
2012-07-11If the current offset is strictly less than the process filesizePhilip Guenthe
rlimit, then a write that would take it over the limit should be clamped, making it a partial write. ok beck@
2012-06-10Do NOT make all check condition results report EIO. Only use EIOKenneth R Westerback
when b_error has not already been set to something more informative, e.g. EROFS. DO check the result of ffs_sbupdate() and error out of a mount() call when ffs_sbupdate() reports EROFS while attempting a rw mount. Letting RW mounts proceed regardless of EROFS led to crashes and usb problems for Oliver Seufer while using the RW/RO switches on some usb devices. Fix developed using devices kindly supplied by Oliver & Co. ok miod@
2012-03-23Make rusage totals, itimers, and profile settings per-process insteadPhilip Guenthe
of per-rthread. Handling of per-thread tick and runtime counters inspired by how FreeBSD does it. ok kettenis@
2011-09-18Fix more printf format string bugs in sys/ufs.Alexander Bluhm
ok miod
2011-09-18Make sure daddr64_t values get printed with %lld.Miod Vallat
ok deraadt@
2011-08-17remove the clamping of max_softdeps as it makesThordur I. Bjornsson
softdeps almost totally unusable;
2011-08-16Put back the pedro diff for VOP_FSYNC of softdep when itsThordur I. Bjornsson
limit is reached. Added twist, clamp the max_softdeps to 64 as it is still possible to exhaust bufkva.
2011-08-03back out pedro diff for VOP_FSYNC of softdep when limit is reached.Bob Beck
The basic analysys is correct, however, the problem in this case is that by forcing softdept to synchornously flush everything across *all* softdep filesystems we cause a huge performance problem when we take a 3 second pause and slam everything synchronously. the right way to fix this is to fix the speedup_softdep code, not make the filesystem go synchronous when we hit a limit - if we are doing that we may as well not run softdep it will be faster. ok deraadt@
2011-07-04move the specfs code to a place people can see it; ok guenther thib krwTheo de Raadt
2011-07-04bread does nothing with its ucred argument. remove it. ok matthewTed Unangst
2011-07-03correctify NULL 0 confusionTed Unangst
2011-07-02Getting a disklabel to extract d_secsize to initialize a variable that is thenKenneth R Westerback
re-initialized before use is silly. ffs shouldn't know of or worry about the physical disk sector size. ok thib@
2011-07-02rename VFSDEBUG to VFLCKDEBUG;Thordur I. Bjornsson
prompted by tedu@
2011-06-29ansi softdep, ok deraadtTed Unangst
2011-06-09In ffs_write, do not deref to get the p_ucred for VOP_FSYNC (aka ffs_fsync)Theo de Raadt
when softdep runs out, since it does not use it. In the nfsiod case, that ucred is pointless, and ffs_fsync does not use it in any case. This does not conflict with thib's plans moving forward ok thib
2011-04-12Avoid kvm starvation due to softdeps waiting on too many mapped buffers,Bob Beck
thus possibly consuming all of our available kva mapping buffers for deps. Diff and analysis actually comes from Pedro Martelleto (thanks!) tested by me and thib ok thib@, art@
2011-04-05Every single vop_default is set to eopnotsupp, so retire itThordur I. Bjornsson
and return EOPNOTSUPP directly from the VOP_* functions. Filesystems should, at some point fill in every function in the vop_default struct so we can get rid of the 'if' statements in VOP_*.
2010-12-29remove two unnecessary comments that snuck in with previous.Thordur I. Bjornsson
2010-12-21Bring back the "End the VOP experiment." diff, naddy's issues whereThordur I. Bjornsson
unrelated, and his alpha is much happier now. OK deraadt@
2010-09-10Backout the VOP diff until the issues naddy was seeing on alpha (gcc3)Thordur I. Bjornsson
have been resolved.
2010-09-06End the VOP experiment. Instead of the ridicolusly complicated operationThordur I. Bjornsson
vector setup that has questionable features (that have, as far as I can tell never been used in practice, atleast not in OpenBSD), remove all the gunk and favor a simple struct full of function pointers that get set directly by each of the filesystems. Removes gobs of ugly code and makes things simpler by a magnitude. The only downside of this is that we loose the vnoperate feature so the spec/fifo operations of the filesystems need to be kept in sync with specfs and fifofs, this is no big deal as the API it self is pretty static. Many thanks to armani@ who pulled an earlier version of this diff to current after c2k10 and Gabriel Kihlman on tech@ for testing. Liked by many. "come on, find your balls" deraadt@.
2010-07-23Improve English.Ray Lai
Help by jmc, earlier version OK thib krw
2010-07-13fix overflow of dirsize; from FreeBSD; PR 6426; ok beck@ millert@Otto Moerbeek
2010-06-29remove lies. the arguments are actually used.Thordur I. Bjornsson
2010-06-09Teach FFS mounts about disklabel UIDs. This allows file systems to beJoel Sing
mounted by specifying a disklabel UID followed by a dot and a partition. For example: mount -t ffs 0123456789abcdef.a /mnt ok otto@
2010-05-18dont let sys/ioctl.h imply that you get the ioctls in dkio.h. thisDavid Gwynne
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include <sys/dkio.h> to the places that actually want and use the disk ioctls. this became an issue when krw@'s X build failed when he was testing a change to dkio.h. tested by krw@ help from and ok miod@
2010-03-29Initialize various uninitialized variables. Found by jsg@ via Clang.Kenneth R Westerback
Feedback from miod@ and kettenis@. ok beck@
2010-01-16Remove dead assignment and newly created unused variable.Charles Longeau
Found by LLVM/Clang Static Analyzer. ok tedu@ thib@
2009-12-19Re-introduce the remaining bits of thib@'s Aug 2006 VOP_CLOSE()Kenneth R Westerback
locking fixes. Tweak cd9660 code to be the same as everywhere else, no functional change. ok beck@
2009-09-03- fix two more format strings wrt daddr64_t valuesJasper Lievisse Adriaanse
"sure" deraadt@, ok otto@
2009-08-14- use u_char consistentlyJasper Lievisse Adriaanse
- minor formatting ok oga@ otto@
2009-08-14- fix format string for daddr64_t to %lldJasper Lievisse Adriaanse
ok otto@
2009-08-13- remove super-obvious comments from $fs_vnodeop_entries[]Jasper Lievisse Adriaanse
prodded by and ok thib@ agreed by art@ and blambert@
2009-07-09Remove the VREF() macro and replaces all instances with a call to verf(),Thordur I. Bjornsson
which is exactly what the macro does. Macro's that are nothing more then: #define FUNCTION(arg) function(arg) are almost always pointless and should go away. OK blambert@ Agreed by many.