Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
bread() always
takes DEV_BSIZE address units so don't bother getting the disklabel and trying to
convert units to d_secsize. Nukes last references to d_secsize in ufs/.
ok tedu@
|
|
|
|
the obvious cases to return EINVAL and ENXIO.
ok tedu deraadt
|
|
re-initialized before use is silly. ffs shouldn't know of or worry about the
physical disk sector size.
ok thib@
|
|
prompted by tedu@
|
|
Initial diff from and tested by Luca Corti - thanks!
|
|
|
|
|
|
when softdep runs out, since it does not use it. In the nfsiod case, that
ucred is pointless, and ffs_fsync does not use it in any case.
This does not conflict with thib's plans moving forward
ok thib
|
|
thus possibly consuming all of our available kva mapping buffers for
deps. Diff and analysis actually comes from Pedro Martelleto (thanks!)
tested by me and thib
ok thib@, art@
|
|
and return EOPNOTSUPP directly from the VOP_* functions.
Filesystems should, at some point fill in every function
in the vop_default struct so we can get rid of the 'if'
statements in VOP_*.
|
|
|
|
unrelated, and his alpha is much happier now.
OK deraadt@
|
|
(in case eventually we change their type from u_long to something else),
and do not truncate them to 32 bits in the ntfs code.
ok tedu@
|
|
curproc. A bunch of callers were passing in 0 (not even NULL, 0) as this
pointer, which was fine until the called vnode function tried to do
something with it. Typically, this code was then copy/pasted to various
parts of the tree.
Accept the facts of life and switch all of these over to passing curproc
for now until the argument can be removed.
Discovered by stsp trying to create a softraid on top of a vnd, which
crashed with a NULL deref in vndioctl.
softraid bits tested by mikeb and jsing. raidframe bits tested by pea,
matthieu and naddy. The rest tested by at least thib, jsing and myself.
ok thib@, jsing@.
|
|
/* something */
if (error) {
VOP_UNLOCK();
return;
}
VOP_UNLOCK();
to the clearer and shorter:
VOP_UNLOCK();
if (error)
return;
ok thib@, jsing@ as part of a larger diff.
|
|
have been resolved.
|
|
OK oga@, beck@, matthew@
|
|
vector setup that has questionable features (that have, as far as I can
tell never been used in practice, atleast not in OpenBSD), remove all
the gunk and favor a simple struct full of function pointers that get
set directly by each of the filesystems.
Removes gobs of ugly code and makes things simpler by a magnitude.
The only downside of this is that we loose the vnoperate feature so
the spec/fifo operations of the filesystems need to be kept in sync
with specfs and fifofs, this is no big deal as the API it self is pretty
static.
Many thanks to armani@ who pulled an earlier version of this diff to
current after c2k10 and Gabriel Kihlman on tech@ for testing.
Liked by many. "come on, find your balls" deraadt@.
|
|
bothering to check the mount type when FFS2 support is omitted.
ok krw@, jasper@; "i like it" tedu@
|
|
EFAULT when appropriate.
ok deraadt@, miod@
|
|
Help by jmc, earlier version OK thib krw
|
|
collaborative development by now, Owain
|
|
same thing) with mutexes.
From Gabriel Kihlman (gk AT stacken DOT kth DOT se); thanks!
ok art@ ages ago.
|
|
|
|
|
|
|
|
mounted by specifying a disklabel UID followed by a dot and a partition.
For example:
mount -t ffs 0123456789abcdef.a /mnt
ok otto@
|
|
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.
this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@
|
|
ok deraadt
|
|
I'm actually 99% sure that these locks are right and could be almost
trivially converted to an IPL_NONE mutex protecting the hashtable. Any
takers?
|
|
sysctl.h was reliant on this particular include, and many drivers included
sysctl.h unnecessarily. remove sysctl.h or add proc.h as needed.
ok deraadt
|
|
Feedback from miod@ and kettenis@.
ok beck@
|
|
|
|
Found by LLVM/Clang Static Analyzer.
ok tedu@ thib@
|
|
locking fixes. Tweak cd9660 code to be the same as everywhere else,
no functional change.
ok beck@
|
|
miod@ deraadt@ ok.
|
|
eventhough this won't really harm as ext2fs doesn't handle files that large,
it was not correct.
no objections from thib@
|
|
"sure" deraadt@, ok otto@
|
|
ok tedu@
|
|
as ext2fs doesn't support filesystems so large, it's more correct this way
- fix a format string to %lld for daddr64_t
ok tedu@ thib@
|
|
ok tedu@
|
|
ok otto@
|
|
- minor formatting
ok oga@ otto@
|
|
ok otto@
|
|
prodded by and ok thib@
agreed by art@ and blambert@
|
|
which is exactly what the macro does.
Macro's that are nothing more then:
#define FUNCTION(arg) function(arg)
are almost always pointless and should go away.
OK blambert@
Agreed by many.
|