summaryrefslogtreecommitdiff
path: root/sys/ufs
AgeCommit message (Collapse)Author
2017-12-11Disable DIOCCACHESYNC code, which I believe does the oppositeTheo de Raadt
and can cause pending IO's on wd(4) to be thrown away. Still trying to find a solution.
2017-12-11In uvm Chuck decided backing store would not be allocated proactivelyTheo de Raadt
for blocks re-fetchable from the filesystem. However at reboot time, filesystems are unmounted, and since processes lack backing store they are killed. Since the scheduler is still running, in some cases init is killed... which drops us to ddb [noted by bluhm]. Solution is to convert filesystems to read-only [proposed by kettenis]. The tale follows: sys_reboot() should pass proc * to MD boot() to vfs_shutdown() which completes current IO with vfs_busy VB_WRITE|VB_WAIT, then calls VFS_MOUNT() with MNT_UPDATE | MNT_RDONLY, soon teaching us that *fs_mount() calls a copyin() late... so store the sizes in vfsconflist[] and move the copyin() to sys_mount()... and notice nfs_mount copyin() is size-variant, so kill legacy struct nfs_args3. Next we learn ffs_mount()'s MNT_UPDATE code is sharp and rusty especially wrt softdep, so fix some bugs adn add ~MNT_SOFTDEP to the downgrade. Some vnodes need a little more help, so tie them to &dead_vnops. ffs_mount calling DIOCCACHESYNC is causing a bit of grief still but this issue is seperate and will be dealt with in time. couple hundred reboots by bluhm and myself, advice from guenther and others at the hut
2017-10-26Revert 2006-4-29Z23:09:45 commit that switched from rwlocks to mutexes.Philip Guenther
Use of mutexes there is a WITNESS violation. ok visa@ mpi@
2017-10-10At reboot all vnodes are flushed, but when it sleeps, the updateAlexander Bluhm
process has a chance to create new dirty vnodes. Resolving soft dependencies adds vnodes to the dirty list. In softdep_flushfiles() vnodes and softdeps are flushed in a loop. But if they sleep, it is not guaranteed that all vnodes have been flushed when the softdep worklist flush reports that nothing has to be done. The solution is to do a final vnode flush after the softdep worklist has been flushed. Then the dirty list is empty and the final check in dounmount_leaf() does not panic with "unmount: dangling vnode". OK mikeb@
2017-09-08If you use sys/param.h, you don't need sys/types.hTheo de Raadt
2017-05-30ext2fs: Mark superblock as not modified when writtenStefan Fritsch
I have seen spurious "file system not clean; please fsck(8)" warnings during "mount -ur". Set e2fs_fmod = 0 when writing the superblock (as ffs does). "Makes sense" deraadt@
2017-05-29msdosfs & ffs: flush cache if updating mount from r/w to r/oStefan Fritsch
ok deraadt@
2017-04-20Tweak lock inits to make the system runnable with witness(4)Visa Hankala
on amd64 and i386.
2017-04-19Add sizes to free()David Hill
ok deraadt@ visa@
2017-04-19Add size to free()David Hill
ok deraadt@ visa@
2017-01-10Remove the unused olddp parameter from function dounmount().Alexander Bluhm
OK mpi@ millert@
2016-11-27Fix signedness warnings with careful casts and replace a re-defined variable.Reyk Floeter
(Missed this chunk as part of previous commit to libsa/ufs.c) OK krw@
2016-11-07Split PID from TID, giving processes a PID unrelated to the TID of theirPhilip Guenther
initial thread ok jsing@ kettenis@
2016-10-07Extra parentheses in conditional; no binary change.Martin Natano
from brynet, ok deraadt
2016-10-06On noperm mount points honor the permissions of the root directory, soMartin Natano
access can be locked down. ok deraadt tb
2016-09-15all pools have their ipl set via pool_setipl, so fold it into pool_init.David Gwynne
the ioff argument to pool_init() is unused and has been for many years, so this replaces it with an ipl argument. because the ipl will be set on init we no longer need pool_setipl. most of these changes have been done with coccinelle using the spatch below. cocci sucks at formatting code though, so i fixed that by hand. the manpage and subr_pool.c bits i did myself. ok tedu@ jmatthew@ @ipl@ expression pp; expression ipl; expression s, a, o, f, m, p; @@ -pool_init(pp, s, a, o, f, m, p); -pool_setipl(pp, ipl); +pool_init(pp, s, a, ipl, f, m, p);
2016-09-10Add a noperm mount flag for FFS to be used for building release setsMartin Natano
without root privileges. This is only the kernel/mount flag; additional work in the build Makefile's will be necessary such that the files in $DESTDIR are created with correct permissions. tedu couldn't find anything wrong with it in a quick review idea & ok deraadt
2016-09-08move mfs_pri into tsleep so it's easy to see and it doesn't changeTed Unangst
2016-09-08delete useless comments, such as how KVA is mapped on HPTed Unangst
2016-09-07Remove usermount remnants. ok teduMartin Natano
2016-08-13Missed a couple qaddr_t castsPhilip Guenther
2016-08-10fix previous; ffs_vinit() requires #ifdef _KERNEL to not break theMartin Natano
sbin/fsck_ffs build. bad natano! reported by naddy
2016-08-10ufs_vinit() should really be called ffs_vinit(); it's only called fromMartin Natano
ffs code. ok mpi tedu
2016-08-10ext2fs only has one set of specops/fifoopsMartin Natano
ok mpi tedu
2016-07-14ufs_readdir() buffer was meant to be limited to 64kB; reversed testPhilip Guenther
permitted very big mallocs to panic the kernel. reported by Tim Newsham ok millert@
2016-06-19Remove the lockmgr() API. It is only used by filesystems, where it is aMartin Natano
trivial change to use rrw locks instead. All it needs is LK_* defines for the RW_* flags. tested by naddy and sthen on package building infrastructure input and ok jmc mpi tedu
2016-06-19add pool_setipl on all pools.David Gwynne
ok tedu@ visa@
2016-06-03Unsigned integers can't be negative.Martin Natano
from David Hill and mmcc@ ok stefan
2016-05-23Use arc4random_uniform() instead of arc4random() to avoid modulus bias.Theo Buehler
This eliminates the idiom 'arc4random() % X' (where X + 1 is not a power of two) from base. Part of a patch from Matthew Martin from end of last year. ok tedu@ (a long time ago), natano@
2016-05-23VOP_REALLOCBLKS() and related code is unused since the removal ofMartin Natano
cluster_write(). ok beck zhuk
2016-05-22When pulling an msdos formated umass stick during mount while theAlexander Bluhm
usb stack was busy, the kernel could trigger an uvm fault. There is a race between vop_generic_revoke() and sys_mount() where vgonel() could reset v_specinfo. Then v_specmountpoint is no longer valid. So after sleeping, msdosfs_mountfs() could crash in the error path. The code in the different *_mountfs() functions was inconsistent, implement the same check everywhere. OK krw@ natano@
2016-05-10FFS2 does lazy inode initialization, so try harder to avoid usingKenneth R Westerback
random data on the disk as an inode. Thus avoiding crashes when translating a bogus filehandle to a vnode. Yes, I'm looking at you, NFS! Adapted from a diff by Christos Zoulas via NetBSD, pointed out by kurt@. ok beck@
2016-04-27Pad struct ext2fs out to 1024 (a.k.a. ext2fs SBSIZE) bytes. SatisfiesKenneth R Westerback
assumptions in fsck_ext2fs and eliminates spurious "VALUES IN SUPER BLOCK DISAGREE WITH THOSE IN FIRST ALTERNATE" messages. Part of the problem reported to bugs@ by Lampshade. ok beck@
2016-04-26Populate all necessary statfs members in .vfs_statfs. cd9660, udf,Martin Natano
msdosfs and nfsv2 don't set f_namemax. ntfs and ext2fs don't set f_namemeax and f_favail. fusefs doesn't set f_mntfromspec, f_favail and f_iosize. Also, make all filesystems use copy_statfs_info(), so that all statfs information is filled in correctly for the (sb != &mp->mnt-stat) case. ok stefan
2016-04-07Always call bread_cluster() instead of calling it only if the currentMartin Pieuchot
logical block is contiguous to the previous one. This logic is a left-over of the pre-bread_cluster() area. When the read-ahead version of bread(9) was used to prefetch blocks. Nowadays bread_cluster() do the right thing (tm). ok stefan@
2016-04-03Remove sparc special-casing from ufsdirhash_init(). This is not requiredMartin Natano
anymore since the kernel VM space increase work done in sparc about one year ago. from Miod Vallat; thanks! ok tobiasu
2016-03-27When pulling and unmounting an umass USB stick, the file systemAlexander Bluhm
could end up in an inconsistent state. The fstype dependent mp->mnt_data was NULL, but the general mp was still listed as a valid mount point. Next access to the file system would crash with a NULL pointer dereference. If closing the device fails, the mount point must go away anyway. There is nothing we can do about it. Remove the workaround for the EIO error in the general unmount code, but do not generate any error in the file system specific unmount functions. OK natano@ beck@
2016-03-23remove vax handlingnatano
ok millert
2016-03-19Remove the unused flags argument from VOP_UNLOCK().natano
torture tested on amd64, i386 and macppc ok beck mpi stefan "the change looks right" deraadt
2016-03-17Set mnt_data to NULL after freeing the file system specific mount point.Alexander Bluhm
OK krw@ natano@ as part of a larger diff
2016-03-14Change a bunch of (<blah> *)0 to NULL.Kenneth R Westerback
ok beck@ deraadt@
2016-03-01*** empty log message ***natano
2016-02-27Move mnt_maxsymlink from struct mount to struct ufsmount.natano
The concept of differentiating between "short" and "long" symlinks is specific to ufs/, so it shouldn't creep into the generic fs layer. Inspired by a similar commit to NetBSD. While there replace all references to mnt_maxsymlinklen in ufs/ext2fs with EXT2_MAXSYMLINKLEN, which is the constant max short symlink len for ext2fs. This allows to get rid of some (mnt_maxsymlinklen == 0) checks there, which is always false for ext2fs. input and ok stefan@ ok millert@
2016-02-26Convert mnt_maxsymlinklen to unsigned.natano
This allows to remove some truncating casts in symlink handling code. Also, validate fs_maxsymlinklen in the superblock at mount time and on fsck to make sure we don't use bogus data. discussion & ok millert@, stefan@
2016-02-16Convert to uiomove. From Martin Natano.Stefan Kempf
2016-02-04Prevent signed overflow when calculating i_modrev initial valueMike Belopuhov
Reported and fixed by Martin Natano <natano at natano ! net>, thanks! ok stefan
2016-01-12Kill the "doclusterread" and "doclusterwrite" defines.Martin Pieuchot
They are defined to 0 since the import of ext2fs 19 years ago.
2016-01-12Remove the "doclusterread" and "doclusterwrite" buttons.Martin Pieuchot
Cluster read is unconditionnally enabled for FFS since some years and toggling "doclusterread" has no effect. OpenBSD no longer support write clustering since the Dynamic Buffer Cache went in, so there is reason to delay the call to bawrite(9). Tested by Mathieu, ok dlg@
2015-12-08correct errant spacing here before it continues spreadingTed Unangst
2015-11-28move buffer size adjustment to buf_adjcnt - from Walter NetoBob Beck
ok mpi@
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 16:10:18 +0000