Age | Commit message (Collapse) | Author |
|
Every call to usbd_abort_pipe() on an interrupt pipe would simply
reset the intrxfer pointer, which would prevent usbd_close_pipe()
to free it. Since we abort pipes in a lot of situations: when a
device is detached, when a USB-to-serial adapter is closed, when
an error occurs, when the machine is suspended, etc, this would
result in hundreds of leaked xfers in most of my machines.
xhci(4) is not affected, but you can't enable it right now since
the stack is not ready :)
While here put a KASSERT() to make sure drivers are only calling
the interrupt abort method for intrxfer, if that's not the case,
please let met know.
|
|
|
|
ok mpi
|
|
|
|
|
|
per-driver pool(9) instead.
With inputs from mikeb@
|
|
interface, I suggest you have a look at the link-layer sockaddr
interface:
/*
* A Link-Level Sockaddr may specify the interface in one of two
* ways: either by means of a system-provided index number (computed
* anew and possibly differently on every reboot), or by a human-readable
* string such as "il0" (for managerial convenience).
[...]
*/
ifa_ifwithnet() was not only checking for the sdl_index in order
to get the corresponding ifp for AF_LINK sockaddr, it was also
iterating over all the addresses on your system! But in this
case, the `address' field of "struct sockaddr_dl" is an interface
name set by link_addr(3).
How can this work? Well because the kernel allocates an empty
`netmask' field for each interface's lladdr, so that you can
abuse a network comparison function to reimplement strcmp(3)...
So when the userland does not specify an interface index, try
harder to see if it passed an ifp name, but at least be explicit
and use ifunit().
Found the hard way by/ok sthen@
|
|
ok beck@, miod@
|
|
ok bmercer@
|
|
versus supported sensors table filtering.
discussed with and ok mpi@
|
|
Pointed out by LLVM.
fd.c:1378:29: error: if statement has empty body [-Werror,-Wempty-body]
ok miod@
|
|
ok tedu@
|
|
for hardware to set a ready bit actually delays.
ok krw@ deraadt@ 'sounds correct' miod@
|
|
ok kettenis@
|
|
Since pipe methods have an xfer argument, always use it to get acces to
various data structure (pipe, bus, device) instead of having a different
way to get a pointer to these descriptors in every function.
Also kill the {E,U}XFER() macro and use a consistent name accross all the
methods for {e,u}hci_xfer.
|
|
grab the console.
This makes ddb(4) usable with any simple wired USB keyboard on G3/G4
machines that do not have adb(4) input devices, on G5s and certainly on
some MacBooks too.
ok andre@, miod@
|
|
|
|
to a port, restart the update process to keep things in sync. Domain
controller logins get special handling here because they don't show up in the
list of logged in ports.
|
|
code paths.
ok pirofti@
|
|
moment since we use an intermediate buffer and we specify a length of 0,
there's no need for an exception here.
Noticied while playing with the virtual-mode client interface of firmware.
|
|
|
|
|
|
reads.
Also fix a VA leak in the chunktable read error path.
|
|
do so.
Freeing the hibernate structures too early leads to inadvertent calls into
splx when we aren't ready for them yet. Found when trapping splx calls in
the resume path.
discussed with deraadt@ at m2k14
|
|
|
|
This includes the GeForce GT 740M submitted by Rafael Neves on tech@,
thanks!
|
|
This pointer was only needed by rt_getifa() to find an address, so
turn it into a local variable.
ok henning@, bluhm@
|
|
device of type PMS_STANDARD, probing during autoconf(9) is enough!.
In such case, the device can be a simple PS/2 mouse, a unsupported
touchpad or a downgraded touchpad if something bad happened. But
it is very unlikely that reprobing will improve the situation and
transform a standard mouse into a multitouch-aware touchpad ;)
This fixes the 12 seconds delay seen on various Dell laptops (E4310
and Latitude D630) when starting Xorg, reported by KÄrlis MiÄ·elsons
on bugs@.
ok stsp@, dcoppa@, shadchin@
|
|
ok bmercer@
|
|
This function is used only once in our tree to optimize the size of the
MSS if the forward address correspond to a host on one of our subnets,
but only if ip.mutdisc is disable, which is not the default!
While here get rid of the "#ifdef RTV_MTU", it is here.
ok henning@, mikeb@, bluhm@
|
|
ok mikeb@
|
|
|
|
|
|
and a infaceno argument instead of an iface pointer. While here,
remove some unused functions and inlined usbd_read_report_desc since
it is used only once.
This is part of plumbing required to convert the various USB HID devices
to handle multiples report IDs.
ok andre@
|
|
|
|
|
|
|
|
While there move declaration of divert{,6}_output() to .c as it's a
private function. Also switch first two args to make it more like
similar functions (both suggested by mpi@).
Input/OK mpi@, OK lteo@
|
|
|
|
udp6_output().
ok henning@, reyk@, jca@
|
|
tree. ok henning@
|
|
crazyness only.
|
|
|
|
From Edward O'Callaghan via FreeBSD
|
|
that masks with either 0x7c800000 or 0x7cf00000 depending on the chip.
Some of the hardware revisions I previously added can't be matched with
the current mask, these are already handled by other revision defines
so remove them.
When masking the revision defines with 0x7c800000:
RL_HWREV_8106E_SPIN1 is the same as RL_HWREV_8106E
RL_HWREV_8168G_SPIN1 is the same as RL_HWREV_8168G
RL_HWREV_8168G_SPIN2 is the same as RL_HWREV_8168GU
|
|
from Rafael Neves
|
|
`official' name.
ok jmc@ miod@
|
|
that probably crashed espie.
ok tedu@
|
|
examining higher protocol layers to adjust the checksum and calculate
the pseudo-header in the driver is too complex to be worthwhile.
ok henning@
|
|
ok pelikan@, henning@
|