Age | Commit message (Collapse) | Author |
|
|
|
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
|
|
is already past, the next day is assumed. Handle the case where
we're still in the same hour but the minutes are past.
ok deraadt@ millert@
|
|
|
|
|
|
For AT and BATCH: "stdio rpath wpath cpath fattr getpw unix"
For ATRM: "stdio rpath cpath getpw unix"
For ATQ and CAT: "stdio rpath getpw"
"unix" is needed for poke_daemon() and "fattr" to chmod +x spoolfile.
idea and ok millert
|
|
by group crontab. The at(1) command now creates files owned by
group crontab, the crontab(1) command already does this.
Files in the crontab spool with parse errors are now ignored;
crontab(1) will not install a crontab file with parse errors.
The system crontab file (/etc/crontab) is not affected by this.
The required permissions on crontab files have been tightened.
Files in the cron spool must be mode 0600 (as created by crontab(1)).
The system crontab file may be readable/writable by the owner,
readable by group and readable by other. The system crontab must
be readable by the owner.
|
|
beefier than pointers.
|
|
The only place where this could potentially get used was the
strftime(3) for fprintf(3) "job %s at %s\n" to stderr. We don't
want base system utilities to talk to users in foreign languages.
No functional change on OpenBSD which doesn't provide any non-standard
LC_TIME locale anyway.
Patch from Jan Stary <hans at stare dot cz>.
In main(), exit -> return while here.
OK millert@
|
|
correctly - logically complete that now by removing MLINKS from base;
authors need only to ensure there is an entry in NAME for any function/
util being added. MLINKS will still work, and remain for perl to ease
upgrades;
ok nicm (curses) bcook (ssl)
ok schwarze, who provided a lot of feedback and assistance
ok tb natano jung
|
|
the historic BSD atq which takes a list of users instead of a list
of jobs. We now accept either a user or a job number for "at -l".
The "at -l user" syntax is still accepted but no longer documented.
This is similar to how we handle differences in "at -r" vs. atrm.
OK deraadt@ jmc@
|
|
Remove check_permission and just call allowed() directly.
|
|
|
|
chdir(2) to the cron dir and cron(8) now changes to / via daemon(3).
We no longer try to create/chmod the spool directories as they
should be set correctly at install time. The setegid(crontab)
has been moved to open_socket() so it is closer to the chmod(2)
call that needs it. OK deraadt@ tedu@
|
|
lock the spool dir. OK jca@
|
|
|
|
tm_isdst is set to -1.
|
|
err/errx that unlink atfile as needed. OK deraadt@
|
|
the at queue so we don't need to chdir to the queue dir. OK guenther@
|
|
readability.
|
|
|
|
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@
|
|
An attacker exploiting an overflow can change the egid themselves
so running with the egid of the user in other places just gives you
a false sense of security. OK nicm@ deraadt@
|
|
client.c. Move truly common functions into common.c. This avoids
dead code in the at and crontab commands.
|
|
ok millert
|
|
multiple lines of input, in particular, don't use macros below .Nd;
such bad style can confuse various apropos(1) tools. All deleted
macros reappear later in the text, anyway, except for .Tn, which i'm
deleting outright.
Found while scanning the tree for good and bad practices in preparation
for my EuroBSD2015 mdoc(7) tutorial on Oct 1 in Stockholm.
|
|
ok krw millert
|
|
|
|
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@
|
|
|
|
Replace malloc() and realloc() calls that may have integer overflow in the
multiplication of the arguments with reallocarray().
ok deraadt@
|
|
"export foo=bar" form instead of "foo=bar; export foo" since the
former allows the shell to catch variable names that are not valid
shell identifiers. This will cause /bin/sh to exit with an error
(which gets mailed to the at user) and it will not run the script.
OK miod@
|
|
while here, \*(Gt -> >, per ingo;
|
|
we don;t support next to the posix compat blurb, in order to make things a bit
clearer; this also makes the text more concise;
ok millert schwarze sobrado
|
|
to be passed as command line arguments;
from Jan Stary <hans at stare dot cz>, tweaked by me
|
|
|
|
Also support "months" and "years" keywords when specified as relative
time units. All as per POSIX. Man page changes OK jmc@ sobrado@
|
|
ok sobrado millert
|
|
ok krw
|
|
|
|
of the harder programs to adapt, so let me know if problems happen.
tested by guenther, gilles, chl, others
|
|
ok millert
|
|
|
|
from the touch(1) manpage after much discussion with jmc@ and miller@
|
|
but the century isn't, the century is 1900 if year >= 69; otherwise
it's 2000. (With 32bit time_t, this does't affect any working usage.)
ok millert@
|
|
defines instead of using custom macros. Missed in last commit.
|
|
merge.
|
|
non-standard.
|
|
|
|
|