| Age | Commit message (Collapse) | Author |
|---|
|
ok nickm@ xsa@
|
|
|
|
using lint.
|
|
failing to fdopen() it as readable. It doesn't need to pass in the fd at
all, so just change it to pass -1 which makes cvs init work again.
In fact, the fd should never need to be writable - it is only used for
reading. RCS_WRITE triggers a rewrite on the file on rcs_close() but
this is done by using a temporary and rename(2) (RCS_WRITE is a poor
name for the flag). So while here, add a couple of comments to hopefully
make it a little clearer. There is some confusion about how this is used
in other places but checking those is a separate issue.
with and ok tobias
|
|
in a performance gain in OpenCVS in some "cvs update" scenarios.
ok zinovik
|
|
FILE pointer in RCSFILE. This fixes some ugliness in closing an
fdopen()ed FILE and its underlying file descriptor.
Notified by Joerg Sonnenberger <joerg at britannica dot bec to de>
discussed with and ok nicm
|
|
ok nicm
|
|
- be very strict about things we parse
- print more information about errors if they occur
- do not fatal() directly in parser, give caller a chance to react
- fix an rcs design issue when it comes to login names
tested by many on tech@
ok xsa
|
|
ok nicm, zinovik
|
|
ok ray, zinovik
|
|
OpenRCS.
ok xsa, zinovik
|
|
copy it into a newly allocated one (which is even a memory leak).
ok zinovik
|
|
looping forever.
This prevents the server going into an infinite loop when the repository
is behind the checkout, but the behaviour is not correct (it is an error
rather than ignoring the file), so mark with an XXX for now. Some
underlying OpenCVS functions are too fatal()-happy and will probably
need to be changed in order to fix this properly.
Problem reported by sthen.
ok xsa ray
|
|
cvs/rcs.
OK xsa zinovik
|
|
prefixes to reduce differences between cvs and rcs files.
"yes!" nicm
|
|
as root.
OK nicm
|
|
|
|
symbol/tag names: require the first character to be a letter and
allow any printable character (except the RCS specials $,.:;@)
afterwards. This matches GNU cvs.
ok xsa@ zinovik@ stsp@
|
|
lines, but does exactly the same thing. It also removes unneeded variable
`buf'
ok deraadt@, xsa@
|
|
1. Mostly variable/function renaming, SIZE_T_MAX->SIZE_MAX, and
spacing.
2. One strchr -> strncspn.
3. diff had a weird thing where it set file[12] = ofile[12] but
never updated file or ofile, then if file and ofile were different
it freed it. I removed it.
OK millert
|
|
cvs diff -t now works. There should be no functional change
otherwise.
OK millert
|
|
incendently, commit made using opencvs entirely.
with permission from deraadt@
|
|
ok tobias@
|
|
ok joris
|
|
ok joris
|
|
problem found by todd@, ok sthen@
|
|
for some reason we get interrupted before calling rename().
we hate leaving behind temporary files.
|
|
make the code -Wformat=2 clean. ok joris@ xsa@
|
|
oki joris@
|
|
this gives better information in log messages when the user logged in
with a different uid and used sudo or su to become root. matches the
behaviour of gcvs except that we don't fallback to LOGNAME or USER
since getlogin() should not lie.
ok tobias@
|
|
with various CVS commands.
"seems to make sense" xsa@
|
|
and current OpenCVS code it's possible to change a state in a way that
cannot be fixed with another admin call.
No objections xsa@
|
|
Igor Zinovik - but fixed in a better way by myself.
ok tobias@
|
|
as soon as we are done parsing, since we no longer need it for anything.
|
|
ok joris
|
|
an RCS file which has no head revision set. Some commands actually can
work with them (log, status) so support these files. Fixes A LOT of
possible segmentation faults.
ok joris
|
|
ok joris
|
|
last opened CVS/Entries around to operate on and close it whenever
we switch directory. gives us a small performance boost, obviously.
while doing this, switch the way we write revisions to disk by
using fwrite(3) so stuff can get written to disk in chunks
instead of writing everything line by line, another win.
with help from otto@
ok tobias@
|
|
|
|
gnu cvs supports this and we should too really.
allows opencvs to properly checkout netbsd trees.
spotted & tested by rivo nurges
ok tobias@
|
|
which gives us better performance among other things.
this is however disabled in a few cases:
1) whenever you run checkout over an existing tree (which acts as update)
2) whenever you specify -d or a module alias
we're planning on enabling this behaviour for case 2 in the future.
anoncvs sysadmins now love us even more.
ok tobias@
|
|
reported & tested by phessler@
input otto@ deraadt@
ok tobias@
|
|
|
|
of cvs_buf_append where appropiate.
ok joris
|
|
in (r)annotate and (r)diff.
ok joris
|
|
from Neels Janosch Hofmeyr and Stefan Sperling
|
|
branch entry points in one revision as well as branches which started from
other branches.
ok joris
|
|
ok joris
|
|
|
|
specified head revision.
ok joris
|
