summaryrefslogtreecommitdiff
path: root/usr.bin/cvs
AgeCommit message (Collapse)Author
2006-03-27rcs_desc_set() will never return non-zero; change its return type to void.Xavier Santolaria
OK niallo@.
2006-03-27Plug a memory leak for all cvs_strsplit call sites; ok xsa@Patrick Latifi
2006-03-26rcs_parse_desc() cleanup; OK ray@.Xavier Santolaria
2006-03-25Correct integer types, remove unused arguments, non-portable bitshiftsRay Lai
changed to division, KNF, replace unreachable code with goto fail, et cetera. Found by lint. The free() -> xfree() as well. OK niallo@
2006-03-24change rcs_parse_deltas() and rcs_parse_deltatexts() return valueXavier Santolaria
to void as they never return non-zero. OK ray@.
2006-03-24Remove unused variables, better integer types, prevent fallthroughs.Ray Lai
Found by lint. Compare char * variables against NULL for consistency and add parentheses around complicated comparisons, suggested by xsa@. OK xsa@
2006-03-24Fix RCS_KWEXP_INVAL() macro.Ray Lai
Pointed out by Theo. Okay xsa@.
2006-03-23fetch() will never return non-zero; change its return type to void.Xavier Santolaria
OK niallo@.
2006-03-23use fatal() in rcs_lock_setmode(); OK ray@.Xavier Santolaria
2006-03-23- cvs_buf_putc() will never return non-zeroXavier Santolaria
- change cvs_buf_putc() return type to void OK ray@.
2006-03-23Use TAILQ_HEAD() macro instead of custom struct definition.Ray Lai
From Pierre-Yves Ritschard. OK xsa@
2006-03-20delint; cvs_buf_write_stmp() will never return non-zero:Niall O'Higgins
- remove superfluous error handling for cvs_buf_write_stmp() - change cvs_buf_write_stmp() return type to void ok joris@ xsa@
2006-03-18Change code to match comments, fixing potential off-by-one error.Ray Lai
According to the comments, the lowest number should be 1. not okay, then okay niallo@
2006-03-17- Lint says cvs_hacktime() is not used in rcs, so move it into !RCSPROG.Niall O'Higgins
ok xsa@
2006-03-17rlog_strsplit() -> cvs_strsplit() and move it to util.c so it can be reusedXavier Santolaria
by `cvs log' and some other RCS utilities. "Looks good" ray@.
2006-03-17Use ssize_t in appropriate places.Ray Lai
Found by lint. OK niallo@
2006-03-16zap more unused variables.Xavier Santolaria
2006-03-16add missing {} so everything gets reached.Xavier Santolaria
2006-03-16kill two unused variables.Xavier Santolaria
2006-03-15- remove unused function cvs_putchar()Niall O'Higgins
"well then zap it" joris@
2006-03-15- add util.h, reorganising a bunch of things and exposing cvs_yesno()Niall O'Higgins
function to be used by rcs.
2006-03-15- fchmod file to mode.Niall O'Higgins
ok ray@
2006-03-15bogus idiomTheo de Raadt
2006-03-15no need for one of the volatileTheo de Raadt
2006-03-15- fix typo in comment; an path -> a pathNiall O'Higgins
2006-03-15- make cvs_worklist members volatile.Niall O'Higgins
from deraadt@
2006-03-15remove some bizzare idioms; ok rayTheo de Raadt
2006-03-14add an argument to cvs_diff3() to be able to handle verbosity ofXavier Santolaria
commands; fixes rcsmerge -q behaviour. OK niallo@ ray@.
2006-03-11- implement GNU-compatible handling of revisions specified as singleNiall O'Higgins
digits. e.g. ci -l4 or ci -u5 will work like GNU now. ok joris@
2006-03-11- set RCS_SYNCED on rcs_open() so that if you call rcs_close() immediatelyNiall O'Higgins
it will not write out a blank RCS file if there is no data in the backing structure. ok joris@
2006-03-11Fix rcsnum_tostr() description.Ray Lai
ok joris
2006-03-10fix a stupid mistake in cvs_worklist_clean() while loop.Niall O'Higgins
ok joris@
2006-03-10Only write a log message if the log message is not empty.Ray Lai
Also prevents rfp->rf_desc[-1] from happening. ok joris, niallo, otto, and xsa
2006-03-10make sure cvs_worklist_clean() is safe, since we areJoris Vink
calling it from inside a signal handler. from deraadt@, ok niallo@
2006-03-09trailing spaces;Joris Vink
2006-03-09move joris' timezone support into rcstime.c; more work to be done there.Xavier Santolaria
OK joris@.
2006-03-08make openrcs use the worklist framework to keep track of temporary filesJoris Vink
and remove them in case it gets interrupted. suggested by deraadt@, ok niallo@
2006-03-08add a worklist framework, which will be used for atomic operations onJoris Vink
files. suggested and help by deraadt@
2006-03-08really match gnu on error;Xavier Santolaria
2006-03-08spacingTheo de Raadt
2006-03-07in rcs_write() only do stuff when the RCS file ondisk isn't synced;Joris Vink
niallo agrees;
2006-03-07no need to duplicate error message;Xavier Santolaria
2006-03-07make sure the timezone is valid;Joris Vink
2006-03-07match gnu on error;Joris Vink
2006-03-07-z support for RCS;Joris Vink
2006-03-06like gnu ci(1), continue to process valid files in argv even if some areNiall O'Higgins
invalid. ok xsa@
2006-03-06adapt informative message if we are sending output to stdout.Xavier Santolaria
2006-03-06if the submitted rev(s) is/are the same as the head rev, skip the processXavier Santolaria
for the specified file. Fix some error messages while there. OK joris@
2006-03-05oops, forgot the diff3.c portion of this diff:Niall O'Higgins
fatal() instead of returning -1 on failure in patch functions ed_patch_lines() and rcs_patch_lines(). this can avoid segfault in certain circumstances. From: Ray Lai <ray@cyth.net> discussed with xsa@ and joris@
2006-03-05in rcs_patch_lines(), ensure that rcs patch delete operations don'tNiall O'Higgins
leave the dlp pointing at a non-existant line, but instead point it to the last one in our TAILQ. this fixes an annoying bug in rcs_patch_lines() where dlp would be sometimes set to NULL when really it shouldn't be, resulting in an "invalid line specification in RCS patch" error. ok xsa@ joris@