summaryrefslogtreecommitdiff
path: root/usr.bin/diff/diffreg.c
AgeCommit message (Collapse)Author
2003-10-28prototype declared static, but function was not. add static to function.Anil Madhavapeddy
millert@ otto@ ok
2003-09-07correct ascii file test. ok deraadt@ pb@Ted Unangst
2003-08-13Based on what otto@ said on icb. The expensive thing in diff isTodd C. Miller
newcand() (this is what blows up the memory usage so badly). Instead of counting how many times we go through the loop, count how many times we called newcand(). I renamed loopcount -> numtries since it is no longer the number of loop runs. This fixes espie@'s regression. tedu@ OK
2003-08-08Guess the number of lines in a file and use that number for initialOtto Moerbeek
memory allocation. Initial version by me, cleanup by millert@. ok millert@
2003-07-31- Change the hash function to a simple multiplicative one. The oldOtto Moerbeek
hash function was apparently optimized for 16 bit processors and generates quite some collisions. - Fix another case of excessive reallocing. ok millert@
2003-07-31o correct exit code when comparing stdin and stdin (a noop)Todd C. Miller
o after copying to a temp file, lseek() to the beginning so the inline cmp routine works. Fixes an exit code issue when comparing against stdin.
2003-07-29cleanTheo de Raadt
2003-07-27We need to initialize clen to 0 each time through diffreg() forTodd C. Miller
when diffreg() is called multiple times (i.e. in directory mode). Fixes a hang I saw doing "diff -r" of two large directory trees.
2003-07-27- Use a heuristic to bound memory and cpu usage, at the cost ofOtto Moerbeek
producing suboptimal diffs for large file containing lots of changes. Switch heuristic off with -d/--minimal (GNU compatible). Some hints from millert@. - Improve performance by reducing the number of realloc(3) calls. ok millert@ tedu@
2003-07-23better ascii test for fewer false negatives. ok millert@Ted Unangst
2003-07-22Implement the -L and -T options from GNU diff.Todd C. Miller
2003-07-22Historically, when comparing two directories in -e mode, BSD diffTodd C. Miller
printed a header that turned the output into an actual script that called ed(1) to make the changes. This conflicts with POSIX so the header has been removed and the standard diff header is used instead.
2003-07-22Don't print lines consisting solely of a dot ('.') in -e mode sinceTodd C. Miller
that will confuse ed(1). POSIX says "one way to fix this bug is to output two periods whenever a lone period is needed, then terminate the append command with a period, and then use the substitute command to convert the two periods into one period." This is exactly what I have done.
2003-07-21a little KNFHenning Brauer
2003-07-21POSIX-compliant output when there are two paths w/ the same name butTodd C. Miller
one is a file and the other is a directory in -r mode (cosmetic).
2003-07-21Expand change records array as needed; passes Otto's new regression test.Todd C. Miller
2003-07-17cc -O2 -pipe -DSTDC_HEADERS=1 -DHAVE_UNISTD_H=1 -DDIRENT=1 -DDYN_ALLOC -c ↵Todd C. Miller
unpGet rid of ugly hack in readhash() that appears to be there for machines with a 16 bit word size. Also replace (HALFLONG - 1) with a new define, HASHMASK since it really is a mask. None of this results in any actual change in behavior.
2003-07-16Deal with files that lack a final newline before EOF (you naughtyTodd C. Miller
emacs users!). In most cases this just means checking for EOF in addition to '\n'. However, we need to tread carefully in readhash(). There we return 0 on EOF iff it is the first char in a "line". Additionally, if the -b or -w flags were specified and the last character in one file was '\n' but the other file is missing '\n', pretend that we didn't see the newline in the one file. This is consistent with GNU diff. For the non-{b,w} case, print "\ No newline at end of file" when we see EOF before a newline in one file where the other file has one. Again, this is for consistency with GNU diff and patch(1) in -current knows how to interpret this message. OK tedu@ and otto@
2003-07-15Fix line ranges for unidiffs. Problem noted by otto@Todd C. Miller
2003-07-09Unlink temp file as soon as it is opened and return a FILE * forTodd C. Miller
it so we don't have to worry about cleanup. This means the quit() signal handler and error/errorx can go away too. Move splice() out of diffreg() and into diff.c where it belongs since we don't want to be calling splice() for a directory diff. Add a check for mismatched paths (one file, one dir) in diffreg.c. deraadt@ OK
2003-07-09Re-implement -l flag; diff -l now works correctly in non-directoryTodd C. Miller
mode (like GNU diff).
2003-07-08fix pasto in last commitTodd C. Miller
2003-07-08o Avoid a temp file if using stdin and stdin is redirected from a regular fileTodd C. Miller
o Fix a double free in the temmp file case
2003-07-06Add -q option from GNU diffTodd C. Miller
2003-07-06Some fairly major changes:Todd C. Miller
o -N is implemented o -X is implemented o -x is implemented o diff.c has been rewritten and GNU long options are now supported o diffdir.c has been rewritten + no longer does fork + exec of /usr/bin/diff + can be called recursively (and will be for -r) o diff.h + don't include any .h files here any more, do it in the .c files + no Bell Labs code in this, gets a UCB copyright (the 32v sources only have a diff.c and there is nothing in common). o diffreg.c + most all remaining globals are now private to diffreg.c + files are only opened once + dynamically allocated objects are either freed or realloced + added missing UCB copyright (there were lots of UCB changes) + print correct thing when -s is specified OK deraadt@
2003-07-04Kill diff -h, we don't use or want diffh. Discussed w/ tedu@Todd C. Miller
2003-07-04Some cosmetic fixes:Todd C. Miller
o get rid of now-unused tempfile variable o move inifdef into diffreg.c (only used there) o correct a comment o use _PATH_DIFF, _PATH_DIFFH and _PATH_PR instead of variables set to them o get rid of hack to look for pr and diff in /bin
2003-07-02Treat /dev/null specially; there is no need to make a temp file for it.Todd C. Miller
2003-06-27-a to force ascii compare. ok millertTed Unangst
2003-06-26Remove cruft; We don't have the -I, -1 or -2 options anymore so we don'tTodd C. Miller
need the associated scaffolding. tedu@ OK
2003-06-26Fix temp file handling.Todd C. Miller
o honor TMPDIR environment variable as per man page o need 2 temp files if both file1 and file2 are devices o add error() and errorx() which cleanup temp file and then call err() and errx() respectively. OK tedu@
2003-06-26Fix temp file handling and deal with the case where we might need 2 temp files.Todd C. Miller
2003-06-26off by one in size calculationVincent Labrecque
ok tedu
2003-06-25fix unified diff output. ok millert@Ted Unangst
2003-06-25Add unidiff support and try to pretty up usage() a bitTodd C. Miller
2003-06-25o use S_ISDIR instead of doing it by handTodd C. Miller
o rename talloc -> emalloc and ralloc -> erealloc o struct direct -> struct dirent (POSIX) o kill remaining strcpy() o fix unterminated string in setfile() deraadt@ OK
2003-06-25o use getopt()Todd C. Miller
o use err/warn o only call done() when needed (after mkstemp) o add "-C lines" like GNU grep OK deraadt@
2003-06-25remove silly signal catcher, and just use done. ok deraadt@Ted Unangst
2003-06-25oopsTheo de Raadt
2003-06-25use SEEK_SET with fseek()Theo de Raadt
2003-06-25more knfTheo de Raadt
2003-06-25index -> strrchrTheo de Raadt
2003-06-25knfTheo de Raadt
2003-06-25remove unused variableTed Unangst
2003-06-25-Wstrict-prototypesTed Unangst
2003-06-25avoid signed issues; tedu okTheo de Raadt
2003-06-25exit path signal race safeTheo de Raadt
2003-06-25more cast removal, and fix some indent(1) odditiesTed Unangst
2003-06-25cleanup. ansi, headers, correct prototypes, some safer string andTed Unangst
tempfile functions, whitespace, ... no functional improvements yet
2003-06-25caldera licensesTheo de Raadt