summaryrefslogtreecommitdiff
path: root/usr.bin/finger
AgeCommit message (Collapse)Author
2019-07-03snprintf/vsnprintf return < 0 on error, rather than -1.Theo de Raadt
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2018-06-17use size_tTheo de Raadt
2018-06-17incorrect pointer used, hence gecos expansion was ignoredTheo de Raadt
ok millert
2018-04-26Use <fcntl.h> instead of <sys/file.h> for open() and friends.Philip Guenther
Delete a bunch of unnecessary #includes and sort to match style(9) while doing the above cleanup. ok deraadt@ krw@
2015-12-26Use pread/pwrite instead separate lseek+read/write for lastlog.Philip Guenther
Cast to off_t before multiplication to avoid truncation on ILP32 ok kettenis@ mmcc@
2015-11-03Blank line after pledge call.mmcc
2015-10-26Rather than setpassent(1) for the lifetime of the program, use two smallerTheo de Raadt
windows of setpassent(1) + entpwent() ok tedu millert
2015-10-18Add "dns" to the pledges. Previously these worked because of "inet",Theo de Raadt
alas "dns" is now a mandatory statement if you want to do dns!
2015-10-10normalize a few more tame request orderings, to help reviewTheo de Raadt
2015-10-09Change all tame callers to namechange to pledge(2).Theo de Raadt
2015-10-03finger can either do local users only, or in in remote users. (whoTheo de Raadt
still runs fingerd? not many places, it took a while to find a server) tame "stdio getpw rpath inet" is possible early on, then later when the network lookups list is consumed, tame "stddio getpw rpath"
2015-08-20Do not cast result of malloc/calloc/realloc* if stdlib.h is in scopeTheo de Raadt
ok krw millert
2015-03-15tzfile.h is an internal header that should never have been installed.Todd C. Miller
What's worse, the tzfile.h that gets installed is over 20 years old and doesn't match the real tzfile.h in libc/time. This makes the tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE define has been moved to time.h temporarily until its usage is replaced by 1900 in the tree. Actual removal of tzfile.h is pending a ports build. Based on a diff from deraadt@
2015-01-19Make some $OpenBSD$ lines prettier/standardier by eliminatingKenneth R Westerback
superflous '*' after '/*' and adding blank after terminating '$'. Also eases parsing of the lines by simple awk scripts. Aesthetic approval from tedu@.
2015-01-16Replace <sys/param.h> with <limits.h> and other less dirty headers whereTheo de Raadt
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
2014-11-19Use stravis() instead of a custom() strvis + mallocarray wrapper.Todd C. Miller
OK tedu@ tobias@
2014-11-18Nuke more obvious #include duplications.Kenneth R Westerback
ok deraadt@ millert@ tedu@
2014-10-17Instead of doing strvis() of gecos string on output, do it whenTodd C. Miller
storing them in struct person since they are only used for output. Uses reallocarray() for overflow detection. OK deraadt@
2014-10-17Use strlcpy() instead of strncpy() when making a copy of pw_gecos.Todd C. Miller
2014-10-17strvis() requires that the buffer is at least 4 * srclen + 1.Doug Hogan
ok deraadt@
2013-11-26unsigned char casts for ctypeTheo de Raadt
ok krw
2013-11-14Add STANDARDS section to finger(1)/fingerd(8).Anthony J. Bentley
tweaks/ok jmc@
2012-01-15Document what remains of the 2BSD heritage.Ingo Schwarze
All facts found on the CSRG CD 1 in the 2bsd directory. Feedback and ok jmc@, ok sobrado@. Note the large number of 3BSD -> 2BSD changes. Kirk McKusick asked Cynthia Livingston (cael@, of USENIX, who converted most manuals from man(7) to mdoc(7) for the 4.3BSD-Net/2 release and added lots of historical information around that time) what happened in this respect, and she answered that she often wrote "appeared in 3BSD" when she was unsure of when a utility was added. Thanks to Kirk and Cynthia for that clarification.
2009-11-12Fix memory leak found by parfait.Nicholas Marriott
ok deraadt
2009-10-28rcsid[] and sccsid[] and copyright[] are essentially unmaintained (andTheo de Raadt
unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms
2007-09-02use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsgTheo de Raadt
2007-05-31convert to new .Dd format;Jason McIntyre
2006-01-23Include <sys/param.h> instead of <sys/types.h> so we get MAXHOSTNAMELENTodd C. Miller
2005-08-23use vis() consistently in field printing.Marc Espie
Replace vs() with a version that logs its memory usage, so that it can be cleaned up after each entry. okay millert@, delegated by deraadt@
2005-03-15change some silly snprintf(buf, buflen, "%s", login) calls to just useNiall O'Higgins
strlcpy(buf, login, buflen) ok otto@ henning@
2004-03-15Wall, commons, little knfTed Unangst
2003-10-17slight update for finger; sort optionsJason McIntyre
2003-07-10add missing includesDavid Krause
ok deraadt@ tedu@
2003-07-02protosTheo de Raadt
2003-06-25delete junk protosTheo de Raadt
2003-06-10mostly ansi cleanup; pval okTheo de Raadt
2003-06-03Remove the advertising clause in the UCB license which BerkeleyTodd C. Miller
rescinded 22 July 1999. Proofed by myself and Theo.
2003-03-13a few more strlcpyTheo de Raadt
2002-02-16Part one of userland __P removal. Done with a simple regexp with some minor ↵Todd C. Miller
hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
2001-11-19kill more registersMike Pechkin
millert@ ok
2001-07-12first pass at a -Wall cleanupTheo de Raadt
2001-07-04ugly bug that lived; santana@openbsd.org.mxTheo de Raadt
2001-01-31constrain to 8 character login prints, unless longer, for nowTheo de Raadt
2001-01-15typoTheo de Raadt
2001-01-15oopsTheo de Raadt
2001-01-10error out for strdup() failuresTheo de Raadt
2000-11-09Change all option list specifications to ".Bl -tag -width Ds". Most manAaron Campbell
pages just needed their -width parameter tweaked to "Ds", which provides a nice width of 6 constant characters. For consistency more than anything.
2000-06-30warnx?/errx? paranoia (use "%s" not a bare string unless it is aTodd C. Miller
constant). These are not security holes but it is worth fixing them anyway both for robustness and so folks looking for examples in the tree are not misled into doing something potentially dangerous. Furthermore, it is a bad idea to assume that pathnames will not include '%' in them and that error routines don't return strings with '%' in them (especially in light of the possibility of locales).
2000-03-07Various cleanup.Aaron Campbell