summaryrefslogtreecommitdiff
path: root/usr.bin/ftp
AgeCommit message (Collapse)Author
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-06-28mkstemp() returns -1 on failureTheo de Raadt
2019-05-16Revert suni'ls ftp rewrite for now.Florian Obser
We are juggling too many things at the moment and we can't deal with the differences in behaviour right now.
2019-05-15Display "bytes received" like the csrg ftp used to when the progressbarFlorian Obser
is disabled. Difference pointed out by deraadt OK kurtm, sunil
2019-05-15Add the -m flag to the ftp.1 man page.kmos
Adjust the usage message of ftp(1) to reflect its two operating modes and list missing flags. OK florian@ jmc@
2019-05-14do not intermingle direct io (write), and potentially buffered io (stdio)Theo de Raadt
against the same outputs ok kmos florian
2019-05-14Document -vFlorian Obser
2019-05-14-v forces verbose mode even if stdin is not a terminalFlorian Obser
Found the hard way by bluhm Debugged with deraadt & bluhm
2019-05-14Enable TLSv1.0 and TLSv1.1Jeremie Courreges-Anglas
Like the old ftp. Discussed with at least with tedu@ "We should match existing behavior at least for now"
2019-05-14Remove an unused and leftover label.Sunil Nimmagadda
2019-05-14tls_write(3): Handle short writes.Sunil Nimmagadda
Ok jca@
2019-05-13ephermal -> ephemeralTheo Buehler
From Hiltjo Posthuma
2019-05-12Fix double free by nulling out pointers after free.Theo Buehler
from florian, ok jca
2019-05-12Make the "xx bytes received in y time" message go to the right placekmos
by using the login_info() function the other messages use. OK florian@
2019-05-12zap confusing unneeded parametersMarc Espie
okay jca@, jasper@
2019-05-12Repair ftp -o - and thus pkg_add: print informational messages on stderrJeremie Courreges-Anglas
ok florian@ espie@
2019-05-12It will show up in 6.6.Florian Obser
2019-05-12add rcs idsJasper Lievisse Adriaanse
2019-05-12Move us from old ftp(1) to Sunil's new ftp(1). The necessary modificationskmos
have been made to make it behave. Any new misbehaviors can be fixed in tree. OK florian@ deraadt@ "Have you committed ftp yet?"
2019-05-09ftp makes a new connection for each auto-fetch file. Remove a lie claimingChristian Weisgerber
otherwise. ok tb@ tedu@
2018-02-10Add TLS session support to ftp(1).Joel Sing
If a session file is specified via the `-S session=...', ftp(1) will attempt to resume TLS sessions based on the session data contained within this file. Upon completion of a successful TLS handshake the session file will be updated with new session data, if available. Discussed with deraadt@ and beck@. Requested by and input from espie@.
2018-02-07rename var 's' -> 'fd' to ease finding it in a long functionRichard Procter
ok tb@ deraadt@
2018-02-07eliminate close()/fclose() dance.Richard Procter
ok tb@ deraadt@
2018-01-24Use closefrom(3) instead of manually closing all file descriptorsTheo Buehler
between 3 and 19. ok martijn, millert, jca
2017-12-23Use the monotonic clock for logging progress in cdio(1) and ftp(1).cheloha
Keeps the progress log from blipping or stalling if, e.g., the system time is changed in the midst of a rip or a transfer. ok tb@ jca@
2017-09-25Initialize 'out' file descriptor to avoid possibleKenneth R Westerback
uninitialized use. Spotted by clang during 'make release', triggered when both NOSSL and SMALL are defined. ok bluhm@ deraadt@
2017-09-05Avoid a possible leak in progressmeterJeremie Courreges-Anglas
From Scott Cheloha, ok bluhm@
2017-08-01Remove self assignment.anton
ok deraadt@
2017-03-07tls_close() can return TLS_WANT_POLLIN/TLS_WANT_POLLOUT, handle themSunil Nimmagadda
appropriately. Ok jca@
2017-03-02close ftp(1)'s output file to avoid leaking one FD per request.Stuart Henderson
ok deraadt
2017-02-28Use a do{}while loop with ssize_t return value when calling tls_read()Philip Guenther
problem noted by and ok jsg@
2017-01-25cetificate -> certificate;Jason McIntyre
2017-01-24Add -S noverifytime to ftp to permit an unvalidated TLS connection whenBob Beck
you don't knwo what time it is
2017-01-21Nuke whitespace foolish enough to expose itself during the greatKenneth R Westerback
"warning:" rectification.
2017-01-20Move a couple of variables that are unused in SMALL under #ifndef SMALL.Kenneth R Westerback
ok deraadt@
2017-01-20Straggling __dead. Mark usage() as __dead and make gcc happier.Kenneth R Westerback
2017-01-20#ifndef SMALL around a couple of non-SMALL labels.Kenneth R Westerback
ok deraadt@
2017-01-14HTTPS proxy support for ftp-ssl.Jeremie Courreges-Anglas
The install media already allow for plaintext HTTP proxying. The code to support CONNECT is short enough. Reported/fix tested by rpe@, ok deraadt@
2017-01-11Don't attempt to read .netrc when we already force anonymous FTP (-a).Vadim Zhukov
Patch from Anton Lindqvist via tech@, thanks! okay deraadt@
2017-01-10Pledge more strictly. This is only enabled on the ramdisk version of theTheo de Raadt
ftp(1) client, which operates only in URL mode. Not willing to spend the time tracking piles of global variables for sub-modes, and finding all the pledge interactions. Would rather have the install media ftp(1) as safe as possible, immediately. ok tb jca
2017-01-07-#endif /* !SMALL */Theo Buehler
+#endif /* !NOSSL */
2017-01-03Add a "-w connect_timeout" option in support of URL-fetching. This allowsTheo de Raadt
slow / failing connects to be identified. The install script needs this functionaly. ok jca rpe millert
2016-12-28Split -DSMALL into -DNOSSL, so that a SSL-enabled version of ftp canTheo de Raadt
be built, which is still pretty small (in distrib/special/ftp-ssl). Lots of testing by rpe.
2016-12-24Correctly handle tls_read()/tls_write().Joel Sing
In one tls_read() case, we failed to check for WANT_{POLLIN,POLLOUT}, so fix that. In the same tls_read() case and the tls_write() case we fail to handle errors correctly, which means that error is not reported and can be lost by a futher libtls call. ok beck@ jca@
2016-12-22missing full stop;Jason McIntyre
2016-12-22add muststaple option so that oscp stapling can be required for sites youBob Beck
expect to provide it. ok jsing@
2016-12-16Eliminate some gcc warnings about 'unused variables', mostly byKenneth R Westerback
adding appropriate #ifdef's around declarations. ok millert@ (with a tweak I will commit separately)
2016-12-08Avoid splitting the "Requesting %s" printf and its trailing newline.Todd C. Miller
Fixes a missing newline in one place and an extra one later on when both debug and verbose are set.
2016-12-08Avoid printf of a NULL pointer as a string in debug mode.Todd C. Miller
OK deraadt@
2016-11-30Check return value of tls_config_set_protocols(3) and bail out in case ofRicardo Mestre
failure Feedback and OK jsing@