summaryrefslogtreecommitdiff
path: root/usr.bin/ftp
AgeCommit message (Collapse)Author
2015-03-17Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@Todd C. Miller
2015-03-15tzfile.h is an internal header that should never have been installed.Todd C. Miller
What's worse, the tzfile.h that gets installed is over 20 years old and doesn't match the real tzfile.h in libc/time. This makes the tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE define has been moved to time.h temporarily until its usage is replaced by 1900 in the tree. Actual removal of tzfile.h is pending a ports build. Based on a diff from deraadt@
2015-03-13remove the first comma from constructs like ", and," and ", or,": you can useJason McIntyre
"and" and "or" to join sentence clauses, and you can use commas, but both hinders reading;
2015-02-27Fix URL-encoding of characters with the high order bit set.Jeremie Courreges-Anglas
Before/after: 127.0.0.1 - - [25/Feb/2015:09:39:24 +0100] "GET /h%ff%ffh%ff%ff.dat HTTP/1.0" 404 162 "-" "OpenBSD ftp" 127.0.0.1 - - [25/Feb/2015:09:39:27 +0100] "GET /h%c3%a9h%c3%a9.dat HTTP/1.0" 200 0 "-" "OpenBSD ftp" Additionnally, avoid one case of undefined behaviour with ctype.h. Input from guenther@, ok millert@
2015-02-22Rename tls_config_insecure_noverifyhost() toJoel Sing
tls_config_insecure_noverifyname(), so that it is more accurate and keeps inline with the distinction between DNS hostname and server name. Requested by tedu@ during s2k15.
2015-02-22Set the TLS ciphers to "compat" mode, restoring the previous behaviour.Joel Sing
2015-02-17add -M to disable progressmeter. ok dlg halex millertTed Unangst
2015-02-13Call tls_config earlier; otherwise TLS_PROTOCOLS_ALL (to allow TLSv1.0 etc)Stuart Henderson
was only called if -S was used. Fixes TLSv1.0/1.1. Problem reported by nigel@, ok jsing
2015-02-12Change TLS_PROTOCOLS_DEFAULT to be TLSv1.2 only. Add a TLS_PROTOCOLS_ALLJoel Sing
that includes all currently supported protocols (TLSv1.0, TLSv1.1 and TLSv1.2). Change all users of libtls to use TLS_PROTOCOLS_ALL so that they maintain existing behaviour. Discussed with tedu@ and reyk@.
2015-02-09various defines always exist, so delete the ifdef test.Ted Unangst
the socks support seems to be dead, since there are no other references. also, redeclaring a standard function? that's a no-no. custom compiles with gate-ftp servers don't need to be supported either. ok deraadt
2015-02-09remove the safeguard against porting to machines without 8 bit bytes.Ted Unangst
allows removing sys/param.h include as well.
2015-01-31removing two instances of "c.f." - it seems actually "cf." is correct, butJason McIntyre
i removed/reworded these as in the case of ftp.1 it read badly anyway, and for fstat.1 it meant i could zap an escape sequence; while here i replaced some sequences of <space><tab> where a single <tab> was sufficient;
2015-01-30remove tenex transfer support. if you still have TOPS20 machines inTed Unangst
service, you'll need to stick with openbsd 5.6. bonus: remove references to ebcdic. ok deraadt
2015-01-16Replace <sys/param.h> with <limits.h> and other less dirty headers whereTheo de Raadt
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
2015-01-12Fetching port distfiles with the ftp command from githup did notAlexander Bluhm
work when using a https proxy because of a missing host header. Remember the host form the url and write it into the http request. Fix the format string when using Proxy-Authorization together with Cookie. Also write the http request to the debugging output to see what is going on. input jca@; OK sthen@ mpi@
2014-11-25set ttyout to line buffered, because the signal handler writes areTheo de Raadt
non-buffered. They were getting out of order. from Kaspars Bankovskis, discussion included millert
2014-11-15Reduce instances of `` '' in manuals.Anthony J. Bentley
troff displays these as typographic quotes, but nroff implementations almost always print them literally, which rarely has the intended effect with modern fonts, even in stock xterm. These uses of `` '' can be replaced either with more semantic alternatives or with Dq, which prints typographic quotes in a UTF-8 locale (but will automatically fall back to `` '' in an ASCII locale). improvements and ok schwarze@
2014-10-31Update ftp(1) to use libtls instead of libressl.Joel Sing
2014-10-30use ressl constant; from Jan KlemkowTed Unangst
2014-10-24Remove unnecessary include: netinet/in_systm.h is not needed by theseLawrence Teo
programs. ok deraadt@ millert@
2014-10-08userland reallocarray audit.Doug Hogan
Replace malloc() and realloc() calls that may have integer overflow in the multiplication of the arguments with reallocarray(). ok deraadt@
2014-10-06Amend previous commit to unbreak TLS cert validation when using a proxy.Jeremie Courreges-Anglas
ok miod@
2014-10-04Be sure to only path the remote host to ressl_connect_socket(), without aMiod Vallat
possible :portnumber suffix. Noticed by ajacoutot@ ok ajacoutot@ deraadt@
2014-10-03update for new ressl noverify APITed Unangst
2014-10-03Update ftp ressl configuration to handle recent changes in the library.Joel Sing
2014-08-25you broke the ramdisk builds...Theo de Raadt
2014-08-25When using a proxy for an https connection, validate the cert hostnameJeremie Courreges-Anglas
against the target hostname, not the proxy hostname. Issue reported by dlg@, fix by Alex Wilson on tech@, tweaks by me. No reply from tech@
2014-08-21Fix double free. ok guenther@Jeremie Courreges-Anglas
2014-08-16I found a number of interactive events which can cause signals, and goTheo de Raadt
down paths not previously marked as signal handled unsafe. Try to clean up a few of them especially regarding errno, mark others as unsafe, and repair a few by avoiding stdio. Glanced at by misc people in Slovenia, but considered too risky before release..
2014-07-16Clean up the ifdef maze in usage() by reformatting it to have distinctLawrence Teo
!SMALL and SMALL sections. This makes future changes easier to review and to compare with the man page's synopsis. The usage output is the same as before so there is no change from the user's point of view. usage() cleanup and !SMALL/SMALL separation suggested by jmc@ ok jmc@
2014-07-14Convert ftp(1) to libressl, rather than rolling in^W^Whand rolling libssl.Joel Sing
ok beck@ deraadt@
2014-07-14Repair handling of ^C and ^D around command prompts, by insertingTheo de Raadt
correct newlines. Of course, that means removing stdio use from signal handlers. Can we find someone to rewrite the entire interactive half of this program? ok guenther
2014-07-11simplify and slightly tweak user agent handlingAlexander Hall
ok lteo@
2014-07-11Allow ftp(1) to change its User-Agent for HTTP(S) URL requests using aLawrence Teo
-U command-line option. feedback from deraadt@, halex@, and Adam Thompson ok deraadt@ sthen@, man page changes ok jmc@
2014-07-05Given an http or https URL with user and password, URL-decode the userPhilip Guenther
and password info before base64 encoding it for the Authorization header. Also: - eliminate the COOKIE_MAX_LEN constant (if they can fit it on the command line or in their environment, surely we can malloc the base64 version) - rename the variable with user:pass from "cookie" to "credentials" - empty password isn't an error - add a boolean ishttpurl so that we don't have to do strcmps on the schema that we just set - when looping across multiple ftp:// urls on the command line, don't leak the username/password memory problem noted by Se'bastien Marie (semarie-openbsd (at) latrappe.fr)
2014-06-25Alexander Schrijver posted a diff to remove references to the c_rehash script,Jason McIntyre
which we don;t have in base. after some discussion with jca, i've not removed these references, but tried to make it clearer it's distributed with openssl and not included in base;
2014-05-20Use errc/warnc to simplify code.Philip Guenther
Also, in 'ftp', always put the error message last, after the hostname/ipaddr. ok jsing@ krw@ millert@
2014-05-19X509_free() the certificate if the server hostname check fails.Jeremie Courreges-Anglas
No functional change. Reported by Mike Small and Maxime Villard.
2014-05-19Explicitely initialize two static variables introduced in the previousJeremie Courreges-Anglas
commit, to please lteo@
2014-05-19HTTPS connections may see redirects, so initialize libcrypto and libsslJeremie Courreges-Anglas
only once, and reuse the crafted SSL_CTX for further connections. ok lteo@
2014-04-23Kill useless assignement, matchlen is initialized two lines below.Jeremie Courreges-Anglas
From Fritjof Bornebusch.
2014-04-22remove dead stores to error. from Fritjof BornebuschTed Unangst
2014-04-09If TLS validation is on, retrieve the server TLS certificate andJeremie Courreges-Anglas
check the server hostname against the subjectAltName extension field and/or the CommonName DN portion. ok sthen@
2014-03-30SNI support. ok guenther@ sthen@Jeremie Courreges-Anglas
2014-03-30Check the return value from SSL_CTX_set_cipher_list(), for consistency.Jeremie Courreges-Anglas
ok guenther@ sthen@
2014-03-30SSLeay_add_ssl_algorithms() is just a #define for SSL_library_init(), soJeremie Courreges-Anglas
kill the former. ok guenther@ sthen@
2014-03-02only signed types work when comparing less than zero.Ted Unangst
reported by matthieu. ok deraadt
2014-02-26use a larger read buffer to speed things up, particularly during upgrades.Ted Unangst
ok deraadt
2014-01-29Unbreak ftp progress meter after the introduction of the '-D' flagDavid Coppa
ok tedu@
2014-01-23tweak previous;Jason McIntyre