| Age | Commit message (Collapse) | Author |
|---|
|
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.
|
|
|
|
|
|
Nothing of what it did is allowed in an interrupt handler.
Rather, just mark that an interrupt occurred, and check for interrupts
in the wait of RunCommand (that's the correct point to check for interrupts
anyways).
Okay miod@, millert@ approves (as he's too tired to look at the code)
|
|
implicit (suffix) rules. Then, only expand the IMPSRC/< variable
if the node has been marked.
This matches what Single Unix 2 and common sense say: implicit rules
shouldn't count when an explicit rule has been found (an explicit rule
being a full-scale dependency, with some associated commands)
Note that Single Unix leaves the `PREFIX' question open, so we leave
the PREFIX code as it is.
This fixes regression case mk14, which now fails as it should.
This is just a bug-fix. Some more correct (and faster) code should
probably be substituted. Namely, right now, the suffix code is too
greedy, whereas it should test for explicit rules earlier, and not
even bother instantiating implicit rules from templates when they
duplicate actual existing rules.
ok millert@
|
|
|
|
|
|
initialize create in main.c.
|
|
|
|
pointers is simpler than calling a function.
Recognize purely static lst headers, which don't really need any
initialization.
ok miod@
|
|
idea from deraadt@ via NetBSD
millert@ ok
p.s. Next commit will fix a typo in the sys/
|
|
|
|
|
|
Even though the code can share some common parts, there is an important
difference I had missed.
|
|
|
|
POSIX counterparts.
|
|
o) fix bogus .Xr usage;
millert@ ok.
|
|
|
|
Turns out that current is NULL when Parse_Fatal is called in this case,
so just do something sensible in error reporting functions when current is
NULL...
|
|
|
|
|
|
5% speed increase on a make build.
ok miod@
|
|
(__attribute((__unused__)) denotes parameters that MAY be unused in the
code, e.g., it's mostly a `shut up warnings' device).
|
|
|
|
Replace MAXPATHLEN with PATH_MAX (synch with op-make).
ok naddy@
|
|
Don't bother cleaning it up for speed
|
|
|
|
|
|
This is temporary, this code needs better fixes.
|
|
Removes remaining lint stuff from lst.lib.
|
|
|
|
of missing function declarations.
|
|
|
|
- cut up those huge include files into separate interfaces for all modules.
Put the interface documentation there, and not with the implementation.
- light-weight includes for needed concrete types (lst_t.h, timestamp_t.h).
- cut out some more logically separate parts: cmd_exec, varname, parsevar,
timestamp.
- put all error handling functions together, so that we will be able to
clean them up.
- more systematic naming: functioni to handle interval, function to handle
string.
- put the init/end code apart to minimize coupling.
- kill weird types like ReturnStatus and Boolean. Use standard bool (with a
fallback for non-iso systems)
- better interface documentation for lots of subsystems.
As a result, make compilation goes somewhat faster (5%, even considering
the largish BSD copyrights to read). The corresponding preprocessed
source goes down from 1,5M to 1M.
A few minor code changes as well: Parse_DoVar is no longer destructive.
Parse_IsVar functionality is folded into Parse_DoVar (as it knows what an
assignment is), a few more interval handling functions. Avoid calling
XXX_End when they do nothing, just #define XXX_End to nothing.
Parse_DoVar is slightly more general: it will handle compound assignments
as long as they make sense, e.g., VAR +!= cmd
will work. As a side effect, VAR++=value now triggers an error
(two + in assignment).
- this stuff doesn't occur in portable Makefiles.
- writing VAR++ = value or VAR+ +=value disambiguates it.
- this is a good thing, it uncovered a bug in bsd.port.mk.
Tested by naddy@. Okayed millert@. I'll handle the fallback if there is
any. This went through a full make build anyways, including isakmpd
(without mickey's custom binutils, as he didn't see fit to share it with me).
|
|
Handles unterminated variables, and fixes regression test #10
|
|
Looks like nobody is using this anyways.
|
|
problems.
Bug found by wilfried@.
|
|
static VarPatterns...
Old make could use dynamic variables because everything was jumbled
into one single function.
|
|
file handles it's passed to.
(this is apparently harmless on BSDs, but is still a bug).
|
|
assuming '\0' at the end.
-> importance of proper make bug reports, this was first diagnosed as
a for loop issue...
|
|
Idea taken from NetBSD. implementation completely different,
as our loop implementation diverged a while back.
|
|
|
|
|
|
Numerous changes:
- generate can build several tables
- style cleanup
- statistics code
- use variable names throughout (struct Name)
- recursive variables everywhere
- faster parser (pass buffer along instead of allocating multiple copies)
- correct parser. Handles comments everywhere, and ; correctly
- more string intervals
- simplified dir.c, less recursion.
- extended for loops
- sinclude()
- finished removing extra junk from Lst_*
- handles ${@D} and friends in a simpler way
- cleaned up and modular VarModifiers handling.
- recognizes some gnu Makefile usages and errors out about them.
Additionally, some extra functionality is defined by FEATURES. The set of
functionalities is currently hardcoded to OpenBSD defaults, but this may
include support for some NetBSD extensions, like ODE modifiers.
Backed by miod@ and millert@, who finally got sick of my endless patches...
|
|
|
|
|
|
|
|
doesn't do [for efficiency reason, hash_interval does not deal with
empty strings not declared as intervals. More recent incarnations of
this code will use Var_Value_interval extensively instead]
Problem found by Peter Stromberg.
|
|
|
|
|
