summaryrefslogtreecommitdiff
path: root/usr.bin/rcs
AgeCommit message (Collapse)Author
2006-09-19Use S_IS* macros insted of masking with S_IF* flags. The latter mayOtto Moerbeek
have multiple bits set, which lead to surprising results. Spotted by Paul Stoeber, more to come. ok millert@ pedro@ jaredy@ djm@
2006-08-23use the correct variable in error and warning messagesJoris Vink
2006-08-23Add missing checks for EOF when parsing rcs file sections.Todd C. Miller
OK xsa@ joris@ niallo@
2006-08-16Improve rcs_buf_load() by setting errno appropriately on failure andRay Lai
never print errors or quit on error. Fix usages of rcs_buf_load() and rcs_set_description. Also plug an fd leak. OK xsa@
2006-08-14files_differ() should return -1 on error, according to comments. MakeRay Lai
it so. Add checks for all return values. ``put it in'' xsa@
2006-08-11correctly handle merge(1) and rcsmerge(1) -e and -E flags; tests and OK ray@.Xavier Santolaria
2006-08-08let ed_patch_lines work with a c command that encompasses the last lineMarc Espie
of the file. The TAILQ structures specifically contain an extra `first line' to avoid this kind of issue, but no extra last line. Instead of walking beyond the end of the structure, and wondering at the null pointer, keep a pointer before the deleted block, as this one is guaranteed to exist. Fix Matthieu's testcase. okay joris@, xsa@
2006-08-07More strlcpy/strlcat -> snprintf/xasprintf cleanup.Ray Lai
OK joris@
2006-08-07Flush printf buffer before directly writing to STDIN_FILENO. PreventsRay Lai
the printf output from printing after the rcs_buf_write_fd output. ``ok!'' joris@
2006-08-04Make -n flag refer to -N flag instead of the other way around, since theRay Lai
-N flag is above. OK xsa@ and jmc@
2006-08-04Remove unnecessary strlcpy/strlcat.Ray Lai
``Oh man!'' xsa@
2006-08-02strlcpy/strlcat overload made deraadt@ sick; change to xasprintf.Ray Lai
OK niallo@
2006-08-02rcs_buf_set(), rcs_buf_append, and rcs_buf_fappend should not returnRay Lai
ssize_t. The return values aren't usually checked anyway. Also remove unnecessary casts and improve type usage. OK xsa@
2006-08-02Fix a lot of buffer overflows and make the code more binary safe.Ray Lai
Also reduce a lot of redundant for() loops. OK niallo@
2006-08-01Reduce rcs_buf_release() usage, improving binary support.Ray Lai
OK niallo@
2006-07-31Minor KNF.Ray Lai
OK xsa@
2006-07-28Recalculate buffer length after each expansion.Ray Lai
OK niallo@
2006-07-27Second try at adding binary file support to rcs_expand_keywords(),Ray Lai
using BUFs instead of C strings. Also remove initial keyword search, which is a premature optimization, slower, and apparently too hard for me to get right. OK niallo@
2006-07-27Not were we allocating memory for a pointer array, it wasn't even forRay Lai
the right variable! Fixes make regress with MALLOC_OPTIONS=PR. Found by and fix worked on with Joris. OK niallo@, tested by pedro@.
2006-07-27unused variableTheo de Raadt
2006-07-27spacingTheo de Raadt
2006-07-27unused variableTheo de Raadt
2006-07-21Revert; keywords did not expand.Ray Lai
2006-07-21Add binary file support to rcs_expand_keywords(), using BUFs insteadRay Lai
of C strings. OK niallo@
2006-07-11fix out of bound read in rcs_expand_keywords(); ok nialloMarkus Friedl
2006-07-08Remove file mode argument from {cvs|rcs}_buf_write_stmp(). WeRay Lai
always set the temporary file to mode 600, which is already done by mkstemp(). OK joris@ and xsa@ over a month ago.
2006-07-08rcs_splitlines() can never return NULL, so don't check for it.Ray Lai
OK joris@
2006-07-08- plug an old memory leak in patching code.Niall O'Higgins
ok joris@
2006-07-04- plug a memory leakNiall O'Higgins
2006-06-11- clean up rcs_expand_keywords() a little more.Niall O'Higgins
2006-06-11- zap unused variableNiall O'Higgins
2006-06-09- fix rcs_expand_keywords().Niall O'Higgins
reported by Andreas Kahari <andreas.kahari at gmail>, input from joris@
2006-06-04- initialise path pointers to NULL since error code checks for that.Niall O'Higgins
2006-06-04- explicitly set some pointers to NULL since they are tested on error.Niall O'Higgins
2006-06-04- we can just use the 'sizdiff' variable instead of calling strlen(expbuf);Niall O'Higgins
simplifies things a little.
2006-06-04- ensure fin pointer is not invalidated after reallocNiall O'Higgins
2006-06-04- don't forget to free data in rcs_expand_keywords()Niall O'Higgins
2006-06-04- fix off-by-one in rcs_expand_keywords()Niall O'Higgins
2006-06-03- correctly handle binary files; say bye bye to using c strings for deltatexts.Niall O'Higgins
"slap it in" joris@
2006-06-02various spelling fixesDavid Krause
2006-06-02- at end of checkin_main loop, reset pb.newrev. fixes a problem with checkinNiall O'Higgins
of multiple files. reported by fgsch@ ok joris@
2006-06-01- rcs_buf_release() has no need for u_char since it returns void *Niall O'Higgins
2006-06-01- zap dangling macro, will be replaced with a function later.Niall O'Higgins
2006-05-29Plug more memory leaks.Ray Lai
OK joris@
2006-05-29- sizeof(struct tm) -> sizeof(*tb)Niall O'Higgins
little tidbit from the flight to c2k6 ok joris@
2006-05-29- zap unrequired casts for rcs_buf_release().Niall O'Higgins
2006-05-28Remove a lot of xstrdup() calls in getopt() loops, which are usuallyRay Lai
unnecessary. These xstrdup() calls don't call xfree() before anyway, so if a flag is given multiple times memory leaks would have resulted. OK joris@
2006-05-28Move -A<oldfile> handling into separate chunk of code. This alsoRay Lai
removes a memory leak if -A is given multiple times. OK joris@
2006-05-28Don't fill in the rd_locker if we are creating a new RCS file.Ray Lai
OK joris@
2006-05-27Rename RCSFILE.fd to RCSFILE.rf_fd, plus minor spacing nits. NoRay Lai
binary change. OK xsa@