summaryrefslogtreecommitdiff
path: root/usr.bin/rsync
AgeCommit message (Collapse)Author
2019-03-06Simplify startup code, various phases are heading straight towards exitTheo de Raadt
so they don't need to be constructed to return errors. ok benno florian
2019-02-22remove __BEGIN_DECLS/__END_DECLS, this .h file wont beSebastian Benoit
read by a C++ compiler, and __* are no lonmger recommended. https://www.gnu.org/software/libtool/manual/html_node/C-header-files.html ok deraadt@
2019-02-21kristaps f18392f58d1f0bc72917e3ac3a46be74c194688dSebastian Benoit
Document that the gid/uid list may be empty. Fixes https://github.com/kristapsdz/openrsync/issues/10
2019-02-21kristaps cbe83cd64f40e634dbc22d3f2918c41977a6514dSebastian Benoit
If we don't get a uid/gid map, such as with an rsync:// address, we might not be able to map. So fall back on numeric ids.
2019-02-21kristaps 7721288a1d170f4d789bf7a7b822f14f91f7bcb9Sebastian Benoit
In order for GPL rsync(1) to work with --delete when openrsync is a remote sender, we need to set the FLIST_TOP_LEVEL bit for all top-level directories. This is because the GPL rsync(1) uses this bit to determine which directories to scan for files for deletion.
2019-02-21kristaps 156cf3b7d459efe133d603158fc33c243dc07ba0Sebastian Benoit
Use style(9) for bit
2019-02-21kristaps 97df28257f3cc5faae8072fbadbc334a57a4e8a7Sebastian Benoit
Remove another potential deadlock when in sender mode with multiplexing enabled.
2019-02-21kristaps b1c688cad9f544a59b871c9984888cb1a3ae11e4Sebastian Benoit
Avoid crash when -n is specified.
2019-02-21kristaps acb8f263717f27691f0318d4b7154f854b7206b3Sebastian Benoit
As found by benno@, if --numeric-ids is passed in, rsync does not send or receive the uid/gid lists at all. This also means that we need not process the lists, as we're simply going to copy around the same value.
2019-02-21implement --numeric-ids, tweaked by kristapsSebastian Benoit
2019-02-18new attempt to sync with kristaps up to Sun Feb 17 2019Sebastian Benoit
339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code. baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add common -av usage. Remove bits about not supporting anything but files/dirs. 821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@ 6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string 4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message language, use service name instead of port, specify that the socket is SOCK_STREAM. From deraadt@. Tweaked for lowercase messages. f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s comments, let the mktemp functions propogate an errno handled by the caller. Also keep the original line lengths. While in mktemp.c, make some defines into an enum. e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender into its own function. Put dry_run ack and end of phase ack into the send buffer too, further reducing the possibility of deadlock. c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be fully non-blocking. This frees us of deadlocking the protocol because the sender will always be able to pull down data. 93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be more in tune with OpenBSD. Most found by deraadt@.
2019-02-18revert previousSebastian Benoit
2019-02-18sync with kristaps up to Sun Feb 17 2019Sebastian Benoit
339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code. baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add common -av usage. Remove bits about not supporting anything but files/dirs. 821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@ 6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string 4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message language, use service name instead of port, specify that the socket is SOCK_STREAM. From deraadt@. Tweaked for lowercase messages. f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s comments, let the mktemp functions propogate an errno handled by the caller. Also keep the original line lengths. While in mktemp.c, make some defines into an enum. e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender into its own function. Put dry_run ack and end of phase ack into the send buffer too, further reducing the possibility of deadlock. c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be fully non-blocking. This frees us of deadlocking the protocol because the sender will always be able to pull down data. 93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be more in tune with OpenBSD. Most found by deraadt@.
2019-02-17delete bogus commentTheo de Raadt
2019-02-17Add support for --port=PORT and ":port" in the rsync:// URL.Theo de Raadt
real rsync only supports numbers, but this supports service names also ok florian benno
2019-02-17rsync has a large number of failure exit codes, so don't get used to thisTheo de Raadt
weak sauce EXIT_SUCCESS / EXIT_FAILURE model (in our tree very few programs use this failed concept, almost as bad as sysexits.h)
2019-02-17more yoda repairsTheo de Raadt
2019-02-17cleanup protocl warning, and return exit code upwards.Theo de Raadt
2019-02-17percolate exit code from deeper code, so that values other than 1 areTheo de Raadt
possible on failure. looked at by florian
2019-02-17improve option argument demonstrationTheo de Raadt
ok florian
2019-02-17Has to be SOCK_STREAM obviouslyTheo de Raadt
2019-02-16use MINIMUM() instead of MIN() as elsewhere in the treeTheo de Raadt
2019-02-16nasty ugly invisible spacesTheo de Raadt
2019-02-16Document some long optionsTheo de Raadt
2019-02-16--archive is same as -aTheo de Raadt
2019-02-16document -a, -D, --devices and --specialsFlorian Obser
2019-02-16add --help optionTheo de Raadt
2019-02-16document --versionTheo de Raadt
2019-02-16add missing -no-OPT long optionsTheo de Raadt
ok florian
2019-02-16sync with kristaps, commit 42166a639caa877efd91e73e288b89abf6b7cfd3Florian Obser
Remove spaces at end of line.
2019-02-16sync with kristaps, commit 1842d31d600f2834ae78fe0d99a29519a853d75cFlorian Obser
Make sender mostly nonblocking for writes. This takes a lot of logic once in blocks.c and puts it directly into sender.c. It allows running openrsync against itself without deadlocks.
2019-02-16sync with kristaps, commit d01f1b87a06c25353de28a9df45b3e202614b336Florian Obser
Add the lowbuffer routines. I'll use this in subsequent commits, but they pre-add the multiplexing frame instead of doing so during write. While here, clean up a lot of ERRX -> ERRX1 and add documentation.
2019-02-16sync with kristaps, commit d7c4fb8ac88845aa08900d5d0ec469257f63a339Florian Obser
Use a static single block instead of multiple writes.
2019-02-16sync with kristaps, commit f5c1e234990877cd274b7bcdd4d9883104cd1568Florian Obser
Make sender have reentrant sending and prioritised reading. This way, the sender gets data off the wire as quickly as possible. While here, remove dead wood from blocks.c (blk_merge).
2019-02-16sync with kristaps, commit ad6f9d84aa041d28b93cdf885a583a09f58b1b88Florian Obser
Remove superfluous includes.
2019-02-16sync with kristaps, commit 9b79b4a3d06c810304321d5b58544751b5d9fefdFlorian Obser
Fast-track reads back into a read loop to avoid the buffer with writes while there are still reads pending. This resolve some bottlenecking.
2019-02-16use service "rsync" rather than "873"Theo de Raadt
2019-02-16getaddrinfo doesn't imply "DNS", borrow terminology from sshTheo de Raadt
ok benno
2019-02-16-D bits, from kristapsFlorian Obser
2019-02-16We need to send/receive the rdev after gid and before symlink.Florian Obser
From kristaps, thanks!
2019-02-16I did some work here.Florian Obser
2019-02-16implement -D and in turn -aFlorian Obser
"you snooze, you get collisions" deraadt@
2019-02-16Handle file permissions in rsync_set_metadata().Florian Obser
We set permissions either when we create a new file or when the -p flag is set. "you snooze, you get collisions" deraadt@
2019-02-16Introduce mkstempat(), a variation on mkstemp(3) and mkstemplinkat().Florian Obser
mkstempat() works exactly like mkstemp(3) except that it replaces open(2) with openat(2) so that it can be used in rsync_downloader() to easily deal with relative paths. mkstemplinkat() works somewhat like mkdtemp() to create a template symlink. Use the mkstemplinkat() to create or update symlinks and overwrite existing objects including empty directories that might exist under the destination name. "you snooze, you get collisions" deraadt@
2019-02-16Add chown pledge so that root can gift files to other uids.Florian Obser
"you snooze, you get collisions" deraadt@
2019-02-16a minimal --version long-option, so someone can unconfuse themselvesTheo de Raadt
2019-02-16use gettimeofday + TIMEVAL_TO_TIMESPEC to create timespec with betterTheo de Raadt
than 1 sec resolution ok benno
2019-02-16If anyone ports this to 6.4 they'll just comment out unveil, don't wasteTheo de Raadt
lines telling them.
2019-02-16unwrap lines which do not need wrappingTheo de Raadt
2019-02-14sync with kristaps, commit 438c1948c76a1ecd94e53e09ba88ec7e93004540Florian Obser
Put back stray -o passed into child and add missing pledge.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-29 19:46:12 +0000