| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2008-12-14 | Remove useless fields from template, they just serve to confuse | Ray Lai | |
| users. Idea okayed by art and deraadt, feedback from jmc. | |||
| 2008-10-06 | parse all arguments before going and doing the job requested by -P | Theo de Raadt | |
| (slight change made to check argc == 0) from Daniel Dickman | |||
| 2008-06-14 | - remove ports category after discussion w/ many | Peter Valchev | |
| - sync architectures list with reality and fix a few names ok theo | |||
| 2008-05-08 | replace "/usr/sbin/sendmail" with _PATH_SENDMAIL | Charles Longeau | |
| no binary change found by Daniel Dickman <didickman at gmail.com> ok ray@ | |||
| 2008-04-19 | Decrement len variable after removing newline, prevents copying the | Ray Lai | |
| NUL at the end of a string into the mail. Discovered by dasn. Move newline printing into outer loop, prevents multiple newlines from appearing if there are multiple comments in a line. Discovered by okan. OK okan. | |||
| 2008-01-04 | Eliminate false positives from <> comments, avoiding mangling | Ray Lai | |
| #include <bleh.h> in diffs: - Only match <> comments from the template. No other text surrounded by angle brackets is deleted. - Simplify code by using C strings. We no longer handle binary data, but I don't think binary data belongs in a bug report anyway. - Remove dmesg and header comment checks. "That's a nice approach." deraadt, "seems ok for me" chl. | |||
| 2008-01-03 | In preparation of eliminating <> comment false positives: | Ray Lai | |
| - Move <> comments in template to an array, for easier reference later. - Rename "comment" variable to avoid shadowing. - Change some <> comments to SENDBUG comments. OK chl@ | |||
| 2007-10-17 | - Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) by | Theo de Raadt | |
| temporarily restoring default behaviour. This is not 100% ideal. But this fixes editor handling in mail... bah, it is really unfortunate that got broken - refactor the restoration code as well, to make it simpler ok ray | |||
| 2007-09-18 | Don't treat lines in angle brackets <...> as comments in dmesg. | Ray Lai | |
| Discovered and tested by deanna. | |||
| 2007-07-31 | Remove some unused headers, from Igor Zinovik. | Ray Lai | |
| 2007-05-11 | If fork fails with EAGAIN, ignore errno and fail. Looping just | Ray Lai | |
| worsens the problem. cloder@ and deraadt@ agree. | |||
| 2007-05-11 | Instead of returning -1 and setting errno to ECHILD if the editor | Ray Lai | |
| has a non-zero exit status, just return the exit status on success. Hard errors still return -1. If the editor is killed, return -1 and set EINTR. | |||
| 2007-05-09 | Be more consistent about when dmesg is attached to template. | Ray Lai | |
| Specifically, -V. | |||
| 2007-05-07 | Simplify some loops. | Ray Lai | |
| OK jaredy@ and moritz@. | |||
| 2007-05-06 | Restore signals before returning. | Ray Lai | |
| 2007-05-06 | Save and restore signals once instead of each time fork fails with | Ray Lai | |
| EAGAIN. | |||
| 2007-04-25 | Remove extra code that only applies to setuid/setgid programs. | Ray Lai | |
| ``Slacker! We'll burn your hands if you don't get going!'' deraadt@ | |||
| 2007-04-07 | Sprinkle const poison, remove unneeded variable. | Ray Lai | |
| 2007-04-07 | Use __progname and warn instead of fprintf where appropriate. | Ray Lai | |
| 2007-04-07 | De-lint. | Ray Lai | |
| 2007-04-06 | Warn if one of the required fields is not filled out. Requested | Ray Lai | |
| by millert@. | |||
| 2007-04-06 | Don't shadow variables. Enable -Wshadow. | Ray Lai | |
| 2007-04-06 | argc does not include __progname after subtracting optind. | Ray Lai | |
| 2007-04-06 | Only include newest dmesg. | Ray Lai | |
| ``Come on, take some risks'' deraadt@. | |||
| 2007-04-06 | Attach dmesg to sendbug reports by default. Use -D flag to disable. | Ray Lai | |
| OK deraadt@ and millert@. | |||
| 2007-03-28 | CC: a copy of the bug report to sender. Requested by Travers Buda. | Ray Lai | |
| OK millert@. | |||
| 2007-03-27 | Replace some scary pointer code. The new code is O(n^2) for strings | Ray Lai | |
| of '&', but gecos fields are usually short and most do not have '&' so the impact should be minimal. In return we get clearer and safer code. OK moritz@. | |||
| 2007-03-27 | Remove variable name from prototype. | Ray Lai | |
| 2007-03-26 | Simplify gecos parsing code and prevent buffer overflow | Moritz Jodeit | |
| when gecos field contains multiple '&' characters with other characters inbetween. With and OK ray@ | |||
| 2007-03-26 | Remove pointless cast. No binary change. | Ray Lai | |
| 2007-03-26 | Break on waitpid success; we shouldn't continue on WIFSIGNALED, and | Ray Lai | |
| WIFCONTINUED can't happen in this case. OK deraadt@. | |||
| 2007-03-26 | Certain errors in editit() should be fatal. | Ray Lai | |
| 2007-03-26 | Don't print warnings in editit(), instead make errno reliable on | Ray Lai | |
| failure. If the editor exits non-zero, errno is set to ECHILD. OK deraadt@. | |||
| 2007-03-26 | Accept $VISUAL in addition to $EDITOR. | Ray Lai | |
| 2007-03-26 | Save and restore signal handlers. Although we do not install our | Ray Lai | |
| own signal handlers, this allows this code to be more easily reused in other programs. OK deraadt@ | |||
| 2007-03-26 | Restore errno before calling perror(). | Ray Lai | |
| 2007-03-26 | Check fork() == -1 instead of fork() < 0. | Ray Lai | |
| 2007-03-26 | When someone hits ^C in an editor, the editor does exit(130), I | Ray Lai | |
| don't know why. Something to do with the shell, says deraadt@. Continuing to ignore these signals in the child fixes this. Now editit()'s return value can be reliably checked. OK deraadt@. | |||
| 2007-03-26 | more careful waitpid() discussed with ray (plus some knf) | Theo de Raadt | |
| 2007-03-25 | fork() does not return EPROCLIM, so don't test for it. | Ray Lai | |
| 2007-03-25 | more cleaning :) | Theo de Raadt | |
| 2007-03-25 | Change editit() to return -1 on error and 0 on success, like many | Ray Lai | |
| other C functions. (Currently this return value is unchecked.) | |||
| 2007-03-25 | KNF. | Ray Lai | |
| 2007-03-25 | Save errno before calling signal(). | Ray Lai | |
| 2007-03-23 | correct signal handling and process waiting for the editor spawning | Theo de Raadt | |
| code, so that signals in the editor are handled right. written by ray after he started looking at other code that does this better | |||
| 2007-03-23 | Since we now have our own program, we can export more things that | Theo de Raadt | |
| matter. Include kern.version, which tells a hell of a lot. ok millert ray | |||
| 2007-03-23 | Replace `&' in gecos field with login, prodded by deraadt@. | Ray Lai | |
| 2007-03-23 | simplify cleanup by using an atexit handler. lets us use err() instead | Ted Unangst | |
| of a series of warn()/gotos. ok deraadt | |||
| 2007-03-23 | re-org something for prettiness | Theo de Raadt | |
| 2007-03-23 | support $PR_FORM environment variable | Theo de Raadt | |
 |
index : src | |
| OpenBSD base system |
| summaryrefslogtreecommitdiff |