summaryrefslogtreecommitdiff
path: root/usr.bin/sendbug
AgeCommit message (Collapse)Author
2008-01-04Eliminate false positives from <> comments, avoiding manglingRay Lai
#include <bleh.h> in diffs: - Only match <> comments from the template. No other text surrounded by angle brackets is deleted. - Simplify code by using C strings. We no longer handle binary data, but I don't think binary data belongs in a bug report anyway. - Remove dmesg and header comment checks. "That's a nice approach." deraadt, "seems ok for me" chl.
2008-01-03In preparation of eliminating <> comment false positives:Ray Lai
- Move <> comments in template to an array, for easier reference later. - Rename "comment" variable to avoid shadowing. - Change some <> comments to SENDBUG comments. OK chl@
2007-10-17- Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) byTheo de Raadt
temporarily restoring default behaviour. This is not 100% ideal. But this fixes editor handling in mail... bah, it is really unfortunate that got broken - refactor the restoration code as well, to make it simpler ok ray
2007-09-18Don't treat lines in angle brackets <...> as comments in dmesg.Ray Lai
Discovered and tested by deanna.
2007-09-07Synced atomicio implementation in nc and sendbug with ssh.Tobias Stoeckmann
OK djm@, joris@, ray@
2007-07-31Remove some unused headers, from Igor Zinovik.Ray Lai
2007-05-31convert to new .Dd format;Jason McIntyre
2007-05-11If fork fails with EAGAIN, ignore errno and fail. Looping justRay Lai
worsens the problem. cloder@ and deraadt@ agree.
2007-05-11Instead of returning -1 and setting errno to ECHILD if the editorRay Lai
has a non-zero exit status, just return the exit status on success. Hard errors still return -1. If the editor is killed, return -1 and set EINTR.
2007-05-09Be more consistent about when dmesg is attached to template.Ray Lai
Specifically, -V.
2007-05-07Simplify some loops.Ray Lai
OK jaredy@ and moritz@.
2007-05-06Restore signals before returning.Ray Lai
2007-05-06Save and restore signals once instead of each time fork fails withRay Lai
EAGAIN.
2007-04-25Remove extra code that only applies to setuid/setgid programs.Ray Lai
``Slacker! We'll burn your hands if you don't get going!'' deraadt@
2007-04-13document dmesg(8) attachment a little more fully; ok rayJason McIntyre
2007-04-13+.Xr dmesg 8Jason McIntyre
2007-04-07Sprinkle const poison, remove unneeded variable.Ray Lai
2007-04-07Use __progname and warn instead of fprintf where appropriate.Ray Lai
2007-04-07De-lint.Ray Lai
2007-04-06Warn if one of the required fields is not filled out. RequestedRay Lai
by millert@.
2007-04-06Don't shadow variables. Enable -Wshadow.Ray Lai
2007-04-06argc does not include __progname after subtracting optind.Ray Lai
2007-04-06Only include newest dmesg.Ray Lai
``Come on, take some risks'' deraadt@.
2007-04-06Attach dmesg to sendbug reports by default. Use -D flag to disable.Ray Lai
OK deraadt@ and millert@.
2007-03-28flesh the text out; ok rayJason McIntyre
2007-03-28+.Xr crash 8Jason McIntyre
2007-03-28CC: a copy of the bug report to sender. Requested by Travers Buda.Ray Lai
OK millert@.
2007-03-27Replace some scary pointer code. The new code is O(n^2) for stringsRay Lai
of '&', but gecos fields are usually short and most do not have '&' so the impact should be minimal. In return we get clearer and safer code. OK moritz@.
2007-03-27Remove variable name from prototype.Ray Lai
2007-03-26- tweak the opening sentenceJason McIntyre
- be less precise about editors in the opening blurb - note that prs are not confidential, and provide an alternative ok ray deraadt
2007-03-26Simplify gecos parsing code and prevent buffer overflowMoritz Jodeit
when gecos field contains multiple '&' characters with other characters inbetween. With and OK ray@
2007-03-26Remove pointless cast. No binary change.Ray Lai
2007-03-26Break on waitpid success; we shouldn't continue on WIFSIGNALED, andRay Lai
WIFCONTINUED can't happen in this case. OK deraadt@.
2007-03-26Certain errors in editit() should be fatal.Ray Lai
2007-03-26Don't print warnings in editit(), instead make errno reliable onRay Lai
failure. If the editor exits non-zero, errno is set to ECHILD. OK deraadt@.
2007-03-26Accept $VISUAL in addition to $EDITOR.Ray Lai
2007-03-26Save and restore signal handlers. Although we do not install ourRay Lai
own signal handlers, this allows this code to be more easily reused in other programs. OK deraadt@
2007-03-26Restore errno before calling perror().Ray Lai
2007-03-26Check fork() == -1 instead of fork() < 0.Ray Lai
2007-03-26When someone hits ^C in an editor, the editor does exit(130), IRay Lai
don't know why. Something to do with the shell, says deraadt@. Continuing to ignore these signals in the child fixes this. Now editit()'s return value can be reliably checked. OK deraadt@.
2007-03-26more careful waitpid() discussed with ray (plus some knf)Theo de Raadt
2007-03-25fork() does not return EPROCLIM, so don't test for it.Ray Lai
2007-03-25more cleaning :)Theo de Raadt
2007-03-25Change editit() to return -1 on error and 0 on success, like manyRay Lai
other C functions. (Currently this return value is unchecked.)
2007-03-25KNF.Ray Lai
2007-03-25Save errno before calling signal().Ray Lai
2007-03-23correct signal handling and process waiting for the editor spawningTheo de Raadt
code, so that signals in the editor are handled right. written by ray after he started looking at other code that does this better
2007-03-23Since we now have our own program, we can export more things thatTheo de Raadt
matter. Include kern.version, which tells a hell of a lot. ok millert ray
2007-03-23missing .El;Jason McIntyre
2007-03-23Document temporary files.Ray Lai