summaryrefslogtreecommitdiff
path: root/usr.bin/ssh
AgeCommit message (Collapse)Author
2019-03-29when logging/fataling on error, include a bit more detail than just theDamien Miller
function name and the error message
2019-03-27fix interaction between ClientAliveInterval and RekeyLimit that couldDamien Miller
cause connection to close incorrectly; Report and patch from Jakub Jelen in bz#2757; ok dtucker@ markus@
2019-03-25Fix authentication failures when "AuthenticationMethods any" in aDamien Miller
Match block overrides a more restrictive global default. Spotted by jmc@, ok markus@
2019-03-25whitespaceDamien Miller
2019-03-25Expand comment to document rationale for default key sizes.Darren Tucker
"seems worthwhile" deraadt.
2019-03-25Increase the default RSA key size to 3072 bits. Based on the estimatesDarren Tucker
from NIST Special Publication 800-57, 3k bits provides security equivalent to 128 bits which is the smallest symmetric cipher we enable by default. ok markus@ deraadt@
2019-03-22full stop in the wrong place;Jason McIntyre
2019-03-16benno helped me clean up the tcp forwarding section;Jason McIntyre
2019-03-08fix use-after-free in ssh-pkcs11; found by hshoexer w/AFLMarkus Friedl
2019-03-06Move checks for lists of users or groups into their own function.Darren Tucker
This is a no-op on OpenBSD but will make things easier in -portable, eg on systems where these checks should be case-insensitive. ok djm@
2019-03-06Reset last-seen time when sending a keepalive. Prevents sending twoDarren Tucker
keepalives successively and prematurely terminating connection when ClientAliveCount=1. While there, collapse two similar tests into one. ok markus@
2019-03-05PKCS#11 support is no longer limited to RSA; ok benno@ kn@Christian Weisgerber
2019-03-01in ssh_set_newkeys(), mention the direction that we're keying in debugDamien Miller
messages. Previously it would be difficult to tell which direction it was talking about
2019-03-01Fix two race conditions in sshd relating to SIGHUP:Damien Miller
1. Recently-forked child processes will briefly remain listening to listen_socks. If the main server sshd process completes its restart via execv() before these sockets are closed by the child processes then it can fail to listen at the desired addresses/ports and/or fail to restart. 2. When a SIGHUP is received, there may be forked child processes that are awaiting their reexecution state. If the main server sshd process restarts before passing this state, these child processes will yield errors and use a fallback path of reading the current sshd_config from the filesystem rather than use the one that sshd was started with. To fix both of these cases, we reuse the startup_pipes that are shared between the main server sshd and forked children. Previously this was used solely to implement tracking of pre-auth child processes for MaxStartups, but this extends the messaging over these pipes to include a child->parent message that the parent process is safe to restart. This message is sent from the child after it has completed its preliminaries: closing listen_socks and receiving its reexec state. bz#2953, reported by Michal Koutný; ok markus@ dtucker@
2019-03-01mention PKCS11Provide=none, reword a little and remove mention ofDamien Miller
RSA keys only (since we support ECDSA now and might support others in the future). Inspired by Jakub Jelen via bz#2974
2019-03-01let PKCS11Provider=none do what users expectDamien Miller
print PKCS11Provider instead of obsolete SmartcardDevice in config dump. bz#2974 ok dtucker@
2019-02-27dup stdout/in for proxycommand=-, otherwise stdout might beMarkus Friedl
redirected to /dev/null; ok djm@
2019-02-23openssh-7.9 accidentally reused the server's algorithm lists in theDamien Miller
client for KEX, ciphers and MACs. The ciphers and MACs were identical between the client and server, but the error accidentially disabled the diffie-hellman-group-exchange-sha1 KEX method. This fixes the client code to use the correct method list, but because nobody complained, it also disables the diffie-hellman-group-exchange-sha1 KEX method. Reported by nuxi AT vault24.org via bz#2697; ok dtucker
2019-02-22perform removal of agent-forwarding directory in forward setup errorDamien Miller
path with user's privileged. This is a no-op as this code always runs with user privilege now that we no longer support running sshd with privilege separation disabled, but as long as the privsep skeleton is there we should follow the rules. bz#2969 with patch from Erik Sjölund
2019-02-18sync the description of ~/.ssh/config with djm's updated description in ssh.1;Jason McIntyre
issue pointed out by andreas kahari ok dtucker djm
2019-02-12fix regression in r1.302 reported by naddy@ - only the first publicDamien Miller
key from the agent was being attempted for use.
2019-02-11cleanup GSSAPI authentication context after completion of theDamien Miller
authmethod. Move function-static GSSAPI state to the client Authctxt structure. Make static a bunch of functions that aren't used outside this file. Based on patch from Markus Schmidt <markus@blueflash.cc>; ok markus@
2019-02-10ssh-keygen -D pkcs11.so needs to initialize pkcs11 interactive,Sebastian Benoit
so it can ask for the smartcards PIN. ok markus@
2019-02-10when checking that filenames sent by the server side match what theDamien Miller
client requested, be prepared to handle shell-style brace alternations, e.g. "{foo,bar}". "looks good to me" millert@ + in snaps for the last week courtesy deraadt@
2019-02-10syslog when connection is dropped for attempting to run a commandDamien Miller
when ForceCommand=internal-sftp is in effect; bz2960; ok dtucker@
2019-02-05Adapt code in the non-USE_PIPES codepath to the new packet API.Darren Tucker
This code is not normally reachable since USE_PIPES is always defined. bz#2961, patch from adrian.fita at gmail com.
2019-02-04fix NULL-deref crash in PKCS#11 code when attempting login to a tokenDamien Miller
requiring a PIN; reported by benno@ fix mostly by markus@
2019-02-04Remove obsolete "Protocol" from commented out examples.Darren Tucker
Patch from samy.mahmoudi at gmail com.
2019-02-01Save connection timeout and restore for 2nd and subsequent attempts,Darren Tucker
preventing them from having no timeout. bz#2918, ok djm@
2019-01-30Add authors for public domain sntrup4591761 code;Markus Friedl
confirmed by Daniel J. Bernstein
2019-01-27add -T to usage();Jason McIntyre
2019-01-26check in scp client that filenames sent during remote->local directoryDamien Miller
copies satisfy the wildcard specified by the user. This checking provides some protection against a malicious server sending unexpected filenames, but it comes at a risk of rejecting wanted files due to differences between client and server wildcard expansion rules. For this reason, this also adds a new -T flag to disable the check. reported by Harry Sintonen fix approach suggested by markus@; has been in snaps for ~1wk courtesy deraadt@
2019-01-26make ssh-keyscan return a non-zero exit status if it finds no keys.Damien Miller
bz#2903
2019-01-24Accept the host key fingerprint as a synonym for "yes" when acceptingDarren Tucker
an unknown host key. This allows you to paste a fingerprint obtained out of band into the yes/no prompt and have the client do the comparison for you. ok markus@ djm@
2019-01-24Have progressmeter force an update at the beginning and end of eachDarren Tucker
transfer. Fixes the problem recently introduces where very quick transfers do not display the progressmeter at all. Spotted by naddy@
2019-01-24Check for both EAGAIN and EWOULDBLOCK. This is a no-op in OpenBSDDarren Tucker
(they are the same value) but makes things easier in -portable where they may be distinct values. "sigh ok" deraadt@
2019-01-24Always initialize 2nd arg to hpdelim2. It populates that *ONLY IF*Darren Tucker
there's a delimiter. If there's not (the common case) it checked uninitialized memory, which usually passed, but if not would cause spurious failures when the uninitialized memory happens to contain "/". ok deraadt.
2019-01-23Remove support for obsolete host/port syntax.Darren Tucker
host/port was added in 2001 as an alternative to host:port syntax for the benefit of IPv6 users. These days there are establised standards for this like [::1]:22 and the slash syntax is easily mistaken for CIDR notation, which OpenSSH now supports for some things. Remove the slash notation from ListenAddress and PermitOpen. bz#2335, patch from jjelen at redhat.com, ok markus@
2019-01-23Remove duplicate word. bz#2958, patch from jjelen at redhat.comDarren Tucker
2019-01-23Remove 3 as a guess for possible generator during moduli generation.Darren Tucker
It's not mentioned in RFC4419 and it's not possible for Sophie-Germain primes greater than 5. bz#2330, from Christian Wittenhorst , ok djm@ tb@
2019-01-23Sanitize scp filenames via snmprintf. To do this we move theDarren Tucker
progressmeter formatting outside of signal handler context and have the atomicio callback called for EINTR too. bz#2434 with contributions from djm and jjelen at redhat.com, ok djm@
2019-01-23allow auto-incrementing certificate serial number for certs signedDamien Miller
in a single commandline.
2019-01-23move a bunch of global flag variables to main(); make the rest staticDamien Miller
2019-01-23switch mainloop from select(2) to poll(2); ok deraadt@Damien Miller
2019-01-23pass most arguments to the KEX hash functions as sshbuf ratherDamien Miller
than pointer+length; ok markus@
2019-01-22backoff reading messages from active connections when the input bufferDamien Miller
is too full to read one, or if the output buffer is too full to enqueue a response; feedback & ok dtucker@
2019-01-22add -m to usage(); reminded by jmc@Damien Miller
2019-01-22Correct some bugs in PKCS#11 token PIN handling at initial login,Damien Miller
the attempt at reading the PIN could be skipped in some cases especially on devices with integrated PIN readers. based on patch from Daniel Kucera in bz#2652; ok markus@
2019-01-22Support keys that set the CKA_ALWAYS_AUTHENTICATE by requring aDamien Miller
fresh login after the C_SignInit operation. based on patch from Jakub Jelen in bz#2638; ok markus
2019-01-22Mention that configuration for the destination host is not appliedDamien Miller
to any ProxyJump/-J hosts. This has confused a few people...