summaryrefslogtreecommitdiff
path: root/usr.bin/vi
AgeCommit message (Collapse)Author
2019-01-24Fix a crash on long lines when switching to another file byTodd C. Miller
setting SC_SCR_CENTER which will cause the offsets in HMAP to be reset when painting the screen. OK martijn@ otto@
2018-09-17Use the strict pragma for better warnings.Todd C. Miller
2018-07-13Remove cscope leftover and a stray comma.Anthony J. Bentley
From "kshe" on tech@.
2018-07-13Unused variable.Kenneth R Westerback
ok martijn@ henning@
2018-07-11Remove an old and false comment. REALLOC now free(3)s the code if reallocMartijn van Duren
fails. OK millert@
2018-02-12Simplify documentation of split-screen mode, avoiding abuse of []Ingo Schwarze
to sometimes mean "character set", which conflicts with the normal meaning of "optional element" in manual pages. While here, add a few related clarifications and tweak a few details. Triggered by a minor bug report from <trondd at kagu-tsuchi dot com>, and by bentley@ subsequently pointing out the abuse of []. Patch using input from jmc@, who also agreed with some previous versions.
2018-02-03The recover script should have the same sanity checks as recover.c.Todd C. Miller
Specifically, open files with O_NONBLOCK and enforce a mode of 0600.
2017-12-14Enable the awk scripts to generate ex_def.h and options_def.h.Martijn van Duren
These scripts generate the enums required for the ex commands and vi options. Before these lists had to be maintained either by hand or someone had to stumble upon these scripts and figure out how to use them. By enabling them these headers are now always in sync based on the comments in the corresponding source files, which are a lot harder to miss during an update than an extra file. Update the awk scripts to the new enum style introduced by bentley@ with his update on options_def.h r1.7 Feedback Makefile semantics by espie@ Original diff and OK tb@ OK millert@
2017-11-26Fix segfault which could be triggered by deleting a backwards sentence ifRicardo Mestre
cursor's current line was blank: echo "\nfoo" > a && vi a d( Same fix applied by rin@NetBSD, via nvi2 project. OK tom@ martijn@ tb@ millert@
2017-11-10When tracing is compiled in make sure it flushes its content to disk asMartijn van Duren
soon as the TRACE function is called. This helps while debugging crashes. Noticed and annoyed by while debugging the SIGTERM crash I just submitted. OK millert@ and tb@
2017-11-10Fix a use after free when sending SIGHUP or SIGTERM to vi when in editingMartijn van Duren
mode. Found while testing previous commit by millert@ OK millert@ and tb@
2017-11-10Add rcv_openat() function that does the open, makes sure it is aTodd C. Miller
regular file with the expected permissions and locks it. Inspired by changes in NetBSD by Christos. OK martijn@
2017-11-10Avoid using system(3) when running "sendmail -t". We already haveTodd C. Miller
the recover file fd open so just run sendmail with stdin set to the recover file. OK martijn@
2017-08-22Do not treat comma as part of the command modifier.anton
ok schwarze@
2017-07-31Silence some warnings generated by clang.Martijn van Duren
Original diff by espie@ with some minor tweaks by myself. OK espie@ and florian@
2017-07-20Replace usage of strtol() with strtonum().anton
ok bentley@ deraadt@ millert@ tb@
2017-07-05avoid double space caused by end-of-sentence detection; requested by jmc@Ingo Schwarze
2017-07-05nits about trailing punctuation found with mandoc -TlintIngo Schwarze
2017-07-03markup fixes;Jason McIntyre
2017-07-03Remove settings that were unimplemented for 20 years; update STANDARDS.Anthony J. Bentley
ok jmc@ natano@
2017-06-30Add mdoc(7) macros to vi's built-in lists of roff paragraph/section macros.Anthony J. Bentley
ok jmc@, no objection schwarze@
2017-06-24Fix a check in ADD_SPACE_{GOTO,RET} that potentially allowed for aMartijn van Duren
NULL-dereference. OK tom@
2017-06-20Better document the :s ex command and its variants.Anthony J. Bentley
ok jmc@
2017-06-15"10th's of a second" -> "tenths of a second"Anthony J. Bentley
ok jmc@
2017-06-12Use openat() and unlinkat() instead of chdir()ing to the recovery dir.Todd C. Miller
Since we use flock() and not fcntl() locking we can open the recovery file read-only. OK martijn@
2017-04-26Remove extraneous ", NULL" in the assignment of msgstr which wasTodd C. Miller
leftover from when msg_cat() was removed. From Anton Lindqvist
2017-04-18free(NULL) is ok so use it; from Michael W. BombardieriTheo de Raadt
2017-01-20Nuke some excess whitespace.Kenneth R Westerback
2016-12-18Use %zu/%d to print size_t/ssize_t. Cast recno_t (a.k.a. u_int32_t)Kenneth R Westerback
to (unsigned long) to match %lu formats. Makes gcc happier and quieter. ok deraadt@
2016-12-18Nuke more unused variables.Kenneth R Westerback
ok millert@
2016-11-05Remove syscall.ph from vi.recoverAndrew Fresh
since perl-5.10 chdir supports fchdir ok guenther@
2016-09-02Fix the begin of word issue in vi(1).Martijn van Duren
Similar fix went in sed and ed. Feedback and OK schwarze@
2016-08-27Pull in <sys/time.h> for struct timespec and timevalPhilip Guenther
ok deraadt@
2016-08-14Kill '#if defined(DEBUG) && 0' blocks that used %qPhilip Guenther
ok bentley@ on principle
2016-08-08/tmp and /var/tmp are the same, consistently use the former in bothIgor Sobrado
build/recover and documentation. ok millert@, tb@, martijn@ and schwarze@
2016-08-01Remove vi's "directory" option and TMPDIR support.Anthony J. Bentley
ok jung@
2016-07-07biff, mesg, vi: only consider ACCESSPERMS for setting tty mode.Sebastien Marie
it explicitly removes any S_ISUID|S_ISGID|S_ISTXT bits, instead of letting pledge(2) silenciously remove them. ok beck@ deraadt@
2016-06-29If /tmp/vi.recover doesn't exist, don't create it. Warn onceTheo Buehler
that it doesn't exist, afterwards fail silently. ok millert
2016-05-28Test if stdin is a terminal before resetting the tty state.Martijn van Duren
Diff supplied by Kai Antweiler. OK semarie@ and deraadt@
2016-05-27Revert CHAR_T removal. Some signedness flaws were introduced.Martijn van Duren
Found the hard way by jca@
2016-05-07Free memory if realloc fails. The application is most likely to terminate afterMartijn van Duren
a failure, but if it does not we better clean up after ourselfs. OK deraadt@ and stefan@
2016-05-05Remove __sigblockset. This is a leftover after the removal of the signalMartijn van Duren
blocking code in common/gs.h rev 1.14. Remove a redundant return while here. OK millert@
2016-05-02Remove pointless comment. getcwd(3) is safe.Martijn van Duren
OK millert@
2016-05-02Remove CHAR_T in favor of native types.Martijn van Duren
schwarze@ agrees with the direction. Few tweaks and OK tb@
2016-04-20Remove pointless reenter variable.Martijn van Duren
OK millert@
2016-04-19Remove not implemented decliration of sscr_pty.Martijn van Duren
2016-04-19Remove some useless code.Martijn van Duren
Minor tweak and OK schwarze@ OK tb@
2016-03-30for some time now mandoc has not required MLINKS to functionJason McIntyre
correctly - logically complete that now by removing MLINKS from base; authors need only to ensure there is an entry in NAME for any function/ util being added. MLINKS will still work, and remain for perl to ease upgrades; ok nicm (curses) bcook (ssl) ok schwarze, who provided a lot of feedback and assistance ok tb natano jung
2016-03-19By issuing :e +something in vi(1) this uncovers a backwards memcpy with themestre
code because the 2 buffers overlap and in order to solve it then replace memcpy(3) call by memmove(3) Issue noticed by Michael Price <michael at ectospheno dot com> who also tested this diff OK deraadt@
2016-03-17Add error checking for COLUMNS/LINES environment variables.Anthony J. Bentley
It would be better to replace all the complicated existing code with a simple idiom, and this is being worked on. But for the moment, preventing vi from crashing is worthwhile. ok jung@