Age | Commit message (Collapse) | Author |
|
path with user's privileged. This is a no-op as this code always runs
with user privilege now that we no longer support running sshd with
privilege separation disabled, but as long as the privsep skeleton is
there we should follow the rules.
bz#2969 with patch from Erik Sjölund
|
|
Document that the gid/uid list may be empty. Fixes
https://github.com/kristapsdz/openrsync/issues/10
|
|
If we don't get a uid/gid map, such as with an rsync:// address, we
might not be able to map. So fall back on numeric ids.
|
|
In order for GPL rsync(1) to work with --delete when openrsync is a
remote sender, we need to set the FLIST_TOP_LEVEL bit for all
top-level directories. This is because the GPL rsync(1) uses this bit
to determine which directories to scan for files for deletion.
|
|
Use style(9) for bit
|
|
Remove another potential deadlock when in sender mode with
multiplexing enabled.
|
|
Avoid crash when -n is specified.
|
|
As found by benno@, if --numeric-ids is passed in, rsync does not send
or receive the uid/gid lists at all. This also means that we need not
process the lists, as we're simply going to copy around the same
value.
|
|
|
|
overflow in multiplication of malloc argument.
|
|
339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.
baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
common -av usage. Remove bits about not supporting anything but
files/dirs.
821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@
6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string
4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM. From deraadt@. Tweaked for lowercase messages.
f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller. Also keep the original line lengths. While in mktemp.c, make
some defines into an enum.
e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function. Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.
c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking. This frees us of deadlocking the protocol because
the sender will always be able to pull down data.
93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD. Most found by deraadt@.
|
|
|
|
339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.
baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
common -av usage. Remove bits about not supporting anything but
files/dirs.
821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@
6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string
4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM. From deraadt@. Tweaked for lowercase messages.
f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller. Also keep the original line lengths. While in mktemp.c, make
some defines into an enum.
e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function. Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.
c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking. This frees us of deadlocking the protocol because
the sender will always be able to pull down data.
93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD. Most found by deraadt@.
|
|
pfioc_src_nodes to size_t. This avoids integer truncation by casts
to unsigned. As the types of DIOCGETSTATES and DIOCGETSRCNODES
ioctl(2) arguments change, pfctl(8) and systat(1) should be updated
together with the kernel. Calculate number of pf(4) states as
size_t in userland.
OK sashan@ deraadt@
|
|
Ok mpi@
|
|
Ok mpi@
|
|
issue pointed out by andreas kahari
ok dtucker djm
|
|
|
|
real rsync only supports numbers, but this supports service names also
ok florian benno
|
|
weak sauce EXIT_SUCCESS / EXIT_FAILURE model (in our tree very few programs
use this failed concept, almost as bad as sysexits.h)
|
|
|
|
|
|
possible on failure.
looked at by florian
|
|
ok florian
|
|
ok jsing@ tb@
|
|
|
|
|
|
NISHIOKA in GitHub issue 1601.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
ok florian
|
|
Remove spaces at end of line.
|
|
Make sender mostly nonblocking for writes. This takes a lot of logic once
in blocks.c and puts it directly into sender.c. It allows running openrsync
against itself without deadlocks.
|
|
Add the lowbuffer routines. I'll use this in subsequent commits, but they
pre-add the multiplexing frame instead of doing so during write. While here,
clean up a lot of ERRX -> ERRX1 and add documentation.
|
|
Use a static single block instead of multiple writes.
|
|
Make sender have reentrant sending and prioritised reading. This way,
the sender gets data off the wire as quickly as possible. While here,
remove dead wood from blocks.c (blk_merge).
|
|
Remove superfluous includes.
|
|
Fast-track reads back into a read loop to avoid the buffer with writes while
there are still reads pending. This resolve some bottlenecking.
|
|
|
|
ok benno
|
|
|
|
From kristaps, thanks!
|
|
is already past, the next day is assumed. Handle the case where
we're still in the same hour but the minutes are past.
ok deraadt@ millert@
|
|
|
|
|
|
"you snooze, you get collisions" deraadt@
|