summaryrefslogtreecommitdiff
path: root/usr.bin
AgeCommit message (Collapse)Author
2006-03-25needed casts (always will be needed)Theo de Raadt
2006-03-25Put $OpenBSD$ tags back (as comments) to replace the RCSID()s thatDamien Miller
Theo nuked - our scripts to sync -portable need them in the files
2006-03-25Use fstat(3) instead of stat(3) as a matter of principle. We don'tOtto Moerbeek
like race conditions, even if the effects of these are void and empty.
2006-03-25"abormally" is a perfectly cromulent word, but "abnormally" is betterDamien Miller
2006-03-25change OpenSSH's xrealloc() function from being xrealloc(p, new_size) toDamien Miller
xrealloc(p, new_nmemb, new_itemsize). realloc is particularly prone to integer overflows because it is almost always allocating "n * size" bytes, so this is a far safer API; ok deraadt@
2006-03-25introduce xcalloc() and xasprintf() failure-checked allocations functionsDamien Miller
and use them throughout openssh xcalloc is particularly important because malloc(nmemb * size) is a dangerous idiom (subject to integer overflow) and it is time for it to die feedback and ok deraadt@
2006-03-24For those of us (including me) who can't type: show an error message ifOtto Moerbeek
the argument is a dir. ok tom@ commit #1000 in slighlty less than 1000 days of commit access :-)
2006-03-24ANSIfy. Ok ray@Kjell Wooding
2006-03-24change rcs_parse_deltas() and rcs_parse_deltatexts() return valueXavier Santolaria
to void as they never return non-zero. OK ray@.
2006-03-24change rcsclean_file() return type to void as it does not needXavier Santolaria
to be checked. OK ray@.
2006-03-24Remove unused variables, better integer types, prevent fallthroughs.Ray Lai
Found by lint. Compare char * variables against NULL for consistency and add parentheses around complicated comparisons, suggested by xsa@. OK xsa@
2006-03-24oops, noticed by David Hill.Marc Espie
2006-03-24Allow the -x flag to be used without an extension.Ray Lai
``that makes sense'' xsa@
2006-03-24KNF, no binary change.Ray Lai
From Han Boetes.
2006-03-24Fix RCS_KWEXP_INVAL() macro.Ray Lai
Pointed out by Theo. Okay xsa@.
2006-03-23rlog_file() will never return non-zero; change its return type to void.Xavier Santolaria
2006-03-23fetch() will never return non-zero; change its return type to void.Xavier Santolaria
OK niallo@.
2006-03-23kill whitespace at eol;Jason McIntyre
2006-03-23use fatal() in rcs_lock_setmode(); OK ray@.Xavier Santolaria
2006-03-23- cvs_buf_putc() will never return non-zeroXavier Santolaria
- change cvs_buf_putc() return type to void OK ray@.
2006-03-23formatting fixesMarc Espie
2006-03-23... and remove extra test that is no longer needed.Marc Espie
2006-03-23simply set up format only when we see -g.Marc Espie
2006-03-23explicit cast on strtoul, classical const gotcha.Marc Espie
2006-03-23back-out format for now, need to be active ONLY in GNU-m4 mode.Marc Espie
2006-03-23Use TAILQ_HEAD() macro instead of custom struct definition.Ray Lai
From Pierre-Yves Ritschard. OK xsa@
2006-03-23int variables can only hold up to INT_MAX, not UINT_MAX.Ray Lai
``Go ahead'' deraadt@
2006-03-22plug an fd leak and closedir() two directories;Robert Nagy
ok otto@
2006-03-22remove IV support from the CRC attack detector, OpenSSH has never usedDamien Miller
it - it only applied to IDEA-CFB, which we don't support. prompted by NetBSD Coverity report via elad AT netbsd.org; feedback markus@ "nuke it" deraadt@
2006-03-22simplify SSHFP example; ok jmc@Jakob Schlyter
2006-03-22Clean up some lint and -Wall.Kjell Wooding
Changed many signed types ->size_t for consistency. Also, fix some realloc usage. Original from <jasonrcrawford at gmail.com> (ok ray@) Additions and additional cleanup to fix some off_t -> size_t issue by me. "looks good" otto@
2006-03-22use strtonum() instead of home-grown balony; ok ottoTheo de Raadt
2006-03-22NetBSD - plug leak in generate_guard()David Hill
- plug leak in h_output(), coverity cid 100 NetBSD plug leak, coverity cid 98. NetBSD plug leak, coverity cid 94. ok ray@ jaredy@ moritz@
2006-03-22change ident_file() and ident_line() return type to void; OK ray@.Xavier Santolaria
2006-03-22Make sure open returns fd != 1, not fd > 0.Ray Lai
From Alexey Dobriyan. OK otto@
2006-03-22Clean up xfree() usage in rcs_choosefile().Ray Lai
OK xsa@
2006-03-21add support for `rcs -e[logins]'; "Looks good" ray@.Xavier Santolaria
2006-03-21Instead of duplicating rcs_suffixes and running strsep on it again,Ray Lai
just use the previous suffixes. Since all slashes were replaced with NULs, reading `suffixes' will give the first extension. OK xsa@
2006-03-21Allow creation of an RCS file if RCS_CREATE flag set.Ray Lai
OK xsa@
2006-03-20spacingTheo de Raadt
2006-03-20add limited support for format builtin in gnu-m4 mode, because I'm fedMarc Espie
up of patching it away in various autoconf derivatives. okay miod@
2006-03-20spacingTheo de Raadt
2006-03-20be strict with tolower() castingTheo de Raadt
2006-03-20spacingTheo de Raadt
2006-03-20cast xstrdup to propert u_char *Theo de Raadt
2006-03-20x11_fake_data is only ever used as u_char *Theo de Raadt
2006-03-20spacingTheo de Raadt
2006-03-20annoying spacing fixes getting in the way of real diffsTheo de Raadt
2006-03-20sprinkle some ARGSUSED for table driven functions (which sometimes must ↵Theo de Raadt
ignore their args)
2006-03-20sprinkle u_int throughout pty subsystem, ok markusTheo de Raadt