Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-01-08 | Fix possible use after free with long lines | Tobias Stoeckmann | |
Files with very long lines on machines with tight memory restrictions can provoke a failing realloc in expand_linebuf. This error condition was improperly handled, which could lead to a user after free bug by using the already freed linebuf variable again. with input by and okay guenther@ | |||
2022-01-08 | use status error message to communicate ~user expansion failures; | Damien Miller | |
provides better experience for scp in sftp mode, where ~user paths are more likely to be used; spotted jsg, feedback jsg & deraadt ok jsg & markus | |||
2022-01-08 | fix some corner-case bugs in scp sftp-mode handling of ~-prefixed | Damien Miller | |
paths; spotted by jsg; feedback jsg & deraadt, ok jsg & markus | |||
2022-01-08 | more idiomatic error messages; spotted by jsg & deraadt | Damien Miller | |
ok jsg & markus | |||
2022-01-08 | add a variant of send_status() that allows overriding the default, | Damien Miller | |
generic error message. feedback/ok markus & jsg | |||
2022-01-08 | refactor tilde_expand_filename() and make it handle ~user paths with no | Damien Miller | |
trailing slash; feedback/ok markus and jsg | |||
2022-01-08 | Indicate current default cipher | Kinichiro Inoguchi | |
2022-01-06 | allow hostbased auth to select RSA keys when only RSA/SHA2 are | Damien Miller | |
configured (this is the default case); ok markus@ | |||
2022-01-06 | add a helper function to match a key type to a list of signature | Damien Miller | |
algorithms. RSA keys can make signatures with multiple algorithms, so some special handling is required. ok markus@ | |||
2022-01-06 | log some details on hostkeys that ssh loads for hostbased authn | Damien Miller | |
ok markus@ | |||
2022-01-06 | log signature algorithm during verification by monitor; ok markus | Damien Miller | |
2022-01-06 | piece of UpdateHostkeys client strictification: when updating known_hosts | Damien Miller | |
with new keys, ignore NULL keys (forgot to include in prior commit) | |||
2022-01-06 | include rejected signature algorithm in error message and not the | Damien Miller | |
(useless) key type; ok markus | |||
2022-01-06 | make ssh-keysign use the requested signature algorithm and not the | Damien Miller | |
default for the keytype. Part of unbreaking hostbased auth for RSA/SHA2 keys. ok markus@ | |||
2022-01-06 | stricter UpdateHostkey signature verification logic on the client- | Damien Miller | |
side. Require RSA/SHA2 signatures for RSA hostkeys except when RSA/SHA1 was explicitly negotiated during initial KEX; bz3375 ok markus@ | |||
2022-01-06 | Fix signature algorithm selection logic for UpdateHostkeys on the | Damien Miller | |
server side. The previous code tried to prefer RSA/SHA2 for hostkey proofs of RSA keys, but missed some cases. This will use RSA/SHA2 signatures for RSA keys if the client proposed these algorithms in initial KEX. bz3375 Mostly by Dmitry Belyavskiy with some tweaks by me. ok markus@ | |||
2022-01-06 | convert ssh, sshd mainloops from select() to poll(); | Damien Miller | |
feedback & ok deraadt@ and markus@ has been in snaps for a few months | |||
2022-01-06 | prepare for conversion of ssh, sshd mainloop from select() to poll() | Damien Miller | |
by moving FD_SET construction out of channel handlers into separate functions. ok markus | |||
2022-01-06 | Free memory before assign to avoid leak | Kinichiro Inoguchi | |
CID 313263 313301 313322 | |||
2022-01-06 | Free memory if error occurred | Kinichiro Inoguchi | |
2022-01-06 | Remove NULL check before free | Kinichiro Inoguchi | |
2022-01-06 | Ignore windows without a size set (may be used for pane only), from | Nicholas Marriott | |
Anindya Mukherjee. | |||
2022-01-05 | add a comment so I don't make this mistake again | Damien Miller | |
2022-01-05 | fix cut-and-pasto in error message | Damien Miller | |
2022-01-05 | adjust Xr for fw_update to section 8; | Jason McIntyre | |
ok afresh sthen deraadt | |||
2022-01-05 | Add error checking for EVP_Digest*() to snmp(1). | Theo Buehler | |
ok martijn | |||
2022-01-05 | Wrap long lines and add some braces | Kinichiro Inoguchi | |
2022-01-05 | Check function return value | Kinichiro Inoguchi | |
2022-01-05 | Checking pointer variable with NULL | Kinichiro Inoguchi | |
2022-01-05 | Straightforward conversion to EVP_* on the heap. | Theo Buehler | |
ok martijn | |||
2022-01-05 | Use calloc instead of malloc | Kinichiro Inoguchi | |
suggested by tb@ | |||
2022-01-05 | Check NULL first and unindent the rest of the code | Kinichiro Inoguchi | |
suggested by tb@ | |||
2022-01-05 | Convert openssl(1) cms option handling | Kinichiro Inoguchi | |
Just applying new option handling and no functional changes. Referred to verify.c and using 'verify_shared_options'. ok and comments from jsing@ and tb@ | |||
2022-01-05 | allow selection of hash at sshsig signing time; code already supported | Damien Miller | |
either sha512 (default) or sha256, but plumbing wasn't there mostly by Linus Nordberg | |||
2022-01-05 | add missing -O option to usage() for ssh-keygen -Y sign; | Damien Miller | |
from Linus Nordberg | |||
2022-01-05 | move sig_process_opts() to before sig_sign(); no functional code change | Damien Miller | |
2022-01-05 | NULL deref when using find-principals when matching an allowed_signers | Damien Miller | |
line that contains a namespace restriction, but no restriction specified on the command-line; report and fix from Fabian Stelzer | |||
2022-01-05 | remove unused defines | Jonathan Gray | |
ok gnezdo@ | |||
2022-01-03 | note the -c runs sh -c; from nabijaczleweli | Jason McIntyre | |
2022-01-01 | uniq(1): miscellaneous style(9)-ish stuff | Scott Soule Cheloha | |
- Include what you use: + Add <strings.h> for strcasecmp(3). + Drop <errno.h>, unused. - Pull the "errstr" declaration out of the getopt(3) loop up to the top of main(). - Align the strtonum(3) error messages with the argument names in the uniq.1 manpage and the usage string. They are referred to as "chars" and "fields". - Trim some whitespace. - Return from main() instead of exit(3). - De-(void) fprintf(3). - Prefer getprogname(3) to __progname. | |||
2022-01-01 | uniq(1): bump numchars, numfields from int to long long | Scott Soule Cheloha | |
Also bump repeats from int to unsigned long long. While here, don't cast the result of strtonum() and unwrap some lines. | |||
2022-01-01 | spelling | Jonathan Gray | |
2022-01-01 | fix memleak in process_extension(); oss-fuzz issue #42719 | Damien Miller | |
2022-01-01 | uniq(1): freopen(3) stdin, stdout | Scott Soule Cheloha | |
uniq(1) defaults to stdin and stdout, has exactly one input and one output, and permits the user to replace the default input and/or the default output with a given file. freopen(3) is the right idiom in this context. Get rid of file() and the extra FILE pointers. Switch from fprintf(3) to printf(3). While here, const the "str" argument to show(). Thread: https://marc.info/?l=openbsd-tech&m=164078603312936&w=2 ok millert@ | |||
2022-01-01 | spelling | Jonathan Gray | |
ok dtucker@ | |||
2021-12-31 | Try to turn on less-capable mouse modes when turning on more-capable, to | Nicholas Marriott | |
increase the chances we get something even if the terminal doesn't support the one we really want. GitHub issue 3020. | |||
2021-12-28 | Fix printing of -- marker when using -A as noted by gnezdo@ | Otto Moerbeek | |
ok millert@ | |||
2021-12-28 | In io_write_buf() adjust the calculation of the multiplex message size | Claudio Jeker | |
so that the loop works even for buffers bigger than 0xffffff. The code does not produce such big buffers but better make the code correct. Reported by Blago Dachev (blago (at) dachev (dot) com) OK benno@ | |||
2021-12-26 | split method list search functionality from authmethod_lookup() into | Damien Miller | |
a separate authmethod_byname(), for cases where we don't need to check whether a method is enabled, etc. use this to fix the "none" authentication method regression reported by Nam Nguyen via bugs@ ok deraadt@ | |||
2021-12-26 | Check error returns for HMAC_* to appease coverity. | Theo Buehler | |
CID 345114 |