Age | Commit message (Collapse) | Author |
|
Pointed out and diff by Wolf, thanks!
Tweaked by me.
OK benno
|
|
ok deraadt@
|
|
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
|
|
JSMN_ERROR_NOMEM.
We then need to allocate more tokens and call the parser with its
current state again. It will continue where it left of.
For this to work we also need to pass in the old tokens from the
previous run and not just more space.
Found the hard way by Renaud Allard.
OK millert
|
|
OK tb
|
|
|
|
OK tb
|
|
OK benno
Input & OK tb
|
|
|
|
This uses less code and unveil(2) seems to be the better tool here.
The directory one chroots into needs to be carefully setup (they are
not) and comon wisedom is that root can break out of chroots.
There is probably nothing wrong with the chroot code because of pledge
but it still makes me feel uneasy.
input & OK on previous version mestre
OK on previous version deraadt
bug found, input & OK benno
|
|
back so there is no need to get a copy.
Clue & probably OK tb
|
|
|
|
It is missleading to call (parts of) acme-client staying root a bug.
Discussed with deraadt@
Non-RSA account keys are (probably) coming, so remove that as well
while here.
|
|
should do something if the key type on disk differes from the
configured keytype.
Mark this XXX for now.
|
|
|
|
Originaly from Renaud Allard following input from benno, tweaked by me.
OK benno
|
|
|
|
|
|
diff from Renaud Allard <renaud@allard.it>, ok to get in from florian@
|
|
|
|
One could always use them on the command line and acme-client would do
the right thing.
|
|
(ACME)" to be able to talk to the v02 Let's Encrypt API.
With this acme-client(1) will no longer be able to talk to the v01
API. Users must change the api url in /etc/acme-client.conf to
https://acme-v02.api.letsencrypt.org/directory
Existing accounts (and certs of course) stay valid and after the url
change acme-client will be able to renew certs.
Tested by Renaud Allard and benno
Input & OK benno
|
|
|
|
things more readable. otto notes that free() does some checks, but
in this case readability is better than complete cleanup.
ok florian@ deraadt@
|
|
the contents of its argument (on other platforms). Also strdup() the result,
because basename returns a pointer to static memory.
ok florian@
|
|
(it does not on OpenBSD) so we need to us a copy of the string. In
addition, copy the result of dirname() as well, because it's static
storage and if we call dirname() again it will be overwritten.
Original problem noted and fix suggested by Wolf (wolf AT wolfsden DOT
cz)
ok florian@
|
|
case-insensitive.
Pointed out by "Wolf" ( wolf at wolfsden.cz ), thanks!
OK benno
|
|
larger types really is a range reduction...
Almost any cast to (unsigned) is a bug.
ok millert tb benno
|
|
sthen suggested adding a random sleep (like we do with spamd) for the
example cron job;
help/ok sthen benno florian
|
|
ok florian@
|
|
Found and fix suggested by "Thomas L.", tom AT longshine AT web DOT de, Thanks!
ok florian@
|
|
ok florian@
|
|
|
|
move the check of existing "account ..." line from main.c to the parser.
ok deraadt@
|
|
|
|
/etc/examples/httpd.conf and /etc/examples/acme-client.conf (comming
soon) are better places.
Pointed out by & OK deraadt, OK benno
|
|
bonus: this exposed a few missing const qualifiers.
|
|
ok beck@ bluhm@ tb@
|
|
(and other lexers too)
This commit rectifies earlier change:
in the lex... even inside quotes, a \ followed by space or tab should
expand to space or tab, and a \ followed by newline should be ignored
(as a line continuation). compatible with the needs of hoststated
(which has the most strict quoted string requirements), and ifstated
(where one commonly does line continuations in strings).
OK deraadt@, OK millert@
|
|
"looks good" gilles@ halex@
|
|
ok florian
|
|
From Ross L Richardson, thanks
ok millert@
|
|
From Ross L Richardson
ok millert@
|
|
ok millert@
|
|
From Ross L Richardson
|
|
From Ross L Richardson
|
|
one must be present.
From Ross L Richardson, thanks
ok sthen@
|
|
As pointed out by sthen@, TLS isn't the only possible use.
From Ross L Richardson
ok shten@
|
|
From Ross L Richardson
ok sthen@
|
|
ok tb@
|