summaryrefslogtreecommitdiff
path: root/usr.sbin/bgpd
AgeCommit message (Collapse)Author
2006-05-02The pftable name to ID functions should use the pftable_labels list and notClaudio Jeker
the rt_labels list. Luckily this bug was not visible because of the way the pftable and rtlabel code works. Found by Thomas E. Spanjaard.
2006-04-26Remove unused _exists() function. It is not even used in my evil filter treeClaudio Jeker
so I doubt I will need it anytime soon. Additionally I think that the interface is dangerous as it bypasses the ref-counting.
2006-04-26Last argument to send_filterset() is a left-over from one of my not so cleverClaudio Jeker
ideas that will never be included and always set to 0. Kill it.
2006-04-26Remove filterset_names from bgpd.h and replace it with a function becauseClaudio Jeker
the table was already out of sync now. OK henning@
2006-04-25Mark fatal and fatalx as __dead from deraadt@Claudio Jeker
2006-04-21attr_init() should use attrhashsize and not pathhashsize. Found via a lintClaudio Jeker
cleanup diff from deraadt@.
2006-04-21msgbuf_writebound() and msgbuf_bounded() are leftovers from some ancientClaudio Jeker
mrt dump code. These functions are no longer used since we switched to filedescriptor passing. From deraadt@
2006-04-21Remove function prototype that was never used. From deraadt@Claudio Jeker
2006-04-18cannot see the string self in the ANNOUNCE STRING prod any more sinceHenning Brauer
self is a token now
2006-04-18Fix "announce self" that got broken by "nexthop self". Found by Thomas Bader.Claudio Jeker
OK henning@
2006-04-12messages on the routing socket have different headers - rt_msghdr,Henning Brauer
if_msghdr, etc. they only share the first 3 fields, and then differ. this leads to a bug in RTM_IFINFO handling. We did abort on rtm->rtm_errno != 0, but if_msghdr has no errno, so we look at something in the data part instead. Surprising that this didn't bite us before! So we must only do these checks for RTM_ADD/CHANGE/DELETE that actually use rt_msghdr. found whiel checking strange behaviour tony sarendal <dualcyclone@gmail.com> saw, and then totally strange behaviour on my amd64 hackbox. claudio ok
2006-04-12It is no longer allowed to change attributes in place. This corrupts theClaudio Jeker
attribute cache. Instead remove attribute and readd it after beeing changed. This should fix the "att_diff: equal attributes encountered" error seen by Tony Sarendal. OK henning@
2006-04-05remote_bgpid is stored in host byte order so a htonl() is needed when puttingClaudio Jeker
the value on the wire. This solves the backward originator-ids seend by Tony Sarendal. OK henning@
2006-04-04document set nexthop self, and improve that section whil eon it, claudio okHenning Brauer
2006-04-04add "set nexthop self", force nexthop to be set to own address even with IBGPHenning Brauer
requested & tested Falk Brockerhoff <fb@smartterra.de>, and tony sarendal tested this too. claudio ok
2006-03-23Document nexthop qualify via (bgp|default).Claudio Jeker
OK henning, additional input jmc@
2006-03-23Simplify the -s documentation and add /var/run/bgpd.sock to the FILES list.Claudio Jeker
help from jmc@
2006-03-22Change the way bgpd selects nexthops. Up until now every route was consideredClaudio Jeker
when calculating the nexthop. Now only non BGP routes and not the default route are used unless forced with the new config options nexthop qualify via bgp nexthop qualify via default This change is required for complex setups e.g. where an additional IGP is running. OK henning@
2006-03-22Add a new SHOW imsg to send optional attributes to bgpctl. This can be usedClaudio Jeker
to show communites in bgpctl output. Only send these messages if it they are requested to reduce the overhead for simple listings. Looks good henning@
2006-03-15In nexthop_compare() if the two passed pointers point to the same objectClaudio Jeker
the odds are better than good that there is no difference.
2006-03-15Sync usage with man page (sort arguments).Claudio Jeker
2006-03-15Document new -s path option to select an alternate path for the main controlClaudio Jeker
socket.
2006-03-15Allow the control socket to be changed on the command line. Useful if youClaudio Jeker
need to run multiple bgpds on a single box to simulate a IX. This helped me massivly debugging error reports. OK henning@
2006-03-15Fix a memory leak when communities are set or deleted. This seems to fixClaudio Jeker
Sylvain Coutant memory issues. A lot of patience and testing by Sylvain.
2006-03-13Fix for PR 5052. Be more careful about the announced networks we accept.Claudio Jeker
Make sure that at least the address family and the prefix length are sane. Reported and fix tested by Pete Vickers.
2006-03-08Document "set community delete ..." and sync that section with the oneClaudio Jeker
from the PARAMETERS section. ok henning@
2006-03-07Fix a bug reported by Xavier Beaudouin. On config reloads set parametersClaudio Jeker
inside group blocks were reset to default values. The problem was that group ids changed on reload as soon as a new peer was added to one group. Make sure that group ids remain the same over reloads a similar thing is already done for peer ids. ok henning@
2006-03-07"set attribute ..." in neighbor blocks needs better documentation.Claudio Jeker
With input from jmc@ and ok henning@
2006-03-07Use 65535 instead of 0xffff to specify the maximum number that can be usedClaudio Jeker
for the local part of communities.
2006-03-04Typos grab bag of the month, eyeballed by jmc@Miod Vallat
2006-02-25Document the softreconfig (in|out) switch. With help from jmc@Claudio Jeker
2006-02-23Use the new rtm_fmask feature to reset blackhole and reject routes onClaudio Jeker
RTM_CHANGE. Until now it was not possible to get rid of these flags. Until now a fib decouple, fib couple combo was needed to get rid from blackholed routes. OK henning@
2006-02-10Make it possible to turn suftreconfig in/out on or off. Default is on forClaudio Jeker
both directions. Manpage update follows. OK henning@
2006-02-09Implement "set community delete 65001:*" and friends. This will removeClaudio Jeker
communities from the path attributes. Useful to make sure that the ones you set later are set by a (evil) peer. OK henning@
2006-02-09When comparing community type, cast to u_int16_t. The same is done for theClaudio Jeker
AS. OK henning@
2006-02-09attr_free() should not modify others_len as it does not resize the othersClaudio Jeker
array. It just clears on entry by setting it to NULL and moving that NULL to the end of the array. With this it will be possible to remove attributes without readding them right afterwards. Because of this attr_diff() needs to be more careful because of passed NULL pointers. OK henning@
2006-02-08For now dump only stuff from the local-RIB into mrt table dumps.Claudio Jeker
Issue found by Andre Oppermann.
2006-02-08fix logic both in the decision when to re-init the capabilities negotiationHenning Brauer
structures
2006-02-05tweaks; ok claudioJason McIntyre
2006-02-04Document the new special community part "neighbor-as". OK henning@Claudio Jeker
2006-02-03If the aspath gets copied because it is modified use the copy for filterClaudio Jeker
matching. With this it is possible to make later filters depend on previous filter changes -- e.g. via community attributes.
2006-02-03Doh! Fix stupid copy paste error. Setting the community type to the AS insteadClaudio Jeker
of the more obvious type produces really funny errors and gives you some happy hours of debugging.
2006-02-02Implement new special community "neighbor-as". neighbor-as is expanded onClaudio Jeker
the fly to the remote AS of the current neighbor. This can be used to simplify rulesets in a dramatic way -- going from a script based nightmare down to a handfull rules. jajajaja henning@
2006-01-31Dynamic routes (PMTU, etc) are not redistributable even for IPv6.Claudio Jeker
Sure henning@
2006-01-24add -r to synopsis, and tweak its description a little;Jason McIntyre
2006-01-24introduce "bgpctl show summary terse", shows summary in an easy to parseHenning Brauer
format, intended for monitoring puposes. claudio ok
2006-01-24bgpd does not and will never support route flap damping as defined in theClaudio Jeker
mentioned RFC. Even RIPE (RIPE-229) realized that route flap damping should be considered evil.
2006-01-24Last bits for softreconfig in support. Now bgpd will automaticaly rei-filterClaudio Jeker
the RIB after a reload so you no longer need to clear sessions because you modified filters. Looks good henning@.
2006-01-24Functions in the poll() loop should only be moved around if there are noClaudio Jeker
side-effects. Revert last changes and make bgpctl reload work again.
2006-01-24Check if filter changed on a per peer basis. This should speed up theClaudio Jeker
table run done later as many filter evaluations can be skipped. From the softreconfig in tree. Looks good henning@