summaryrefslogtreecommitdiff
path: root/usr.sbin/cron
AgeCommit message (Collapse)Author
2016-01-11When caching the mtime of the spool directory and system crontab files,Todd C. Miller
stash a struct timespec, not just a time_t. Fixes a bug where cron could skip re-reading the spool after two consecutive changes.
2015-11-17Check pipe(2) return value; noticed by deraadt@Todd C. Miller
2015-11-17Check for setgid() failure before executing editor and warn ifTodd C. Miller
exec of shell + editor fails.
2015-11-15Clean up the remaining uses of stderr and perror() and use warn/errTodd C. Miller
and/or syslog depending on whether stderr is hooked up at the time. Also remove closelog() which is not needed since we are headed for exec. OK guenther@
2015-11-14Cleanup from unifdef: set sact.sa_flags to SA_RESTART instead ofTodd C. Miller
clearing it and then ORin in SA_RESTART.
2015-11-14Remove log_it() and call syslog(3) directly using the same format:Todd C. Miller
"(username) WHAT (details)". Logs due to normal operation (e.g. crontab operations or running commands) are logged at LOG_INFO like before. Actual errors are logged at LOG_ERR, less important things are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now that there is no log file to reopen.
2015-11-12new location for cron sockets; ok millertJason McIntyre
2015-11-12Use absolute paths in pathnames.h. There is no longer a need toTodd C. Miller
chdir(2) to the cron dir and cron(8) now changes to / via daemon(3). We no longer try to create/chmod the spool directories as they should be set correctly at install time. The setegid(crontab) has been moved to open_socket() so it is closer to the chmod(2) call that needs it. OK deraadt@ tedu@
2015-11-12Remove SIGNALS section now that the non-syslog code has been removed.Todd C. Miller
2015-11-12Move cron socket to /var/run/cron.sock. Client code will try the oldTodd C. Miller
location if the new one doesn't exist for now. In order to allow the fchown() to succeed, cron now sets its effective gid to crontab. OK jca@ deraadt@
2015-11-11Use warn/warnx and err/errx. OK jca@Todd C. Miller
2015-11-11Niether cron nor crontab need flock permission.Todd C. Miller
2015-11-11Remove obsolete utime() call. It predates the use of a socket toTodd C. Miller
prod cron into checking the spool dir.
2015-11-11Fix spool dir mode check to avoid extraneous chmod() calls.Todd C. Miller
2015-11-11For "crontab -u user -e" change the euid for the mkstemp() callTodd C. Miller
instead of calling fchown() after the fact. Fixes a pledge() issue. OK semarie@
2015-11-11exit on pledge failure, oopsTheo de Raadt
2015-11-09Remove unused xpid argument to log_it().Todd C. Miller
2015-11-09Update CRONDIR comment to reality.Todd C. Miller
2015-11-09Rename AT_DIR -> AT_SPOOL and SPOOL_DIR -> CRON_SPOOL to improveTodd C. Miller
readability.
2015-11-09Use fstatat() when checking the files in the at queue so weTodd C. Miller
don't need to chdir to the queue dir. OK guenther@
2015-11-09queue(3) instead of homegrown queues and lists. This also fixesTodd C. Miller
some potential memory leaks in error paths. OK guenther@
2015-11-08Quiet silly clang analyzer warning in calloc() usage.Todd C. Miller
2015-11-06Use __progname instead of the homegrown ProgramName.Todd C. Miller
2015-11-04Change cron from including all headers in every file to only includingTodd C. Miller
what each .c file needs. I have not removed cron.h since it will be used in a future clean up of the cron's .h files. OK nicm@
2015-11-04Remove unused LogFD variableTodd C. Miller
2015-11-04Change some globals from extern to static when they are not usedTodd C. Miller
outside their respective .c files. Also remove some unused defines. OK jung@
2015-11-03If pledge(2) fails use perror instead of log_it(RealUser, ...) sinceTodd C. Miller
RealUser has not been filled in yet.
2015-11-03It is only necessary to swap the effective gid when reading a file.Todd C. Miller
Since we got rid of TMPDIR support there's no need to swap gids when creating or unlinking the temporary file. OK deraadt@
2015-11-03Use send(MSG_NOSIGNAL) instead of mucking with the disposition of SIGPIPEPhilip Guenther
ok millert@
2015-11-02Use setegid() directly instead of swap_gids() / swap_gids_back().Todd C. Miller
OK jca@ nicm@
2015-10-31Split client-only (at, crontab) functions out of misc.c and intoTodd C. Miller
client.c. Move truly common functions into common.c. This avoids dead code in the at and crontab commands.
2015-10-31open_socket() is only used by cron proper so move to cron.cTodd C. Miller
2015-10-31swap_gids and swap_gids_back are only used by crontab.c soTodd C. Miller
move them there.
2015-10-29Also need exec to run the editor of course.Todd C. Miller
2015-10-29crontab needs "proc" for fork(2)Todd C. Miller
2015-10-29Use stravis(3) instead of a homegrown vis-like function.Todd C. Miller
OK nicm@
2015-10-29remove unused variablesTodd C. Miller
2015-10-29Convert env_get() into env_find() similar to __findenv() in libc.Todd C. Miller
Use env_find() in both env_get() and env_set() to find a var in envp. Remove now-unused strcmp_until() function.
2015-10-29Remove useless FACILITY define and use LOG_CRON directly.Todd C. Miller
Remove unneeded limits.h include.
2015-10-28pledgeTheo de Raadt
ok millert
2015-10-26Remove TMPDIR support, it is not really useful in crontab.Todd C. Miller
OK deraadt@
2015-10-26Use SOCK_NONBLOCK and SOCK_CLOEXEC instead of fcntl() calls.Todd C. Miller
OK guenther@
2015-10-26Remove some useless defines and the set_cron_uid() function.Todd C. Miller
OK jung@
2015-10-25Remove PIDDIR and PIDFILE missed in previous commit.Todd C. Miller
2015-10-25Remove cron.pid support. We still want to avoid multiple cronsTodd C. Miller
running so verify that if the cron socket exists nothing is listening on it. OK tedu@
2015-10-23remove some more ifdef mazinessTed Unangst
2015-10-06clear out some more legacy code and whatnotTed Unangst
2015-10-04remove stale comment. there is no need to avoid side effects from a "list"Ted Unangst
command, because this is not the ftp daemon
2015-10-03There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elementsTed Unangst
just to keep track of a single pid. Return it to the caller and make it their problem. ok deraadt millert
2015-10-03unifdef some features we will always have. ok benno zhukTed Unangst