Age | Commit message (Collapse) | Author |
|
|
|
is checked for NULL and a specific error/warning issued. Add
two such manual warning/error checks and kill those dmalloc
calls. And then there were none, so kill dmalloc(). Whew.
|
|
immediately before the use or the pointer is checked for NULL before
the call. And then there were none, so kill dfree().
|
|
wrappers around wrappers around calloc().
The purpose of the free() wrapper is to generate an error message
when free'ing NULL. But free_hash_bucket(), free_lease(), and
free_tree() are all called immediately after dereferencing the
pointer to be freed. Thus the error message will never be issued.
|
|
bites the dust.
|
|
|
|
new_subnet(), bite the dust.
|
|
around calloc() and end up producing duplicate error messages are
just confusing.
Eliminate new_hash_bucket(), new_lease(), new_leases(), new_group().
|
|
|
|
fixed.
Eliminate the function new_class() by expanding the only use
Use strdup() and calloc() rather than manually simulating them.
No functional change.
|
|
us from sending an icmp error along with the dhcp reply.
OK henning@
|
|
|
|
also reported upstream to dhcp dash bugs at isc dot org
|
|
Also add support for the "ipsec-tunnel" hardware type as described in
RFC 3456.
ok henning@ krw@ (but needs more testing from others)
|
|
krw@ jmc@ ok
|
|
not a generic name. we must use the right capitalization for this term.
ok jmc@
|
|
draft-raj-dhc-tftp-addr-option-05, req by Michael van der Westhuizen.
ok henning, krw, dlg
|
|
for an unused overload option. Noticed by mk@ when netbooting his
G4 mac mini.
So compact the options by shifting them over the unused option and
filling the end by DHO_PAD.
Tested by mk@.
|
|
I expected. They object if there are no bits set in the option
value. So just use DHO_PAD in the reserved space unless at least
one of the bits is set.
Various versions tested by Tobias Ulmer on OpenSolaris, matthieu@
on busybox's DHCP client, and Uwe Dippel on Solaris. All of which
failed before.
|
|
directly against -1 and do not use a < 0 test. OK henning@
|
|
incomplete buffer initialization and possible incorrect option
handling.
Thanks to Nick Bender
ok krw@ deraadt@
|
|
|
|
|
|
|
|
sync options were specified. OK deraadt@
|
|
from henric.
|
|
16 byte boundaries for maximum portability (somewhat similar to CMSG's)
ok beck
|
|
|
|
|
|
with the same configuration to be run on the same net and they will
keep their lease files/state in synch, and therefore allowing you to
run redundant dhcpd's. Synchronization code stolen from spamd, uses
an hmac key in /var/db/dhcpd.key if it exists.
ok krw@ deraadt@
|
|
While there, bail out quickly if no options can be stored, and avoid
overflow buffers if building a bootp reply.
Henning looked and didn't get upset. millert@ tested it for a few
days and liked the look of it. canacar@ glanced at it.
|
|
ok henning@ krw@
|
|
ok krw@ henning@
|
|
too large. Fixes a problem where a nicely crafted packet could crash
dhcpd. Nuke a superfluous declaration of store_options() while here.
Problem found and fix tested by Peter Hessler.
ok beck@ millert@ henning@
|
|
ok jmc@
|
|
discussion with krw, who hasn;t ok'd this diff, but we can change it if
he doesn;t like it;
started by mail from Max Hayden Chiz
|
|
|
|
the priority list. Add create_priority_list() and use it to
consistantly merge mandatory, supplied and default option priority
lists into a reliable and complete list of options sorted by priority.
No intended functional change other than ensuring all options
available are returned.
"looks good" henning@ "OK, fair enough" millert@
|
|
DHO_DHCP_USER_CLASS_ID entry to dhcp_option_default_priority_list[].
Reformat list of numbers at the end of dhcp_option_default_priority_list[]
so it is easy to see which options are defined. No functional change.
|
|
behaviour on several edge conditions.
Feedback, suggestion & "I like the approach" millert@
"excellent" henning@.
|
|
least as large as the minimum IP MTU.
ok canacar@ henning@ millert@
|
|
delete some blank lines, add some other blank lines, move expressions
so calculations done only once. Eliminate extraneous ++'s.
No functional change.
|
|
change.
ok beck@
|
|
buffer. Actually use the second overflow buffer now that bufix is correct
and the test for remaining options will work correctly.
ok beck@
|
|
DHO_PAD (a.k.a. 0). Eliminate manual DHO_PAD'ing after DHO_END is put
into the buffer.
ok beck@
|
|
buffer. Spotted by canacar@ and others.
ok beck@
|
|
are used. It should reflect the end of the main options buffer rather than
the start of the options copied into it.
ok beck@
|
|
the size of the outgoing packet's options field. Spotted by canacar@.
ok beck@
|
|
dhcpd are the minimum size or larger no matter what the client thinks
the minimum allowable size is. Found by Nahuel Riva and Gera Richarte.
Fix by millert@.
|
|
"-L leased" wouldn't work without "-A abandoned".
testing help from merdely
"i like" deraadt
|