summaryrefslogtreecommitdiff
path: root/usr.sbin/lpr
AgeCommit message (Collapse)Author
2002-06-23uid_t and gid_t are unsignedTheo de Raadt
2002-06-19stretch some ugly while();Theo de Raadt
2002-06-14spelling; from Brian Poole <raj@cerias.purdue.edu>Todd T. Fries
2002-06-13Fixed some lpd bugs while on the plane from Calgary:Todd C. Miller
o mark fatal() as __dead o add SIGINT to the signal mask when installing abort() as a handler. We can end up in abortpr() due to several different signals and since abortpr() kill()s itself with SIGINT we need to explicately protect against the current process receiving SIGINT while in abortpr() o Don't leak the lock fd to children spawned by lpd o Close the lock file (and thus unlocke immediately in abortpr(). Otherwise, if there is an output filter the lock file only gets closed after we finish waiting for the output filter to die. This causes a race condition in lprm such that the per-printer daemon does not get restarted when lprm kills the active job (noticed during c2k2 with the mp3 printer spool ;-) o Open the printcap file with privs raised just in case it is not world-readable.
2002-06-11lprm needs to be setuid daemon after allTodd C. Miller
2002-06-09Better fix for correct queue printing when things have been moved around.Todd C. Miller
2002-06-09Don't print jobs in transit to a remote queue as being "active"Todd C. Miller
2002-06-09Convert remaining K&R function headers to ANSITodd C. Miller
2002-06-09o Kill "garbage" global (unused)Todd C. Miller
o Kill "rank" global (doesn't need to be global) o Make inform() static (local to displayq.c) o Pass in rank to inform() based on index within sorted mtime array o Simplify compar()
2002-06-08o Replace some hard-coded octal constants w/ S_I*Todd C. Miller
o Remove some unneeded casts to char * when calling free()
2002-06-08use the dirfd macro instead of reaching into the DIR and pulling out dd_fdTodd C. Miller
2002-06-08make this actually compileTodd C. Miller
2002-06-08Force lpd socket to be mode 0660, group daemonTodd C. Miller
2002-06-08Remove some debugging codeTodd C. Miller
2002-06-08Remove setuid root from lp*. lpr needs to be setuid daemon so theTodd C. Miller
files it creates are not owned by the user spooling them but the others (lpc, lpq, lprm) can get away with setgid daemon. lpd runs as user daemon for most things, only changing its uid to 0 for things that must be done as root. For the time being, don't require connections to come from a reserved port since lpq/lpr/lprm can't acquire that w/o setuid root. In the near future we will have a mechanism for select non-root processes to grab reserved ports. The upshot of this is that spool directories must be writable by group daemon and the files within the spool dirs must be owned by daemon.
2002-05-28Repair remote printing; maxfd was not set correctly for remote connections.Todd C. Miller
2002-05-28Remove useless sigaddset()Todd C. Miller
2002-05-22unlink lpd.pid if killed by a signalTodd C. Miller
2002-05-22Use O_EXLOCK in open() instead of flock() to eliminate a potential lockingTodd C. Miller
race on the pid file.
2002-05-20Pull in useful bits from NetBSD and make our lp* easier to diff andTodd C. Miller
do some minor cleanup of my own: o IPv6 support o ANSI function headers o use getopt() o synce usage() with man pages o passes -Wall on both 32bit and 64bit platforms o add an option to set the max number of children lpd will fork off o add an lpd option to bind to specific addresses instead of INADDR_ANY. o allow user to specify how long to wait for a connection to remote servers o more strlcpy() and snprintf() usage o Use FOO_FILENO constants instead of hard-coding 0-2 o Add some keeps to man the page SYNOPSIS to avoid options being split
2002-05-18Update paths from 4.3BSD to 4.4BSD; partially from NetBSDTodd C. Miller
2002-02-24getc, getchar, etc return an int, not a charPeter Valchev
2002-02-19We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.Todd C. Miller
2002-02-17Manual cleanup of remaining userland __P use (excluding packages maintained ↵Todd C. Miller
outside the tree)
2002-02-16Part one of userland __P removal. Done with a simple regexp with some minor ↵Todd C. Miller
hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
2002-02-13When you give command examples and etc., in a manual page prefix them with:Mike Pechkin
$ command or # command deraadt@ ok
2002-01-21s/deamon/daemon/Theo de Raadt
2002-01-07Revert local changes that should not have been committedTodd C. Miller
2002-01-07To disable a SIGCHLD signal handler use SIG_DFL, *not* SIG_IGNTodd C. Miller
which now has a different meaning.
2001-12-06use err/warn and friends instead of printf/exit.Eric Jackson
also, remove fatal2() which is just errx anyway. millert@ ok
2001-11-27Fix check for '/' in cf file and change the check for '/' in df fileTodd C. Miller
for consistency. Based on a patch from Sebastian Krahmer.
2001-11-23use the same siginterrupt() trick in lpc(1) as in timedc(1). we have to hackTheo de Raadt
a global into the other programs since they share some source.
2001-11-19only slight fixes needed in signal handlersTheo de Raadt
2001-11-19use _exit in signal handlerTheo de Raadt
2001-11-01displayq to honor the terminal width; millert@ okMichael Shalayeff
2001-10-29MacOS 10.1 lpr clients send a format character of "o" to indicate ↵Theo de Raadt
postscript; jabley@automagic.org
2001-09-19occured->occurredMike Pechkin
idea from deraadt@ via NetBSD millert@ ok p.s. Next commit will fix a typo in the sys/
2001-09-05do not select(20, ...)Theo de Raadt
2001-09-04Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their ↵Todd C. Miller
POSIX counterparts.
2001-08-30When using dup2() to make a socket be stdout, first check that itTodd C. Miller
is not already stdout (fd 1). Otherwise we end up closing stdout which is not the intention. Also use STDOUT_FILENO instead of 1. From a conversation with huntting@glarp.com.
2001-08-30o kill registerTodd C. Miller
o add const to rcsid and copyright strings o placate -Wall
2001-08-30Better buffer lengths (MAXFOO and FOO_MAX) based on a patch fromTodd C. Miller
ianm@cit.uws.edu.au.
2001-08-30Use NAME_MAX, not MAXPATHLEN for buffer sizes since they are notTodd C. Miller
full paths (cannot contain a slash). From discussion with drosih@rpi.edu
2001-08-29Fix buffer oflow reading from queue file. While we are at it, crankTodd C. Miller
the size of buffers that can hold filenames to MAXPATHLEN.
2001-07-09correct type on last arg to execl(); nordin@cse.ogi.eduTheo de Raadt
2001-06-25Fix a bunch of one-byte possible overflowsPaul Janzen
2001-06-25A little more careful with buffers, only relevant if /etc/printcap was setPaul Janzen
up insanely wrong.
2001-06-22use strlcpy vs strncpy+a[len-1]='\0'lebel
2001-04-05another euid mixup; wiz@danbala.ifoer.tuwien.ac.atTheo de Raadt
2001-04-04missung euid swapout; j@ida.interface-business.deTheo de Raadt
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-16 22:09:29 +0000