summaryrefslogtreecommitdiff
path: root/usr.sbin/npppd
AgeCommit message (Collapse)Author
2022-08-29static inline, not inline staticJonathan Gray
c99 6.11.5: "The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature." ok guenther@
2022-07-01Remove PIPEXCSESSION ioctl(2) call only from npppd(8).Vitaliy Makkoveev
Long time ago pipex(4) sessions can't be deleted until pipex(4) queues become empty. Such dead sessions stay linked to the stack and the session `ip_forward' flag was used to prevent packets processing. But now pipex(4) session could be closed just after close request. This logic became unnecessary. PIPEXCSESSION ioctl(2) will be removed from kernel with upcoming diff. ok yasuoka@
2022-03-31man pages: add missing commas between subordinate and main clausesChristian Weisgerber
jmc@ dislikes a comma before "then" in a conditional, so leave those untouched. ok jmc@
2022-03-10authentcation -> authenticationJonathan Gray
2022-01-07npppd: convert to EVP_MD_CTX on heapTheo Buehler
In the upcoming libcrypto bump, EVP_MD_CTX will become opaque, so all EVP_MD_CTX variables will need to be moved from the stack to the heap. This is a mechanical conversion which also switches from EVP_Digest{Init,Final}() to their _ex() versions as suggested by millert. We cannot do error checking since this code is structured in several layers of void functions. This will have to be fixed by someone else. ok millert
2021-11-15No need to declare optind, optarg or opterr; unistd.h does this for us.Todd C. Miller
From Jan Stary. OK deraadt@
2021-10-15Don't declare variables as "unsigned char *" that are passed toChristian Weisgerber
functions that take "char *" arguments. Where such chars are assigned to int or passed to ctype functions, explicitly cast them to unsigned char. For OpenBSD's clang, -Wpointer-sign has been disabled by default, but when the parse.y code was built elsewhere, the compiler would complain. With help from millert@ ok benno@ deraadt@
2021-05-22Remove ipsec_utils.c, its headers, and the code block which use itYASUOKA Masahiko
from npppd(8). They had been disabled for long time.
2021-03-29spellingsYASUOKA Masahiko
suggested by jsg
2021-03-10Expand the maximum length for CHAP challenge to 96 octets. npppdYASUOKA Masahiko
couldn't handle ICCN message which has a ProxyAuthenChallenge AVP longer than 24 octets. Juniper actually send such challenges. Reported and tested by Ryan Freeman.
2021-03-10Fix "phone number" spelling.Patrick Wildt
ok yasuoka@
2021-03-05Fix some heap over-read in logging in PPTP protocol handler.YASUOKA Masahiko
2021-02-01Remove dummy TUNSIFMODE ioctl(2) call from pppac(4) and npppd(8). Sincemvs
OpenBSD 6.7 npppd(8) can't work over tun(4). ok yasuoka@
2021-01-02Remove PIPEX{S,G}MODE ioctl(2) commands. This time they are pretty dummymvs
and were kept only for backward compatibility reasons. ok mpi@ yasuoka@
2020-12-30The result of getifaddrs() not used in pppoed_reload(). Remove it.Sebastian Benoit
ok mvs@ kn@
2020-12-30getifaddrs() can return entries where ifa_addr is NULL. Check for thisSebastian Benoit
before accessing anything in ifa_addr. ok claudio@
2020-08-09Some times ago we disabled in-kernel timeout for pppx(4) relatedmvs
pipex(4) sessions. We did this for prevent use after free issue caused by pipex_timer(). By default "idle-timeout" is not set in npppd.conf(5) and I guess this is reason for we forgot to describe this exception in npppd.conf(5). Since it's pppx(4) related bug description was added to BUGS section of pppx(4) man page. npppd.conf(5) has this exception described in "idle-timeout" section. ok jmc@ yasuoka@
2020-06-22Install npppd.conf(5) with mode 0600 instead of 0640. npppd.conf(5) canmvs
store radius passwords and nothing requires it to be group readable. ok yasuoka@
2020-06-13remove the reference to tun(4), as suggested by kaya saman,Jason McIntyre
and advised by dlg;
2020-06-09Prepare buffer for both receive and transmit side so that a client canYASUOKA Masahiko
use them separately. Actually a version of CISCO does and expects the peer does the same. Also fix some typos.
2020-04-23replace examples of "Ic arg Ic arg" with "Ic arg arg" and stop the spread;Jason McIntyre
2020-04-01Put the interface down if the kernel fails to enable pipex.Martin Pieuchot
This is necessary to not silently continue if pppx_ioctl() returns an error. Found out by and diff from Vitaliy Makkoveev. ok yasuoka@
2020-01-23do not Xr both pppx and pppac in SEE ALSO, since they are the same page;Jason McIntyre
2020-01-23use pppac(4) instead of tun(4)David Gwynne
2020-01-23allow npppd to use pppac(4) (once i wire it up)David Gwynne
2019-09-02More correction of section 3 layout. directory->opendir, fts->fts_open,Theo de Raadt
getcap->cgetent. pwcache->user_from_uid. And then repair references. ok jmc
2019-05-10Delete superfluous #includes of <ifaddrs.h>, <net/if_dl.h>, and <net/if_enc.h>Philip Guenther
ok krw@, jsg@
2019-04-08macro fix;Jason McIntyre
2019-03-10fix some cases of spaces before full stops, where none were neccessary;Jason McIntyre
2019-02-27remove unused includesdenis
OK yasuoka@
2019-02-22errror -> error in log messages; from alessandro galloJason McIntyre
2019-02-20fix attribute namedenis
2019-02-13(unsigned) means (unsigned int) which on ptrdiff_t or size_t or otherTheo de Raadt
larger types really is a range reduction... Almost any cast to (unsigned) is a bug. ok millert tb benno
2019-01-22PF_ROUTE -> AF_ROUTE in the scattered sock()/setsockopt() callsKenneth R Westerback
where the "wrong" #define was used. ok dlg@
2018-12-30Delete unnecessary <libgen.h> #includesPhilip Guenther
ok deraadt@
2018-11-01- odd condition/test in PF lexerAlexandr Nedvedicky
(and other lexers too) This commit rectifies earlier change: in the lex... even inside quotes, a \ followed by space or tab should expand to space or tab, and a \ followed by newline should be ignored (as a line continuation). compatible with the needs of hoststated (which has the most strict quoted string requirements), and ifstated (where one commonly does line continuations in strings). OK deraadt@, OK millert@
2018-07-25Fix the prefix length of the IP address in the error message which showsYASUOKA Masahiko
failure of assigning requested IP address on IPCP, it was mistakenly "-1" on little endians. Found by IIJ.
2018-07-09No need to mention which memory allocation entry point failed (malloc,Kenneth R Westerback
calloc or strdup), we just need to log that we ran out of memory in a particular function. Recommended by florian@ and deraadt@ ok benno@ henning@ tb@
2018-07-08Be consistent in warn() and log_warn() usage whenKenneth R Westerback
running out of memory. Next step, be correct *and* consistent. ok dennis@ tb@ benno@ schwarze@
2018-06-18remove the SECTIONS header, since a one line DESCRIPTION is a bit silly;Jason McIntyre
use a more general text for the sections, and avoid the catchup issue that was trying to document how many there were; ok benno rob
2018-03-16Consistently spell "IPsec" in comments and debug outputs.Martin Pieuchot
From Raf Czlonka, ok sthen@
2018-01-05Remove useless <sys/socketvar.h> includes.Martin Pieuchot
ok kettenis@, visa@, claudio@, deraadt@
2017-10-06The problem when npppd receives a zero length 1701/udp packet seemed toYASUOKA Masahiko
be fixed at 1.16, but it wasn't fixed. Fix it again.
2017-08-12add a new option to set limits on max-sessions each IPCP.Kazuya Goda
It can set limits on different max-sessions if there're using several protocols such as PPPoE and L2TP/IPsec. ok yasuoka@
2017-08-11add a new option to set limits on user-max-sessions each AUTHENTICATION.Kazuya Goda
It can set limits on different user-max-sessions if there're using several protocols such as PPPoE and L2TP/IPsec. ok yasuoka@
2017-08-11display MRU each sessions in npppctl session commandKazuya Goda
ok yasuoka@
2017-07-13man pages with pseudo synopses which list filenames end up creatingJason McIntyre
very ugly output in man -k; after some discussion with ingo, we feel the simplest fix is to remove such SYNOPSIS sections: the info is hardly helpful at page top, is contained already in FILES, and there are sufficiently few that just zapping them is simple; ok schwarze, who also helpfully ran things through a build to check output;
2017-07-03no need to generate y.tab.h if nothing uses it, set YFLAGS to nothingMarc Espie
instead of CLEANFILES += y.tab.h okay millert@
2017-05-30Remove never used ifdefs, define FATAL macro properly and define functionYASUOKA Masahiko
parameters in modern way.
2017-05-30Stop using __P macro.YASUOKA Masahiko