Age | Commit message (Collapse) | Author |
|
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
|
|
ok benno@
|
|
reads OK to kn@
OK denis@
|
|
substract the size of the IPv6 header and not the IPv4 header from the MTU.
This stops ospf6d to send out fragmented packets.
Found with and OK benno@
|
|
ok krw@, jsg@
|
|
the daemon wouldn't notice state changes for those interfaces.
ok benno@
|
|
ok benno@
|
|
larger types really is a range reduction...
Almost any cast to (unsigned) is a bug.
ok millert tb benno
|
|
overwrite this when using "redistribute X set type 2 depend on ifX" and ifX
is down.
Problem reported for ospfd by Igor Podlesny.
ok benno@
|
|
OK millert, deraadt, job
|
|
RTP_OSPF (or the configured fib-priority) inserted by another program.
ospfd does the same.
OK claudio@ benno@
|
|
inserts into the kernel routing table.
OK denis@
|
|
than 128. Initially proposed by claudio@ for bgpd.
ok claudio@
|
|
(and other lexers too)
This commit rectifies earlier change:
in the lex... even inside quotes, a \ followed by space or tab should
expand to space or tab, and a \ followed by newline should be ignored
(as a line continuation). compatible with the needs of hoststated
(which has the most strict quoted string requirements), and ifstated
(where one commonly does line continuations in strings).
OK deraadt@, OK millert@
|
|
filesystem access with the exception of the control socket cleanup on
exit.
ok florian@
|
|
"looks good" gilles@ halex@
|
|
control socket.
ok florian@
|
|
|
|
small quirk from tb@
ok phessler@
|
|
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.
ok friehm@ jca@
|
|
ok jca@ tb@
|
|
out of memory log_warn(). i.e. ("%s", __func__) instead of manual
function names and redundant verbiage about which wrapper detected the
out of memory condition.
ok henning@
|
|
Looks great! deraadt@
OK florian
OK remi@
|
|
may become gateway routes and contrary. The kernel does not allow to change the
flags RTF_GATEWAY / RTF_CLONING in RTM_CHANGE messages, but ospf6d tried this
anyway. The result is a broken route.
Instead of modifying such routes remove the old route and insert a new one.
Thanks to Raimund Specht for reporting the problem and testing the fix.
OK claudio@
|
|
OK claudio@
|
|
but only when -v is used.
ok jca@ claudio@
|
|
calloc or strdup), we just need to log that we ran out of memory in a
particular function.
Recommended by florian@ and deraadt@
ok benno@ henning@ tb@
|
|
running out of memory.
Next step, be correct *and* consistent.
ok dennis@ tb@ benno@ schwarze@
|
|
use a more general text for the sections, and avoid the catchup issue
that was trying to document how many there were;
ok benno rob
|
|
This is similar to what ospfd does.
ok jca@
|
|
ok jca@
|
|
Thanks to otto@ for the initial diff.
OK benno@, remi@
|
|
go ahead jca@
OK claudio@
|
|
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases
go ahead jca@
OK claudio@
|
|
ok benno@
|
|
in packet loss on busy and big networks and therefor to instability.
From camield@
|
|
The IF_EVT_NBR_CHNG event needs to be fired when a neighbor transitions to
a state of 2-Way or higher. There is no need to trigger the event for new
neighbors. With this situations with multiple DRs after a netsplit should
be solved.
OK sthen@ and remi@
|
|
Same is done in ospfd for quite a while.
|
|
found while investigating routing socket desync with claudio.
ok remi jca claudio
|
|
the desync cases. OK benno@
|
|
And fixing this doesn't appear trivial. Discussed with a bunch at
p2k17, ok phessler@ denis@ benno@
|
|
|
|
ok florian@ claudio@
|
|
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.
OK bluhm@ claudio@
|
|
OK bluhm@
|
|
warn with the same severity. Switch log_warn() to LOG_ERR and keep
fatal() at LOG_CRIT.
OK reyk@ florian@
|
|
ok claudio
|
|
TAILQ_FOREACH().
No intentional functional change.
ok reyk@
|
|
modern TAILQ_FOREACH_SAFE().
No intentional functional change.
ok millert@ bluhm@ gilles@
|
|
with more modern TAILQ_FOREACH(). This what symget() was already
doing.
Add paranoia '{}' around body of symget()'s TAILQ_FOREACH().
No intentional functional change.
ok bluhm@ otto@
|