summaryrefslogtreecommitdiff
path: root/usr.sbin/ospfd
AgeCommit message (Collapse)Author
2020-05-06Do not use the pointer returned by ibuf_reserve() after calling anotherClaudio Jeker
ibuf function. After the call the internal buffer may have moved by realloc() and so the pointer is invalid. Instead use ibuf_size() to get the current offset in the buffer and use ibuf_seek() later on to write back the updated lsa age into the buffer at the right spot. This fixes an issue seen by Richard Chivers on routers with many passive interfaces. OK stsp@ deraadt@
2020-04-23replace examples of "Ic arg Ic arg" with "Ic arg arg" and stop the spread;Jason McIntyre
2020-03-29Change space to tabdenis
2020-02-10briefly mention /etc/examples/ in the FILES section of all theIngo Schwarze
manual pages that document the corresponding configuration files; OK jmc@, and general direction discussed with many
2020-01-21Allow the interface setting "type p2p" to be configured globallz or perremi
area. Most of the other interface settings allow this. ok denis@
2020-01-08Area-wide interface parameters need to be defined before the interfacesremi
or they will have no effect. OK denis@
2019-11-23These dependon related lines fit better a bit further up.remi
No functional change. Suggested and OK claudio@
2019-11-19Add point-to-point support for broadcast interfaces.remi
tested by Kapetanakis Giannis ok claudio@
2019-11-10Consistently use _rcctl enable foo_ in examples, it's simpler and lessLandry Breuil
error prone than manually editing rc.conf.local, and also works to enable ipsec and accounting. tweak from schwarze@ to use the \(dq\(dq syntax for quotes in '.Dl foo_flags="" lines' instead of \&"\&". while at it, fix a reference to a bogus /dev/dhclient.conf file that recently snuck in. ok jmc@ deraadt@ schwarze@
2019-11-09Fix function name in error message.denis
input & OK claudio@
2019-08-12On broadcast and point-to-point interfaces only accept hello packets whenremi
the destination is 224.0.0.5 (AllSPFRouters). RFC 2328 sys in "9.5. Sending Hello packets" that hello packets are sent to the multicast address AllSPFRouters on broadcast and physical point-to-point networks. With this new check the test for AllDRouters is not needed anymore. ok benno@
2019-08-12Warn when a neighbor changes its source IP address. Either it is becauseremi
of a planned change or something bad is happening in the network. ok benno@
2019-07-15Improve logging when sending a packet fails.remi
OK claudio@
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-06-10less macro;Jason McIntyre
2019-06-10document that area can take a number as well as an idDavid Gwynne
reminded by and ok remi@
2019-06-07Allow specifying area by number as well as id. No change to outputs.David Gwynne
ok remi@ (who did the same change to ospfctl, ospf6d, and ospf6ctl) ok denis@ some grumbling from sthen@ and bluhm@ who didn't want output changed.
2019-05-16Do not change router-id on reload if unspecified.denis
OK remi@
2019-04-29Check that depend on interfaces are in the same rdomain. If they are notremi
the daemon wouldn't notice state changes for those interfaces. ok benno@
2019-04-23whitespace fixremi
2019-04-23Use the network address instead of the interface address for the "link id"remi
of P2P interfaces "stub net" LS. This is related to revision 1.77 of rde_spf.c. Problem reported by Mitchll Krome on tech@. ok benno@
2019-04-23For originating router LSAs for P2P interfaces check for linkstateremi
instead of IF_STA_POINTTOPOINT. This makes "passive" work on P2P interfaces. Also add the "depend on" logic. Bug reported by stsp@ ok stsp@ benno@
2019-04-04RFC 2328 mandates in 12.4.1.1 that the Link ID of the Type 3 link has toremi
be set to the subnet's IP address and not the interface address. Bug report and fix from Mitchell Krome. OK claudio@
2019-03-26The recently introduced "router-id changed" warning is a bit long.remi
Shorten it to better match the style of other log messages. ok jca@
2019-03-25Abort reload if router-id changedJeremie Courreges-Anglas
Additional code would be needed to support actually changing the router-id at runtime; for now be consistent and reject the new configuration to avoid users a "wtf" moment. From Mitchell Krome, input from benno@ and deraadt@, ok benno@
2019-02-13(unsigned) means (unsigned int) which on ptrdiff_t or size_t or otherTheo de Raadt
larger types really is a range reduction... Almost any cast to (unsigned) is a bug. ok millert tb benno
2019-01-15For external LSAs the type (1 or 2) is encoded in the metric field. Do notremi
overwrite this when using "redistribute X set type 2 depend on ifX" and ifX is down. Problem reported for ospfd by Igor Podlesny. ok benno@
2019-01-14Improve error message when daemon is already running.Florian Obser
OK millert, deraadt, job
2019-01-02Send a router LSA update when an interface was removed.remi
OK claudio@
2018-12-28Add config option fib-priority to set a custom prio for routes ospfdremi
inserts into the kernel routing table. OK claudio@
2018-11-01- odd condition/test in PF lexerAlexandr Nedvedicky
(and other lexers too) This commit rectifies earlier change: in the lex... even inside quotes, a \ followed by space or tab should expand to space or tab, and a \ followed by newline should be ignored (as a line continuation). compatible with the needs of hoststated (which has the most strict quoted string requirements), and ifstated (where one commonly does line continuations in strings). OK deraadt@, OK millert@
2018-10-29The parent process of ospfd is not supposed to write or execute files.remi
Unveil "/" readonly and allow to cleanup the control socket on exit. Just unveiling ospfd.conf is not possible since it can contain an arbitrary number of includes. ok benno@
2018-09-27whitepspace fixSebastian Benoit
2018-09-07replace malloc()+strlcpy() with strndup() in cmdline_symset().miko
"looks good" gilles@ halex@
2018-08-29Prevent ospfd from starting if another ospfd is already using the sameremi
socket. The check on the control socket happens early so that the rc scripts detect a failure. OK claudio@ florian@
2018-07-27remove errant Ed added in previous;Jason McIntyre
2018-07-26note under which circumstances ospfd uses the route priofilterSebastian Benoit
to not receive all route messages, thus saving cpu time. wording as suggested by jmc@ ok remi@ jmc@ claudio@
2018-07-11Print the rdomain config option if present.remi
ok kn@ tb@ deraadt@ sthen@ jca@
2018-07-11Change the control socket to ospfd.sock.<rdomain>.remi
ok friehm@ jca@
2018-07-11Do for most running out of memory err() what was done for most runningKenneth R Westerback
out of memory log_warn(). i.e. ("%s", __func__) instead of manual function names and redundant verbiage about which wrapper detected the out of memory condition. ok henning@
2018-07-10Since we use multiple cloning routes (mpath) if more than one ip addressfriehm
exists in the same network, the routes are distinguished by their gateway address, which is the associated interface address. The ospfd has to track the gateway addresses so that kroute_matchgw() is able to find the correct routes. OK claudio@
2018-07-09Set log_setverbose(1) early to see debug logs during parsing the configremi
but only when -v is used. ok jca@ claudio@
2018-07-09No need to mention which memory allocation entry point failed (malloc,Kenneth R Westerback
calloc or strdup), we just need to log that we ran out of memory in a particular function. Recommended by florian@ and deraadt@ ok benno@ henning@ tb@
2018-07-08Be consistent in warn() and log_warn() usage whenKenneth R Westerback
running out of memory. Next step, be correct *and* consistent. ok dennis@ tb@ benno@ schwarze@
2018-06-25Add IMSG_IFADDRADD to ospfe and the master process.remi
This allows ospfd to recover automatically when an ip address gets removed and re-added as it happens when the netstart script is executed on a running system. previous attempt discussed with friehm@ last year input from sthen@ and jca@ OK jca@
2018-06-18remove the SECTIONS header, since a one line DESCRIPTION is a bit silly;Jason McIntyre
use a more general text for the sections, and avoid the catchup issue that was trying to document how many there were; ok benno rob
2018-06-11Fix an off-by-one line count when using include statements.denis
Thanks to otto@ for the initial diff. OK benno@
2018-04-26Plug leak in error case of the common 'varset' implementations.Kenneth R Westerback
ok benno@
2018-03-11Increase SO_RCVBUF of the ospf socket to 256k having this buffer can resultClaudio Jeker
in packet loss on busy and big networks and therefor to instability. Also adjust the SO_SNDBUF to real 64k just for consistency. From camiel@
2018-02-22The IF_EVT_NBR_CHNG event needs to be fired when a neighbor transitions toClaudio Jeker
a state of 2-Way or higher. There is no need to trigger the event for new neighbors. With this situations with multiple DRs after a netsplit should be solved. OK sthen@ and remi@
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 01:02:07 +0000