Age | Commit message (Collapse) | Author |
|
"Let msgbuf_write return -1 with errno EAGAIN. The users then must
check if this was the case and readd the event or poll again. The
current handling in the imsg code is wrong for sure."
ok gilles, benno
|
|
|
|
the same. This will drop updates trying to attack the OSPF LSDB. For
ospfd such bad router LSA were never a problem since the LSA lookup always
includes the ls_id and adv_rtr -- so the bad packets would have never been
picked up by the SPF calculation.
OK bluhm@ benno@
|
|
From: Jan Stary
|
|
|
|
|
|
in a cleanup in r1.83, but we do still want to announce these (with a high
metric), so that a specific route to the relevant network is maintained
during failover. ok florian@ claudio@
|
|
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are.
ok's from various maintainers of these directories...
|
|
ok florian@
|
|
than showing hello timers/keys. ok florian@
|
|
- don't start a new snapshot if we are already in NBR_STA_SNAP
- ignore IMSG_DB_SNAPSHOT and IMSG_DB_END unless we are in NBR_STA_SNAP
- add new IMSG_LS_SNAP message so we can distinguish it from
IMSG_LS_UPD. this way we can ignore them if we are not in NBR_STA_SNAP
ok claudio@
|
|
|
|
|
|
|
|
|
|
interface address, since there is no DR and multicast messages to
the DR will be ignored. see RFC 2328, 13.3(5)
ok claudio@
|
|
processed all received DDs (dd_pending == 0), so we need to check
for state != NBR_STA_XCHNG; ok claudio@
|
|
(would change back to NBR_STA_XSTRT anyway)
ok claudio@
|
|
references into a STANDARDS section;
|
|
is checked a few lines below again. Fewer checks make the code
more readable.
ok stsp@
|
|
|
|
Rafael Zalamena on tech@, I also applied it to ospfd. ok phessler@
|
|
characters;
prompted by a diff from robert peichaer org
thanks gilles and henning for feedback
ok deraadt zinke
|
|
|
|
ok claudio
|
|
the LSDB. So adjust SPF calculation to not trigger a fatal.
Problem found and fix tested by Chris Wopat
|
|
set (or extend) a timer and only reload when this expires. Avoids repeatedly
dumping full kernel routes (thus generating more load) when the machine has
problems keeping up with messages on the route socket. (if you see lots of
repeated "reloading interface list and routing table" in ospfd logs, this
will help).
Suggestions/ok claudio@.
|
|
"ospfd -v" (previously only "-vd" worked). Feedback on earlier implementation
from henning@ blambert@ claudio@, ok claudio@
|
|
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@
This needs a -current kernel or link state may be not reported correctly.
|
|
|
|
may only be set on directly connected networks but not on router
nodes which are used by the P2P links. Fix for PR 6597. OK sthen@
|
|
hold about any data you like and is used for things like greaceful
reload. Implement the basic redistribute logic and LSDB handling but
the data sent is currently not looked at.
Tested and OK sthen@
|
|
to IF_STA_LOOPBACK in if_act_start() this way they will repsect
IFF_UP on startup. Also remove a now no longer needed workaround
when reloading interfaces.
Initial diff provided by Patrick Coleman. OK dlg@
|
|
|
|
|
|
No functional change
|
|
"it's worth killing, if just to stop it being copied all over the place"
|
|
Removes some of the rather strange packet handling.
Tested by a few especially sthen@
|
|
leak is a runtime one.
OK bluhm@
|
|
Change the code in such a way that single huge LSA get fragmented
but avoid IP fragmentation when packing multiple ones.
Problem found and fix tested by Benjamin Papillon.
Tested & OK sthen@
|
|
packets use a better upper bound based on IP_MAXPACKET. Also change
one IBUF_READ_SIZE to READ_BUF_SIZE since that is what the rest of
the code uses. Tested and OK sthen@
|
|
|
|
"whichever one is a thousandth of a second is the one i am ok with" dlg@
|
|
so that the correct sequence number is used for the LSA. So re-lookup the
vertex before calling lsa_merge().
Problem found and diff OK bluhm@
|
|
Select a different LS ID in case of a conflict. The most specific
route keeps the LS ID the others will try their broadcast addr
first and then count down. The redistributed asext LSA are now
stored in a RB tree to make this all work.
Tested by a few people no problems seen so far.
|
|
disturbed me for a long time and makes upcomming work a bit easier.
OK sthen@, phessler@
|
|
ok claudio@
|
|
chain. Fix kroute_insert() and rtmsg_process() to correctly do this.
OK bluhm@
|
|
|
|
used to quickly verify if two LSDBs are in sync. Other systems do the same.
OK dlg@
|