summaryrefslogtreecommitdiff
path: root/usr.sbin/ospfd
AgeCommit message (Collapse)Author
2006-03-15There is no need to check iface != NULL. These parser rules are only allowedClaudio Jeker
if iface is set and so the check is superfluous. OK norby@
2006-03-15Looks like auth-type simple was busted since a long time. We bcmp() aClaudio Jeker
c string with a lenght <= 8 with a buffer of size 8. Now in some cases there can be trailing garbage after the c-string and so the bcmp() fails. Found by Sergey Matveychuk who provided a similar patch. OK norby@
2006-03-14Kill unneeded util.h include.Claudio Jeker
2006-03-13The return value of the start/stop timer functions is almost never checked.Claudio Jeker
Switch them to void functions and check if evtimer_add/del fails -- in which case we fatal() as there is no useful way to recover in such an event. OK norby@
2006-03-09Track interface uptime.Esben Norby
ok claudio@
2006-03-09Add some NOTREACHED to please lint.Claudio Jeker
2006-03-09More spring cleaning with lint. Change a few types and add some comments toClaudio Jeker
help lint.
2006-03-09It seems that 60 secs is a reasonable amount of time to reach state FULL.Esben Norby
2006-03-09Move *_name functions to log.c and use these for both ospfd and ospfctl.Claudio Jeker
Stuff that is only used in ospfd debug messages is simplified. OK norby@
2006-03-09Correctly warn about unsupported interface types as it is done in other places.Claudio Jeker
2006-03-09KNF, remove some unneded type casts and add some ARGSUSED. This makes lintClaudio Jeker
almost happy.
2006-03-09Mark event callbacks with ARGSUSED to silence lint.Claudio Jeker
2006-03-09Switch send_packet from char * to void * and from int to size_t. The functionClaudio Jeker
is now similar to sendto et al.
2006-03-09in_cksum() should return a u_int16_t and not int. Switch a variable toClaudio Jeker
unsigned. Found by lint.
2006-03-09if_event_names is only used by interface.c so move it there.Claudio Jeker
2006-03-09Log link state changes.Esben Norby
ok claudio@
2006-03-08Remove unused quit flag inherited from bgpd long ago.Claudio Jeker
2006-03-08Cleanup with lint. Kill unused variable and fix some types.Claudio Jeker
2006-03-08Move procnames from log.h to log.c it is only used there.Claudio Jeker
2006-03-08Spaces and other minor cleanup.Claudio Jeker
2006-03-08Fix logic of the kroute code. First of all there was a porblem if a prefixClaudio Jeker
is known via kernel and ospf. If the kernel route is removed the ospf one was not added to the FIB. This is an uncommon event so it is OK to request an update from the RIB in this case. Additionally ospfd treated bgpd inserted routes like static routes. This is wrong because IGP routes habe a higher preference over EGP routes. In this case a bgpd route needs to be overridden by a ospfd one. With these to fixes bgpd and ospfd start to play nicely together. OK norby@
2006-03-08Check for implied acks. If we receive an update that is on our retransmissionClaudio Jeker
queue for the neighbor there is no need to send back an ack.
2006-02-24Keep track of the uptime of the entries in the RIB.Esben Norby
It is now possible to see the uptime of the individual entries in the RIB. The uptime can be displayed with "ospfctl show rib" ok claudio@
2006-02-23Prevent ospfd from crashing when LSA Ext's are changed.Esben Norby
ok claudio@
2006-02-23Rework the LSA cache and make it behave. Until now we only used the type,Claudio Jeker
id and adv router as hash and that resulted and weird behaviour. Because the age was not used in the compare it was almost impossible to MAXAGE some LSAs in busy networks. The result was a slowly growing retransmission queue and an ospf engine spending way to much time traversing these sometimes huge queues. Now we just hash the full lsa_hdr and so age is included. Additionally correctly age LSAs in the retransmission queues. ok ok ok ok ok ok and a lot of help (plus a busy OSPF network) norby@
2006-02-21Better English in comments.Claudio Jeker
2006-02-21Correctly count the number of LSAs in the retransmission list. OK norby@Claudio Jeker
2006-02-19Keep track of the duration of our relationships with neighbors.Esben Norby
Displayed in "ospfctl show neighbor". ok claudio@
2006-02-19Do not kick the adj_timer for neighbors that are in state 2-Way.Esben Norby
ok claudio@
2006-02-19Do not traverse the entire LS retransmission list to figure out how manyEsben Norby
are present on it. ok claudio@
2006-02-19Do not allocate a new chunk of memory every time we receive a packet.Esben Norby
This should have been fixed ages ago since it really improves the performance of ospfd. ok claudio@
2006-02-15Do not try to dirty an area when adding LSA ext.Esben Norby
OK henning@
2006-02-10ospfd does not need fd passing via the imsg framework so remove that codeClaudio Jeker
and remove other unneeded functions that are only used in bgpd.
2006-02-10If ABR only look in the backbone area 0.0.0.0 for summary LSA. OK norby@Claudio Jeker
2006-02-09Don't calculate all areas every time the link state database is updated,Esben Norby
only calculate the dirty ones. ok claudio@
2006-02-09Prevent the neighbor FSM from getting stuck forever in state EXSTART.Esben Norby
ok claudio@
2006-02-03Cleanup and "simplify" iso checksum implementation. OK norby@Claudio Jeker
2006-02-02Be less verbose about DR/BDR selection this seems to be rock solid now.Claudio Jeker
OK norby@
2006-02-02zap md_list_empty, found by lint.Esben Norby
ok claudio@
2006-02-02zap cand_list_empty, found by lint.Esben Norby
ok claudio@
2006-02-01spf_calc should only do what the name says - calculate the spf tree.Esben Norby
ok claudio@
2006-02-01Wrong type, found by lint.Esben Norby
ok claudio@
2006-02-01variable naming, a -> addr.Esben Norby
ok claudio@
2006-02-01zap unused function.Esben Norby
ok claudio@
2006-01-26Separate route table calculations from the SPF calculation.Esben Norby
ok claudio@
2006-01-24Correct debug textEsben Norby
2006-01-24Fix bad indent.Esben Norby
2006-01-24Split SPF calc and AS Ext calc.Esben Norby
Initial diff by claudio@ reworked by me. test and ok claudio@
2006-01-23Kill stupid comment. "not reached" after a continue is superfluous.Claudio Jeker
2006-01-20Explicitly include limits.h if we are going to use its contents.Todd C. Miller